[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292017#comment-14292017 ] ASF GitHub Bot commented on FLINK-1395: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-71487780 I'm going to merge the changes in this pull request into a custom branch. I'll open a new pull request (FLINK-1417) containing the commit from this PR. @aljoscha: Can you close this PR? Add Jodatime support to Kryo Key: FLINK-1395 URL: https://issues.apache.org/jira/browse/FLINK-1395 Project: Flink Issue Type: Sub-task Reporter: Robert Metzger Assignee: Robert Metzger -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292040#comment-14292040 ] ASF GitHub Bot commented on FLINK-1395: --- Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/304 Add Jodatime support to Kryo Key: FLINK-1395 URL: https://issues.apache.org/jira/browse/FLINK-1395 Project: Flink Issue Type: Sub-task Reporter: Robert Metzger Assignee: Robert Metzger -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291653#comment-14291653 ] Robert Metzger commented on FLINK-1395: --- [~aljoscha] I'm going to assign the issue to myself because I'm fixing this as part of FLINK-1417 (see also the mailing list discussion on this). Add Jodatime support to Kryo Key: FLINK-1395 URL: https://issues.apache.org/jira/browse/FLINK-1395 Project: Flink Issue Type: Sub-task Reporter: Robert Metzger Assignee: Aljoscha Krettek -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278498#comment-14278498 ] ASF GitHub Bot commented on FLINK-1395: --- Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22999053 --- Diff: flink-java/pom.xml --- @@ -64,6 +64,18 @@ under the License. version0.5.1/version /dependency + dependency --- End diff -- They are actually optional dependencies. They are not included unless we explicitly include them. Add Jodatime support to Kryo Key: FLINK-1395 URL: https://issues.apache.org/jira/browse/FLINK-1395 Project: Flink Issue Type: Bug Reporter: Robert Metzger Assignee: Aljoscha Krettek -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278510#comment-14278510 ] ASF GitHub Bot commented on FLINK-1395: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-70063665 I added to LICENSE AND NOTICE and also addressed the other issues. Add Jodatime support to Kryo Key: FLINK-1395 URL: https://issues.apache.org/jira/browse/FLINK-1395 Project: Flink Issue Type: Bug Reporter: Robert Metzger Assignee: Aljoscha Krettek -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277647#comment-14277647 ] ASF GitHub Bot commented on FLINK-1395: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-69988955 Ok, I looked at the existing LICENSE and NOTICE files and they don't contain any entries for apache licences projects. jodatime and the kaffee serialisers are also apache licenced, that's why I didn't add any entries for them either. Add Jodatime support to Kryo Key: FLINK-1395 URL: https://issues.apache.org/jira/browse/FLINK-1395 Project: Flink Issue Type: Bug Reporter: Robert Metzger Assignee: Aljoscha Krettek -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277644#comment-14277644 ] ASF GitHub Bot commented on FLINK-1395: --- Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22968592 --- Diff: flink-java/pom.xml --- @@ -64,6 +64,18 @@ under the License. version0.5.1/version /dependency + dependency --- End diff -- This is pulling some unneeded dependencies: https://github.com/magro/kryo-serializers/blob/master/pom.xml for example cglib,org.apache.wicket, Add Jodatime support to Kryo Key: FLINK-1395 URL: https://issues.apache.org/jira/browse/FLINK-1395 Project: Flink Issue Type: Bug Reporter: Robert Metzger Assignee: Aljoscha Krettek -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[
https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277635#comment-14277635
]
ASF GitHub Bot commented on FLINK-1395:
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r22968315
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/KryoGenericTypeSerializerTest.scala
---
@@ -125,6 +133,7 @@ class KryoGenericTypeSerializerTest {
def runTests[T : ClassTag](objects: Seq[T]): Unit ={
val clsTag = classTag[T]
val typeInfo = new
GenericTypeInfo[T](clsTag.runtimeClass.asInstanceOf[Class[T]])
+println(TPE: + typeInfo)
--- End diff --
Yes, my bad.
Add Jodatime support to Kryo
Key: FLINK-1395
URL: https://issues.apache.org/jira/browse/FLINK-1395
Project: Flink
Issue Type: Bug
Reporter: Robert Metzger
Assignee: Aljoscha Krettek
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[
https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277634#comment-14277634
]
ASF GitHub Bot commented on FLINK-1395:
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r22968293
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java
---
@@ -99,6 +104,7 @@ public void testCopy() {
for (T datum : testData) {
T copy = serializer.copy(datum);
+ String str = copy.toString();
--- End diff --
Will change.
Add Jodatime support to Kryo
Key: FLINK-1395
URL: https://issues.apache.org/jira/browse/FLINK-1395
Project: Flink
Issue Type: Bug
Reporter: Robert Metzger
Assignee: Aljoscha Krettek
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277379#comment-14277379 ] ASF GitHub Bot commented on FLINK-1395: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-69964529 Good work. Here are some comments/questions - jodatime has many classes beyond `DateTime`, such as for example `LocalDate`. Should we register them all? They are many, so it may be an idea to have something like a common serializer util registers them for you. - We definitely need to list jodatime and the kaffee serializers in the LICENSE and NOTICE files of the binary distribution. Add Jodatime support to Kryo Key: FLINK-1395 URL: https://issues.apache.org/jira/browse/FLINK-1395 Project: Flink Issue Type: Bug Reporter: Robert Metzger Assignee: Aljoscha Krettek -- This message was sent by Atlassian JIRA (v6.3.4#6332)
