[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329578#comment-17329578 ] Flink Jira Bot commented on FLINK-1472: --- This issue is assigned but has not received an update in 7 days so it has been labeled "stale-assigned". If you are still working on the issue, please give an update and remove the label. If you are no longer working on the issue, please unassign so someone else may work on it. In 7 days the issue will be automatically unassigned. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Runtime / Web Frontend >Affects Versions: 0.10.0 >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > Labels: stale-assigned, stale-minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321774#comment-17321774 ] Flink Jira Bot commented on FLINK-1472: --- This issue and all of its Sub-Tasks have not been updated for 180 days. So, it has been labeled "stale-minor". If you are still affected by this bug or are still interested in this issue, please give an update and remove the label. In 7 days the issue will be closed automatically. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Runtime / Web Frontend >Affects Versions: 0.10.0 >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > Labels: stale-minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572753#comment-15572753 ] Greg Hogan commented on FLINK-1472: --- Building a registry of configuration options will be straightforward with FLINK-4764. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 0.10.0 >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987318#comment-14987318 ] ASF GitHub Bot commented on FLINK-1472: --- Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-153366209 Yes, this should be addressed through a new PR. The JIRA issue FLINK-1472 is still open. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987238#comment-14987238 ] ASF GitHub Bot commented on FLINK-1472: --- Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-153347995 @fhueske This issue is present in the new frontend also. See the attached screenshot:  We should probably continue in another PR though. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945249#comment-14945249 ] ASF GitHub Bot commented on FLINK-1472: --- Github user qmlmoon closed the pull request at: https://github.com/apache/flink/pull/439 > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945011#comment-14945011 ] ASF GitHub Bot commented on FLINK-1472: --- Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-145854280 @qmlmoon We merged a new web dashboard a few days ago which makes this PR obsolete. Sorry for not merging it earlier. Could you close this PR please? Thank you > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: 1.0 >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509032#comment-14509032 ] ASF GitHub Bot commented on FLINK-1472: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95581307 I added a Jira for this: https://issues.apache.org/jira/browse/FLINK-1936 > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509017#comment-14509017 ] ASF GitHub Bot commented on FLINK-1472: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95580562 Yes, but then we should change this now and not build more code on top of this that can fail in the future if someone forgets to add the names to the correct hash set in some other class. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509006#comment-14509006 ] ASF GitHub Bot commented on FLINK-1472: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95579057 I agree to enforce normalization in the `ConfigConstants`, by adding a test case that reflectively gets all fields and checks whether they start with "DEFAULT_" or end in "_KEY". The mapping between keys/values will probably have to be done manually, unless we add annotations above the key fields declaring what the default value is. The type of the default value should help to figure out what "get" method to use. (getInteger, getDouble) in order to get the correct conversion method. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508941#comment-14508941 ] ASF GitHub Bot commented on FLINK-1472: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95561718 But then I think the solution is to normalise the constants in ConfigConstants. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508778#comment-14508778 ] ASF GitHub Bot commented on FLINK-1472: --- Github user qmlmoon commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95523387 That would be a nice way, but 1) key/value pairs are not always distinguished by _KEY suffix, we have to format all the fields in ConfigConstants 2) some values are not in the ConfigConstants. e.g task manager slot = 1, akka_startup_time=aka_ask_timeout In summary, we need a formatted one-to-one map of the key/value pairs in ConfigConstants > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508756#comment-14508756 ] ASF GitHub Bot commented on FLINK-1472: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-95517673 Hi, sorry for the long wait on this. I really like the feature but the implementation is not scalable: If new config values are added this needs to be updated in several places now. Could you change ConfigConstants and add a static initializer block that builds the hash maps that you manually build in DefaultConfigKeyValues using reflection. The code would just need to loop through all fields that have _KEY at the end, and then find the matching default value without the _KEY at the end. From the default value field the type of the value can be determined and it can be added to the appropriate hash map. This way, the defaults will always stay up to date with the actual config constants. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376698#comment-14376698 ] ASF GitHub Bot commented on FLINK-1472: --- Github user qmlmoon commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-85207647 The default key value pairs are added manually. It seems that some of the keys in `ConfigConstant` is deleted recently. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376533#comment-14376533 ] ASF GitHub Bot commented on FLINK-1472: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-85170765 According to travis, the code doesn't seem to build. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352026#comment-14352026 ] ASF GitHub Bot commented on FLINK-1472: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-77746861 Nice, looks good to me. +1 to merge > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351972#comment-14351972 ] ASF GitHub Bot commented on FLINK-1472: --- Github user qmlmoon commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-77739274 The configuration view is separated into user and default now:  > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336989#comment-14336989 ] ASF GitHub Bot commented on FLINK-1472: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/439#issuecomment-76031299 I like the idea - that means that the webfrontend now shows what values are actually used, even if they are not in the config. To make it even nicer, it would be cool to: - Show which values come from the config (top) and show for which ones what default is used (in a second section below) - add a Unit test that checks that all keys from the `ConfigConstants` are converted. I think it is easy to check this via enumerating all fields in the class using reflection. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1472) Web frontend config overview shows wrong value
[ https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336784#comment-14336784 ] ASF GitHub Bot commented on FLINK-1472: --- GitHub user qmlmoon opened a pull request: https://github.com/apache/flink/pull/439 [FLINK-1472] Fixed Web frontend config overview with wrong value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/qmlmoon/incubator-flink web-conf Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #439 commit 2906789b6124e9f84baf05c1c555dfad9b1e2a64 Author: mingliang Date: 2015-02-25T11:27:01Z [FLINK-1472] Fixed Web frontend config overview with wrong value. > Web frontend config overview shows wrong value > -- > > Key: FLINK-1472 > URL: https://issues.apache.org/jira/browse/FLINK-1472 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Affects Versions: master >Reporter: Ufuk Celebi >Assignee: Mingliang Qi >Priority: Minor > > The web frontend shows configuration values even if they could not be > correctly parsed. > For example I've configured the number of buffers as "123.000", which cannot > be parsed as an Integer by GlobalConfiguration and the default value is used. > Still, the web frontend shows the not used "123.000". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
