[jira] [Commented] (FLINK-14831) When edit flink-metrics-influxdb, need add metrics.md by hand
[
https://issues.apache.org/jira/browse/FLINK-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995493#comment-16995493
]
ouyangwulin commented on FLINK-14831:
-
I will close this jira, I know your mean.
> When edit flink-metrics-influxdb, need add metrics.md by hand
> --
>
> Key: FLINK-14831
> URL: https://issues.apache.org/jira/browse/FLINK-14831
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Runtime / Metrics
>Reporter: ouyangwulin
>Priority: Major
>
> When edit flink-metrics-influxdb, need add metrics.md by hand. AND
> {code:java}
> mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests{code}
> , Is not work
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14831) When edit flink-metrics-influxdb, need add metrics.md by hand
[
https://issues.apache.org/jira/browse/FLINK-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995480#comment-16995480
]
Chesnay Schepler commented on FLINK-14831:
--
I already explained this in the PR where you stumbled on this; the generator
enforces uniqueness (or rather well-defined-ness) among all keys, but since the
influx options are just suffixes they easily clash with other reporters.
> When edit flink-metrics-influxdb, need add metrics.md by hand
> --
>
> Key: FLINK-14831
> URL: https://issues.apache.org/jira/browse/FLINK-14831
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Runtime / Metrics
>Reporter: ouyangwulin
>Priority: Major
>
> When edit flink-metrics-influxdb, need add metrics.md by hand. AND
> {code:java}
> mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests{code}
> , Is not work
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14831) When edit flink-metrics-influxdb, need add metrics.md by hand
[
https://issues.apache.org/jira/browse/FLINK-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995283#comment-16995283
]
ouyangwulin commented on FLINK-14831:
-
[~rmetzger] I have try to fixed this problems. and add
'ConfigOptionsDocGenerator', but It conflict with 'metrics.prometheus' when
validate ‘host’。 So the metric report only 'prometheus' was generator doc auto
> When edit flink-metrics-influxdb, need add metrics.md by hand
> --
>
> Key: FLINK-14831
> URL: https://issues.apache.org/jira/browse/FLINK-14831
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Runtime / Metrics
>Reporter: ouyangwulin
>Priority: Major
>
> When edit flink-metrics-influxdb, need add metrics.md by hand. AND
> {code:java}
> mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests{code}
> , Is not work
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14831) When edit flink-metrics-influxdb, need add metrics.md by hand
[
https://issues.apache.org/jira/browse/FLINK-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994784#comment-16994784
]
Robert Metzger commented on FLINK-14831:
I don't know the docs generator too well, but I believe the influxdb reporter
is not in the list of options class locations:
{code:java}
public class ConfigOptionsDocGenerator {
static final OptionsClassLocation[] LOCATIONS = new OptionsClassLocation[]{
new OptionsClassLocation("flink-core", "org.apache.flink.configuration"),
new OptionsClassLocation("flink-runtime", "org.apache.flink.runtime.shuffle"),
new OptionsClassLocation("flink-runtime", "org.apache.flink.runtime.jobgraph"),
new OptionsClassLocation("flink-yarn", "org.apache.flink.yarn.configuration"),
new OptionsClassLocation("flink-mesos",
"org.apache.flink.mesos.configuration"),
new OptionsClassLocation("flink-mesos",
"org.apache.flink.mesos.runtime.clusterframework"),
new OptionsClassLocation("flink-metrics/flink-metrics-prometheus",
"org.apache.flink.metrics.prometheus"),
new OptionsClassLocation("flink-state-backends/flink-statebackend-rocksdb",
"org.apache.flink.contrib.streaming.state"),
new OptionsClassLocation("flink-table/flink-table-api-java",
"org.apache.flink.table.api.config"),
new OptionsClassLocation("flink-python", "org.apache.flink.python")
};{code}
[~ouyangwuli] Are you interested in contributing a fix for this ticket yourself?
> When edit flink-metrics-influxdb, need add metrics.md by hand
> --
>
> Key: FLINK-14831
> URL: https://issues.apache.org/jira/browse/FLINK-14831
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Runtime / Metrics
>Reporter: ouyangwulin
>Priority: Major
>
> When edit flink-metrics-influxdb, need add metrics.md by hand. AND
> {code:java}
> mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests{code}
> , Is not work
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14831) When edit flink-metrics-influxdb, need add metrics.md by hand
[
https://issues.apache.org/jira/browse/FLINK-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977066#comment-16977066
]
ouyangwulin commented on FLINK-14831:
-
[~yunta] ， I add a option config in \{InfluxdbReporterOptions}, and add
describe, Other module like this action， just use mvn command to add the docs,
but this module need , add 'metrics.md' by hand .
> When edit flink-metrics-influxdb, need add metrics.md by hand
> --
>
> Key: FLINK-14831
> URL: https://issues.apache.org/jira/browse/FLINK-14831
> Project: Flink
> Issue Type: Improvement
>Reporter: ouyangwulin
>Priority: Major
>
> When edit flink-metrics-influxdb, need add metrics.md by hand. AND
> {code:java}
> mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests{code}
> , Is not work
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14831) When edit flink-metrics-influxdb, need add metrics.md by hand
[
https://issues.apache.org/jira/browse/FLINK-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976714#comment-16976714
]
Yun Tang commented on FLINK-14831:
--
[~ouyangwuli], actually I did not really got what you mean. Why we need to add
{{metrics.md}} when editing {{flink-metrics-influxdb}} module?
> When edit flink-metrics-influxdb, need add metrics.md by hand
> --
>
> Key: FLINK-14831
> URL: https://issues.apache.org/jira/browse/FLINK-14831
> Project: Flink
> Issue Type: Improvement
>Reporter: ouyangwulin
>Priority: Major
>
> When edit flink-metrics-influxdb, need add metrics.md by hand. AND
> {code:java}
> mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests{code}
> , Is not work
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14831) When edit flink-metrics-influxdb, need add metrics.md by hand
[
https://issues.apache.org/jira/browse/FLINK-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975933#comment-16975933
]
ouyangwulin commented on FLINK-14831:
-
can assign this for me
> When edit flink-metrics-influxdb, need add metrics.md by hand
> --
>
> Key: FLINK-14831
> URL: https://issues.apache.org/jira/browse/FLINK-14831
> Project: Flink
> Issue Type: Improvement
>Reporter: ouyangwulin
>Priority: Major
>
> When edit flink-metrics-influxdb, need add metrics.md by hand. AND
> {code:java}
> mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests{code}
> , Is not work
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
