[jira] [Commented] (FLINK-14910) disableAutoGeneratedUIDs fails on keyBy

2019-11-28 Thread Dawid Wysakowicz (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984586#comment-16984586
 ] 

Dawid Wysakowicz commented on FLINK-14910:
--

I think an easy  fix would be to perform the check introduced in FLINK-11653 
only for {{PhysicalTransformation}}. We create {{StreamOperators}} only for 
those. We can set uids for all of them.

Will prepare a fix shortly.

> disableAutoGeneratedUIDs fails on keyBy
> ---
>
> Key: FLINK-14910
> URL: https://issues.apache.org/jira/browse/FLINK-14910
> Project: Flink
>  Issue Type: Bug
>  Components: API / DataStream
>Affects Versions: 1.9.0
>Reporter: William Cheng
>Assignee: Dawid Wysakowicz
>Priority: Major
>
> There doesn't seem to be a way to add a UID to the Partition operator created 
> by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
>  
> Here's a simple test case that will reproduce the issue:
> {noformat}
>  @Test
> public void testFailedUID() throws Exception {
> StreamExecutionEnvironment env = 
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().disableAutoGeneratedUIDs();
> DataStream data = env.fromCollection(Arrays.asList("1", "2", 
> "3")).uid("source-uid");
> data.keyBy(i -> i)
> .map(i -> i).uid("map-uid");
> env.execute();
> }{noformat}
> {noformat}
> testFailedUID(twitch.creatoranalytics.sessions.StreamingJobTest)  Time 
> elapsed: 0.008 sec  <<< ERROR!
> java.lang.IllegalStateException: Auto generated UIDs have been disabled but 
> no UID or hash has been assigned to operator Partition
>  {noformat}
>  
> This passes if the keyBy is removed. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14910) disableAutoGeneratedUIDs fails on keyBy

2019-11-28 Thread Dawid Wysakowicz (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984579#comment-16984579
 ] 

Dawid Wysakowicz commented on FLINK-14910:
--

Thanks for letting us now. Will have a look into it.

> disableAutoGeneratedUIDs fails on keyBy
> ---
>
> Key: FLINK-14910
> URL: https://issues.apache.org/jira/browse/FLINK-14910
> Project: Flink
>  Issue Type: Bug
>  Components: API / DataStream
>Affects Versions: 1.9.0
>Reporter: William Cheng
>Priority: Major
>
> There doesn't seem to be a way to add a UID to the Partition operator created 
> by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
>  
> Here's a simple test case that will reproduce the issue:
> {noformat}
>  @Test
> public void testFailedUID() throws Exception {
> StreamExecutionEnvironment env = 
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().disableAutoGeneratedUIDs();
> DataStream data = env.fromCollection(Arrays.asList("1", "2", 
> "3")).uid("source-uid");
> data.keyBy(i -> i)
> .map(i -> i).uid("map-uid");
> env.execute();
> }{noformat}
> {noformat}
> testFailedUID(twitch.creatoranalytics.sessions.StreamingJobTest)  Time 
> elapsed: 0.008 sec  <<< ERROR!
> java.lang.IllegalStateException: Auto generated UIDs have been disabled but 
> no UID or hash has been assigned to operator Partition
>  {noformat}
>  
> This passes if the keyBy is removed. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14910) disableAutoGeneratedUIDs fails on keyBy

2019-11-28 Thread Chesnay Schepler (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984574#comment-16984574
 ] 

Chesnay Schepler commented on FLINK-14910:
--

[~sjwiesman] [~dwysakowicz] Looks like some special cases were not accounted 
for in FLINK-11653?

> disableAutoGeneratedUIDs fails on keyBy
> ---
>
> Key: FLINK-14910
> URL: https://issues.apache.org/jira/browse/FLINK-14910
> Project: Flink
>  Issue Type: Bug
>Reporter: William Cheng
>Priority: Major
>
> There doesn't seem to be a way to add a UID to the Partition operator created 
> by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
>  
> Here's a simple test case that will reproduce the issue:
> {noformat}
>  @Test
> public void testFailedUID() throws Exception {
> StreamExecutionEnvironment env = 
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().disableAutoGeneratedUIDs();
> DataStream data = env.fromCollection(Arrays.asList("1", "2", 
> "3")).uid("source-uid");
> data.keyBy(i -> i)
> .map(i -> i).uid("map-uid");
> env.execute();
> }{noformat}
> {noformat}
> testFailedUID(twitch.creatoranalytics.sessions.StreamingJobTest)  Time 
> elapsed: 0.008 sec  <<< ERROR!
> java.lang.IllegalStateException: Auto generated UIDs have been disabled but 
> no UID or hash has been assigned to operator Partition
>  {noformat}
>  
> This passes if the keyBy is removed. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-14910) disableAutoGeneratedUIDs fails on keyBy

2019-11-21 Thread William Cheng (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979467#comment-16979467
 ] 

William Cheng commented on FLINK-14910:
---

dota2ruhub userID: 100814397

Data is missing for a stream starting at 11/15/2019 17:32:47

> disableAutoGeneratedUIDs fails on keyBy
> ---
>
> Key: FLINK-14910
> URL: https://issues.apache.org/jira/browse/FLINK-14910
> Project: Flink
>  Issue Type: Bug
>Reporter: William Cheng
>Priority: Major
>
> There doesn't seem to be a way to add a UID to the Partition operator created 
> by KeyBy, causing `disableAutoGeneratedUIDs` to fail.
>  
> Here's a simple test case that will reproduce the issue:
> {noformat}
>  @Test
> public void testFailedUID() throws Exception {
> StreamExecutionEnvironment env = 
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().disableAutoGeneratedUIDs();
> DataStream data = env.fromCollection(Arrays.asList("1", "2", 
> "3")).uid("source-uid");
> data.keyBy(i -> i)
> .map(i -> i).uid("map-uid");
> env.execute();
> }{noformat}
> {noformat}
> testFailedUID(twitch.creatoranalytics.sessions.StreamingJobTest)  Time 
> elapsed: 0.008 sec  <<< ERROR!
> java.lang.IllegalStateException: Auto generated UIDs have been disabled but 
> no UID or hash has been assigned to operator Partition
>  {noformat}
>  
> This passes if the keyBy is removed. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)