[jira] [Commented] (FLINK-15584) Give nested data type of ROWs in ValidationException

2020-03-04 Thread Jingsong Lee (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051840#comment-17051840
 ] 

Jingsong Lee commented on FLINK-15584:
--

[~ayushsaxena]:D Ah... OK~

> Give nested data type of ROWs in ValidationException
> 
>
> Key: FLINK-15584
> URL: https://issues.apache.org/jira/browse/FLINK-15584
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Legacy Planner
>Affects Versions: 1.9.1, 1.10.0, 1.11.0
>Reporter: Benoît Paris
>Assignee: Ayush Saxena
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.10.1, 1.11.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In 
> {code:java}
> INSERT INTO baz_sink
> SELECT
>   a,
>   ROW(b, c)
> FROM foo_source{code}
> Schema mismatch mistakes will not get proper detail level, yielding the 
> following:
> Caused by: org.apache.flink.table.api.ValidationException: Field types of 
> query result and registered TableSink [baz_sink] do not match.
>  Query result schema: [a: Integer, EXPR$2: Row]
>  TableSink schema: [a: Integer, payload: Row]
> Leaving the user with an opaque 'Row' type to debug.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15584) Give nested data type of ROWs in ValidationException

2020-03-04 Thread Ayush Saxena (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051809#comment-17051809
 ] 

Ayush Saxena commented on FLINK-15584:
--

Thanx [~rmetzger] [~lzljs3620320] for the review and commit.
Can you assign it my correct Jira id, it is {{ayushtkn}}. This ticket seems to 
be assigned to different id

> Give nested data type of ROWs in ValidationException
> 
>
> Key: FLINK-15584
> URL: https://issues.apache.org/jira/browse/FLINK-15584
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Legacy Planner
>Affects Versions: 1.9.1, 1.10.0, 1.11.0
>Reporter: Benoît Paris
>Assignee: Ayush Saxena
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.10.1, 1.11.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In 
> {code:java}
> INSERT INTO baz_sink
> SELECT
>   a,
>   ROW(b, c)
> FROM foo_source{code}
> Schema mismatch mistakes will not get proper detail level, yielding the 
> following:
> Caused by: org.apache.flink.table.api.ValidationException: Field types of 
> query result and registered TableSink [baz_sink] do not match.
>  Query result schema: [a: Integer, EXPR$2: Row]
>  TableSink schema: [a: Integer, payload: Row]
> Leaving the user with an opaque 'Row' type to debug.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15584) Give nested data type of ROWs in ValidationException

2020-03-04 Thread Jingsong Lee (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051732#comment-17051732
 ] 

Jingsong Lee commented on FLINK-15584:
--

[~rmetzger] Sorry for late review.

Master: 3408eade79f59f7f9228c39ccc976ed5baab0581

release-1.10: 2949348e7be93fb0c60f7d329342155598d42dc5

> Give nested data type of ROWs in ValidationException
> 
>
> Key: FLINK-15584
> URL: https://issues.apache.org/jira/browse/FLINK-15584
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Legacy Planner
>Affects Versions: 1.9.1, 1.10.0, 1.11.0
>Reporter: Benoît Paris
>Assignee: Ayush Saxena
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.10.1, 1.11.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In 
> {code:java}
> INSERT INTO baz_sink
> SELECT
>   a,
>   ROW(b, c)
> FROM foo_source{code}
> Schema mismatch mistakes will not get proper detail level, yielding the 
> following:
> Caused by: org.apache.flink.table.api.ValidationException: Field types of 
> query result and registered TableSink [baz_sink] do not match.
>  Query result schema: [a: Integer, EXPR$2: Row]
>  TableSink schema: [a: Integer, payload: Row]
> Leaving the user with an opaque 'Row' type to debug.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15584) Give nested data type of ROWs in ValidationException

2020-02-27 Thread Robert Metzger (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046528#comment-17046528
 ] 

Robert Metzger commented on FLINK-15584:


[~lzljs3620320] can you take a look at the proposed pull request?

Ayush, I've assigned you tho this ticket.


> Give nested data type of ROWs in ValidationException
> 
>
> Key: FLINK-15584
> URL: https://issues.apache.org/jira/browse/FLINK-15584
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Legacy Planner
>Affects Versions: 1.9.1, 1.10.0, 1.11.0
>Reporter: Benoît Paris
>Assignee: Ayush Saxena
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In 
> {code:java}
> INSERT INTO baz_sink
> SELECT
>   a,
>   ROW(b, c)
> FROM foo_source{code}
> Schema mismatch mistakes will not get proper detail level, yielding the 
> following:
> Caused by: org.apache.flink.table.api.ValidationException: Field types of 
> query result and registered TableSink [baz_sink] do not match.
>  Query result schema: [a: Integer, EXPR$2: Row]
>  TableSink schema: [a: Integer, payload: Row]
> Leaving the user with an opaque 'Row' type to debug.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15584) Give nested data type of ROWs in ValidationException

2020-02-03 Thread Ayush Saxena (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028984#comment-17028984
 ] 

Ayush Saxena commented on FLINK-15584:
--

Anybody helping review..

[~sewen] [~aljoscha] can you help review!!!

 

> Give nested data type of ROWs in ValidationException
> 
>
> Key: FLINK-15584
> URL: https://issues.apache.org/jira/browse/FLINK-15584
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Planner
>Affects Versions: 1.9.1, 1.10.0, 1.11.0
>Reporter: Benoît Paris
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In 
> {code:java}
> INSERT INTO baz_sink
> SELECT
>   a,
>   ROW(b, c)
> FROM foo_source{code}
> Schema mismatch mistakes will not get proper detail level, yielding the 
> following:
> Caused by: org.apache.flink.table.api.ValidationException: Field types of 
> query result and registered TableSink [baz_sink] do not match.
>  Query result schema: [a: Integer, EXPR$2: Row]
>  TableSink schema: [a: Integer, payload: Row]
> Leaving the user with an opaque 'Row' type to debug.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15584) Give nested data type of ROWs in ValidationException

2020-01-30 Thread Ayush Saxena (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026897#comment-17026897
 ] 

Ayush Saxena commented on FLINK-15584:
--

Thanx [~BenoitParis] for the report. Makes sense to change.

Have raised PR.

Someone Pls help review!!!

> Give nested data type of ROWs in ValidationException
> 
>
> Key: FLINK-15584
> URL: https://issues.apache.org/jira/browse/FLINK-15584
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Planner
>Affects Versions: 1.9.1, 1.10.0, 1.11.0
>Reporter: Benoît Paris
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In 
> {code:java}
> INSERT INTO baz_sink
> SELECT
>   a,
>   ROW(b, c)
> FROM foo_source{code}
> Schema mismatch mistakes will not get proper detail level, yielding the 
> following:
> Caused by: org.apache.flink.table.api.ValidationException: Field types of 
> query result and registered TableSink [baz_sink] do not match.
>  Query result schema: [a: Integer, EXPR$2: Row]
>  TableSink schema: [a: Integer, payload: Row]
> Leaving the user with an opaque 'Row' type to debug.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-15584) Give nested data type of ROWs in ValidationException

2020-01-14 Thread Jingsong Lee (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015059#comment-17015059
 ] 

Jingsong Lee commented on FLINK-15584:
--

Thanks [~BenoitParis] for investigation. FLINK-15546 is a similar problem. 
Looks like a lot of places need consider print type instead of TypeRoot.

> Give nested data type of ROWs in ValidationException
> 
>
> Key: FLINK-15584
> URL: https://issues.apache.org/jira/browse/FLINK-15584
> Project: Flink
>  Issue Type: Improvement
>Affects Versions: 1.9.1, 1.10.0, 1.11.0
>Reporter: Benoît Paris
>Priority: Minor
>
> In 
> {code:java}
> INSERT INTO baz_sink
> SELECT
>   a,
>   ROW(b, c)
> FROM foo_source{code}
> Schema mismatch mistakes will not get proper detail level, yielding the 
> following:
> Caused by: org.apache.flink.table.api.ValidationException: Field types of 
> query result and registered TableSink [baz_sink] do not match.
>  Query result schema: [a: Integer, EXPR$2: Row]
>  TableSink schema: [a: Integer, payload: Row]
> Leaving the user with an opaque 'Row' type to debug.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)