[jira] [Commented] (FLINK-1744) Change the reference of slaves to workers to match the description of the system
[ https://issues.apache.org/jira/browse/FLINK-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484648#comment-14484648 ] Henry Saputra commented on FLINK-1744: -- No worries, we could always re-open it when needed. Change the reference of slaves to workers to match the description of the system Key: FLINK-1744 URL: https://issues.apache.org/jira/browse/FLINK-1744 Project: Flink Issue Type: Improvement Components: core, Documentation Reporter: Henry Saputra Priority: Trivial There are some references to slaves which actually mean workers. Need to change it to use workers whenever possible, unless it is needed when communicating with external system like Apache Hadoop -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1744) Change the reference of slaves to workers to match the description of the system
[ https://issues.apache.org/jira/browse/FLINK-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376010#comment-14376010 ] Henry Saputra commented on FLINK-1744: -- If this is too much of a distraction for now, I could just close it and maybe revisit it in the future. Change the reference of slaves to workers to match the description of the system Key: FLINK-1744 URL: https://issues.apache.org/jira/browse/FLINK-1744 Project: Flink Issue Type: Improvement Components: core, Documentation Reporter: Henry Saputra Priority: Trivial There are some references to slaves which actually mean workers. Need to change it to use workers whenever possible, unless it is needed when communicating with external system like Apache Hadoop -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1744) Change the reference of slaves to workers to match the description of the system
[ https://issues.apache.org/jira/browse/FLINK-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376033#comment-14376033 ] Robert Metzger commented on FLINK-1744: --- Oh ... sorry. I didn't want to ask you to close the issue. I'm not sure how the other committers think about this. Maybe others agree with the change. I'm hesitant here because all changes to scripts, config files etc. often break a lot of things (automated testing setups, docker/VM scripts, debian/rpm packages, other packaging). Even worse, these things are hard to test. Change the reference of slaves to workers to match the description of the system Key: FLINK-1744 URL: https://issues.apache.org/jira/browse/FLINK-1744 Project: Flink Issue Type: Improvement Components: core, Documentation Reporter: Henry Saputra Priority: Trivial There are some references to slaves which actually mean workers. Need to change it to use workers whenever possible, unless it is needed when communicating with external system like Apache Hadoop -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1744) Change the reference of slaves to workers to match the description of the system
[ https://issues.apache.org/jira/browse/FLINK-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375972#comment-14375972 ] Henry Saputra commented on FLINK-1744: -- It is common but it is coming from old term of master-slaves architecture. The term Flink uses is worker for the nodes that do all the work. I filed this JIRA to see if it is better for Flink match the terms used in the project. Change the reference of slaves to workers to match the description of the system Key: FLINK-1744 URL: https://issues.apache.org/jira/browse/FLINK-1744 Project: Flink Issue Type: Improvement Components: core, Documentation Reporter: Henry Saputra There are some references to slaves which actually mean workers. Need to change it to use workers whenever possible, unless it is needed when communicating with external system like Apache Hadoop -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1744) Change the reference of slaves to workers to match the description of the system
[
https://issues.apache.org/jira/browse/FLINK-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375621#comment-14375621
]
Robert Metzger commented on FLINK-1744:
---
I'm not sure if I'm understanding why you want to change these names. I though
that the file name {{slaves}} is common in Hadoop and other distributed systems
for a list of hostnames of the workers?
Change the reference of slaves to workers to match the description of the
system
Key: FLINK-1744
URL: https://issues.apache.org/jira/browse/FLINK-1744
Project: Flink
Issue Type: Improvement
Components: core, Documentation
Reporter: Henry Saputra
There are some references to slaves which actually mean workers.
Need to change it to use workers whenever possible, unless it is needed when
communicating with external system like Apache Hadoop
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1744) Change the reference of slaves to workers to match the description of the system
[
https://issues.apache.org/jira/browse/FLINK-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368071#comment-14368071
]
Henry Saputra commented on FLINK-1744:
--
Simple grep in the source code repo:
{code}
./docs/cluster_setup.md:After having saved the HDFS configuration file, open
the file *conf/slaves* and
./docs/cluster_setup.md:*conf/slaves* and enter the IP/host name of each worker
node. Each worker node
./docs/cluster_setup.md:SSH to all worker nodes listed in the *slaves* file to
start the
./docs/setup_quickstart.md:3. Add the IPs or hostnames (one per line) of all
__worker nodes__ (TaskManager) to the slaves files
./docs/setup_quickstart.md:in `conf/slaves`.
./docs/setup_quickstart.md:/path/to/strongflink/brconf/slaves/strong
./flink-dist/src/main/flink-bin/bin/start-cluster.sh:
HOSTLIST=${FLINK_CONF_DIR}/slaves
./flink-dist/src/main/flink-bin/bin/start-cluster.sh:echo $HOSTLIST is not
a valid slave list
./flink-dist/src/main/flink-bin/bin/start-cluster.sh:# cluster mode, bring up
job manager locally and a task manager on every slave host
./flink-dist/src/main/flink-bin/bin/stop-cluster.sh:
HOSTLIST=${FLINK_CONF_DIR}/slaves
./flink-dist/src/main/flink-bin/bin/stop-cluster.sh:echo $HOSTLIST is not a
valid slave list
./flink-dist/src/main/flink-bin/bin/stop-cluster.sh:# cluster mode, stop the
job manager locally and stop the task manager on every slave host
./flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/TypeUtils.scala:
val slave = MacroContextHolder.newMacroHelper(c)
./flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/TypeUtils.scala:
slave.mkTypeInfo[T]
./pom.xml:
exclude**/flink-bin/conf/slaves/exclude
{code}
Change the reference of slaves to workers to match the description of the
system
Key: FLINK-1744
URL: https://issues.apache.org/jira/browse/FLINK-1744
Project: Flink
Issue Type: Improvement
Components: core, Documentation
Reporter: Henry Saputra
There are some references to slaves which actually mean workers.
Need to change it to use workers whenever possible, unless it is needed when
communicating with external system like Apache Hadoop
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
