[jira] [Commented] (FLINK-1776) APIs provide invalid Semantic Properties for Operators with SelectorFunction keys
[ https://issues.apache.org/jira/browse/FLINK-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394966#comment-14394966 ] ASF GitHub Bot commented on FLINK-1776: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/532 APIs provide invalid Semantic Properties for Operators with SelectorFunction keys - Key: FLINK-1776 URL: https://issues.apache.org/jira/browse/FLINK-1776 Project: Flink Issue Type: Bug Components: Java API, Scala API Affects Versions: 0.9 Reporter: Fabian Hueske Assignee: Fabian Hueske Priority: Critical Fix For: 0.9 Semantic properties are defined by users and evaluated by the optimizer. When semantic properties such as forwarded or read fields are bound to the input type of a function. In case of operators with selector function keys, a user function is wrapped by a wrapping function that has a different input types than the original user function. However, the user-defined semantic properties are verbatim forwarded to the optimizer. Since the properties refer to a specific type which is changed by the wrapping function and the semantic properties are not adapted, the optimizer uses wrong properties and might produce invalid plans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1776) APIs provide invalid Semantic Properties for Operators with SelectorFunction keys
[ https://issues.apache.org/jira/browse/FLINK-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393169#comment-14393169 ] ASF GitHub Bot commented on FLINK-1776: --- Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/532#issuecomment-89010020 Will rebase and merge this in about 24h unless somebody raises a flag. APIs provide invalid Semantic Properties for Operators with SelectorFunction keys - Key: FLINK-1776 URL: https://issues.apache.org/jira/browse/FLINK-1776 Project: Flink Issue Type: Bug Components: Java API, Scala API Affects Versions: 0.9 Reporter: Fabian Hueske Assignee: Fabian Hueske Priority: Critical Fix For: 0.9 Semantic properties are defined by users and evaluated by the optimizer. When semantic properties such as forwarded or read fields are bound to the input type of a function. In case of operators with selector function keys, a user function is wrapped by a wrapping function that has a different input types than the original user function. However, the user-defined semantic properties are verbatim forwarded to the optimizer. Since the properties refer to a specific type which is changed by the wrapping function and the semantic properties are not adapted, the optimizer uses wrong properties and might produce invalid plans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1776) APIs provide invalid Semantic Properties for Operators with SelectorFunction keys
[ https://issues.apache.org/jira/browse/FLINK-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377789#comment-14377789 ] Stephan Ewen commented on FLINK-1776: - That is critical, I agree. Can we make the assumption that all fields are shifted by one (or as many as the key selector returns values) since the data gets wrapped in a tuple2(key, value)? APIs provide invalid Semantic Properties for Operators with SelectorFunction keys - Key: FLINK-1776 URL: https://issues.apache.org/jira/browse/FLINK-1776 Project: Flink Issue Type: Bug Components: Java API, Scala API Affects Versions: 0.9 Reporter: Fabian Hueske Assignee: Fabian Hueske Priority: Critical Fix For: 0.9 Semantic properties are defined by users and evaluated by the optimizer. When semantic properties such as forwarded or read fields are bound to the input type of a function. In case of operators with selector function keys, a user function is wrapped by a wrapping function that has a different input types than the original user function. However, the user-defined semantic properties are verbatim forwarded to the optimizer. Since the properties refer to a specific type which is changed by the wrapping function and the semantic properties are not adapted, the optimizer uses wrong properties and might produce invalid plans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1776) APIs provide invalid Semantic Properties for Operators with SelectorFunction keys
[ https://issues.apache.org/jira/browse/FLINK-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377907#comment-14377907 ] Fabian Hueske commented on FLINK-1776: -- The fix is straight-forward. We get the numbers of fields of the extracted grouping and sorting keys and add that offset to all indexes of input record fields. I am working on a fix for all affected operators. APIs provide invalid Semantic Properties for Operators with SelectorFunction keys - Key: FLINK-1776 URL: https://issues.apache.org/jira/browse/FLINK-1776 Project: Flink Issue Type: Bug Components: Java API, Scala API Affects Versions: 0.9 Reporter: Fabian Hueske Assignee: Fabian Hueske Priority: Critical Fix For: 0.9 Semantic properties are defined by users and evaluated by the optimizer. When semantic properties such as forwarded or read fields are bound to the input type of a function. In case of operators with selector function keys, a user function is wrapped by a wrapping function that has a different input types than the original user function. However, the user-defined semantic properties are verbatim forwarded to the optimizer. Since the properties refer to a specific type which is changed by the wrapping function and the semantic properties are not adapted, the optimizer uses wrong properties and might produce invalid plans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
