[jira] [Commented] (FLINK-17925) Fix Filesystem options to default values and types

2020-05-26 Thread Jingsong Lee (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117398#comment-17117398
 ] 

Jingsong Lee commented on FLINK-17925:
--

I have no obvious tendency, but I think "process-time" can be understood well.

> Fix Filesystem options to default values and types
> --
>
> Key: FLINK-17925
> URL: https://issues.apache.org/jira/browse/FLINK-17925
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / FileSystem
>Reporter: Jingsong Lee
>Assignee: Jingsong Lee
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 1.11.0
>
>
> Fix Filesystem options:
>  * Throws unsupported exception when using metastore commit policy for 
> filesystem table, Filesystem connector has an empty implementation in 
> {{TableMetaStoreFactory}}. We should avoid user configuring this policy.
>  * Default value of "sink.partition-commit.trigger" should be "process-time". 
> Users are hard to figure out what is wrong when they don't have watermark. We 
> can set "sink.partition-commit.trigger" to "process-time" to have better 
> out-of-box experience.
>  * The type of "sink.rolling-policy.file-size" should be MemoryType.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-17925) Fix Filesystem options to default values and types

2020-05-26 Thread Jark Wu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117388#comment-17117388
 ] 

Jark Wu commented on FLINK-17925:
-

I prefer "processing-time" because it is the concept glossary in Flink, 
{{TimeCharacteristic#ProcessingTime}}.

> Fix Filesystem options to default values and types
> --
>
> Key: FLINK-17925
> URL: https://issues.apache.org/jira/browse/FLINK-17925
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / FileSystem
>Reporter: Jingsong Lee
>Assignee: Jingsong Lee
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 1.11.0
>
>
> Fix Filesystem options:
>  * Throws unsupported exception when using metastore commit policy for 
> filesystem table, Filesystem connector has an empty implementation in 
> {{TableMetaStoreFactory}}. We should avoid user configuring this policy.
>  * Default value of "sink.partition-commit.trigger" should be "process-time". 
> Users are hard to figure out what is wrong when they don't have watermark. We 
> can set "sink.partition-commit.trigger" to "process-time" to have better 
> out-of-box experience.
>  * The type of "sink.rolling-policy.file-size" should be MemoryType.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-17925) Fix Filesystem options to default values and types

2020-05-25 Thread Jingsong Lee (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116402#comment-17116402
 ] 

Jingsong Lee commented on FLINK-17925:
--

I am OK with "proctime", "processing-time" and "process-time". Corresponding 
"partition-time", I choose "process-time".

> Fix Filesystem options to default values and types
> --
>
> Key: FLINK-17925
> URL: https://issues.apache.org/jira/browse/FLINK-17925
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / FileSystem
>Reporter: Jingsong Lee
>Assignee: Jingsong Lee
>Priority: Blocker
> Fix For: 1.11.0
>
>
> Fix Filesystem options:
>  * Throws unsupported exception when using metastore commit policy for 
> filesystem table, Filesystem connector has an empty implementation in 
> {{TableMetaStoreFactory}}. We should avoid user configuring this policy.
>  * Default value of "sink.partition-commit.trigger" should be "process-time". 
> Users are hard to figure out what is wrong when they don't have watermark. We 
> can set "sink.partition-commit.trigger" to "process-time" to have better 
> out-of-box experience.
>  * The type of "sink.rolling-policy.file-size" should be MemoryType.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-17925) Fix Filesystem options to default values and types

2020-05-25 Thread Jark Wu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116352#comment-17116352
 ] 

Jark Wu commented on FLINK-17925:
-

Should it be "processing-time"? 

> Fix Filesystem options to default values and types
> --
>
> Key: FLINK-17925
> URL: https://issues.apache.org/jira/browse/FLINK-17925
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / FileSystem
>Reporter: Jingsong Lee
>Assignee: Jingsong Lee
>Priority: Blocker
> Fix For: 1.11.0
>
>
> Fix Filesystem options:
>  * Throws unsupported exception when using metastore commit policy for 
> filesystem table, Filesystem connector has an empty implementation in 
> {{TableMetaStoreFactory}}. We should avoid user configuring this policy.
>  * Default value of "sink.partition-commit.trigger" should be "process-time". 
> Users are hard to figure out what is wrong when they don't have watermark. We 
> can set "sink.partition-commit.trigger" to "process-time" to have better 
> out-of-box experience.
>  * The type of "sink.rolling-policy.file-size" should be MemoryType.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)