[jira] [Commented] (FLINK-18240) Correct modulus function usage in documentation or allow % operator

2020-07-04 Thread Benchao Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151459#comment-17151459
 ] 

Benchao Li commented on FLINK-18240:


Fixed via 4b9f9fe35256462851dbb8e0076114c32e345243 (1.12.0)

> Correct modulus function usage in documentation or allow % operator
> ---
>
> Key: FLINK-18240
> URL: https://issues.apache.org/jira/browse/FLINK-18240
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Reporter: Jark Wu
>Assignee: Shengkai Fang
>Priority: Major
>  Labels: pull-request-available
>
> In the documentation: 
> https://ci.apache.org/projects/flink/flink-docs-release-1.10/dev/table/sql/queries.html#scan-projection-and-filter
> There is an example:
> {code}
> SELECT * FROM Orders WHERE a % 2 = 0
> {code}
> But % operator is not allowed in Flink:
> {code:java}
> org.apache.calcite.sql.parser.SqlParseException: Percent remainder '%' is not 
> allowed under the current SQL conformance level
> {code}
> Either we correct the documentation to use {{MOD}} function, or allow % 
> operator. 
> This is reported in user-zh ML: 
> http://apache-flink.147419.n8.nabble.com/FLINK-SQL-td3822.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18240) Correct modulus function usage in documentation or allow % operator

2020-07-02 Thread Shengkai Fang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150247#comment-17150247
 ] 

Shengkai Fang commented on FLINK-18240:
---

Hi [~jark] I'm very interested in this issue. Could you assign it to me? I'm 
willing to solve it.

> Correct modulus function usage in documentation or allow % operator
> ---
>
> Key: FLINK-18240
> URL: https://issues.apache.org/jira/browse/FLINK-18240
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Reporter: Jark Wu
>Priority: Major
>
> In the documentation: 
> https://ci.apache.org/projects/flink/flink-docs-release-1.10/dev/table/sql/queries.html#scan-projection-and-filter
> There is an example:
> {code}
> SELECT * FROM Orders WHERE a % 2 = 0
> {code}
> But % operator is not allowed in Flink:
> {code:java}
> org.apache.calcite.sql.parser.SqlParseException: Percent remainder '%' is not 
> allowed under the current SQL conformance level
> {code}
> Either we correct the documentation to use {{MOD}} function, or allow % 
> operator. 
> This is reported in user-zh ML: 
> http://apache-flink.147419.n8.nabble.com/FLINK-SQL-td3822.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18240) Correct modulus function usage in documentation or allow % operator

2020-06-11 Thread Benchao Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133858#comment-17133858
 ] 

Benchao Li commented on FLINK-18240:


[~Leonard Xu] I think you are right, we can support it this way. +1 to support 
it.

> Correct modulus function usage in documentation or allow % operator
> ---
>
> Key: FLINK-18240
> URL: https://issues.apache.org/jira/browse/FLINK-18240
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Reporter: Jark Wu
>Priority: Major
>
> In the documentation: 
> https://ci.apache.org/projects/flink/flink-docs-release-1.10/dev/table/sql/queries.html#scan-projection-and-filter
> There is an example:
> {code}
> SELECT * FROM Orders WHERE a % 2 = 0
> {code}
> But % operator is not allowed in Flink:
> {code:java}
> org.apache.calcite.sql.parser.SqlParseException: Percent remainder '%' is not 
> allowed under the current SQL conformance level
> {code}
> Either we correct the documentation to use {{MOD}} function, or allow % 
> operator. 
> This is reported in user-zh ML: 
> http://apache-flink.147419.n8.nabble.com/FLINK-SQL-td3822.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)