[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970984#comment-14970984
 ] 

ASF GitHub Bot commented on FLINK-1982:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1294


> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>Assignee: Fabian Hueske
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970819#comment-14970819
 ] 

ASF GitHub Bot commented on FLINK-1982:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1294#issuecomment-150543514
  
Will merge this PR


> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>Assignee: Fabian Hueske
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970675#comment-14970675
 ] 

ASF GitHub Bot commented on FLINK-1982:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1294#issuecomment-150521085
  
Thanks @hsaputra 
I renamed the class.


> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>Assignee: Fabian Hueske
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970089#comment-14970089
 ] 

ASF GitHub Bot commented on FLINK-1982:
---

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/flink/pull/1294#discussion_r42818462
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/MapTaskTest.java 
---
@@ -38,8 +37,7 @@
 import org.junit.Assert;
 import org.junit.Test;
 
-@SuppressWarnings("deprecation")
-public class MapTaskTest extends 
DriverTestBase> {
+public class MapTaskTest extends DriverTestBase> {
--- End diff --

Small nit: should probably rename this to ``FlatMapTaskTest`` since now it 
is actually using ``flatMap`` function instead?


> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>Assignee: Fabian Hueske
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970036#comment-14970036
 ] 

ASF GitHub Bot commented on FLINK-1982:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1294#issuecomment-150375992
  
Updated


> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>Assignee: Fabian Hueske
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969948#comment-14969948
 ] 

ASF GitHub Bot commented on FLINK-1982:
---

Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/1294#discussion_r42809588
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/MapTaskTest.java 
---
@@ -39,7 +38,7 @@
 import org.junit.Test;
 
 @SuppressWarnings("deprecation")
--- End diff --

Good catch, thanks!
Will check the other classes as well. 


> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>Assignee: Fabian Hueske
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969934#comment-14969934
 ] 

ASF GitHub Bot commented on FLINK-1982:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/1294#discussion_r42808744
  
--- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/MapTaskTest.java 
---
@@ -39,7 +38,7 @@
 import org.junit.Test;
 
 @SuppressWarnings("deprecation")
--- End diff --

this suppression can be removed


> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>Assignee: Fabian Hueske
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969911#comment-14969911
 ] 

ASF GitHub Bot commented on FLINK-1982:
---

GitHub user fhueske opened a pull request:

https://github.com/apache/flink/pull/1294

[FLINK-1982] [record-api] Remove dependencies on Record API from 
flink-runtime tests

Rename Match*Test to Join*Test

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fhueske/flink runtimeTestsRecord

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1294


commit 6367ad7e05eb81f1bf719beda0eeb972864ee568
Author: Fabian Hueske 
Date:   2015-10-22T19:10:41Z

[FLINK-1982] [record-api] Remove dependencies on Record API from 
flink-runtime tests

Rename Match*Test to Join*Test




> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>Assignee: Fabian Hueske
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-22 Thread Henry Saputra (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969821#comment-14969821
 ] 

Henry Saputra commented on FLINK-1982:
--

I am seeing TeraSortITCase extends RecordAPITestBase but neither seemed to 
actually access Record API.

> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-10-21 Thread Chesnay Schepler (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966820#comment-14966820
 ] 

Chesnay Schepler commented on FLINK-1982:
-

Which tests specifically still need porting?

> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-05-11 Thread Henry Saputra (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538253#comment-14538253
 ] 

Henry Saputra commented on FLINK-1982:
--

Thanks [~StephanEwen] !

As for terasort test, if we finally got to remove all tests dependency, would 
it be ok to disable the test to be able to remove the Record API?

My preference is to remove deprecated and not preferred APIs to use Flink.

> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-1982) Remove dependencies on Record for Flink runtime and core

2015-05-11 Thread Stephan Ewen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538156#comment-14538156
 ] 

Stephan Ewen commented on FLINK-1982:
-

I think the runtime and optimizer specializations can be removed with the API 
together in one patch.

The last blocker is probably that some of the runtime tests are implemented in 
the Record API. We would need to migrate some, many can probably be dropped, as 
they are redundant now.

The only test that we cannot port is the terasort test, because the other APIs 
do not yet support range partitioning.


> Remove dependencies on Record for Flink runtime and core
> 
>
> Key: FLINK-1982
> URL: https://issues.apache.org/jira/browse/FLINK-1982
> Project: Flink
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Henry Saputra
>
> Seemed like there are several uses of Record API in core and runtime module 
> that need to be updated before Record API could be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)