[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276896#comment-17276896 ] Xintong Song commented on FLINK-20359: -- Thanks [~pnowojski]. I've fixed the compiling error and opened another PR to verify the changes on the 1.12 branch. > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Assignee: Boris Lublinsky >Priority: Major > Labels: pull-request-available > Fix For: 1.12.2, 1.13.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271060#comment-17271060 ] Xintong Song commented on FLINK-20359: -- Unlink the following abandoned PRs, to make it explicit which is the valid PR for this ticket. https://github.com/apache/flink/pull/14281 https://github.com/apache/flink/pull/14512 https://github.com/apache/flink/pull/14529 > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Assignee: Boris Lublinsky >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.12.2 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266064#comment-17266064 ] Boris Lublinsky commented on FLINK-20359: - I can't find it any more > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Assignee: Boris Lublinsky >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.12.2 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265930#comment-17265930 ] Robert Metzger commented on FLINK-20359: Is this ticket a duplicate of FLINK-20359 ? > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Assignee: Boris Lublinsky >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.12.2 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254726#comment-17254726 ] Xintong Song commented on FLINK-20359: -- [~lublinsky], I've assigned you. Will take a look at the PR asap. [~fly_in_gis], I'm marking the fix version 1.12.1 for now. Will update if this does not get fixed by the release. > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Assignee: Boris Lublinsky >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0, 1.12.1 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254723#comment-17254723 ] Yang Wang commented on FLINK-20359: --- cc [~xintongsong] Could you please assign this ticket to [~lublinsky]? I will have a look on the PR in this week. But I do not think it could be a blocker of 1.12.1. > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245989#comment-17245989 ] Boris Lublinsky commented on FLINK-20359: - It does not > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[
https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245919#comment-17245919
]
Till Rohrmann commented on FLINK-20359:
---
If the change does not change the default behaviour of Flink, then we can also
include it in {{1.12.X}}.
> Support adding Owner Reference to Job Manager in native kubernetes setup
>
>
> Key: FLINK-20359
> URL: https://issues.apache.org/jira/browse/FLINK-20359
> Project: Flink
> Issue Type: New Feature
> Components: Deployment / Kubernetes
>Affects Versions: 1.11.2
>Reporter: Boris Lublinsky
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> Flink implementation is often a part of the larger application. As a result a
> synchronized management - clean up of Flink resources, when a main
> application is deleted is important. In Kubernetes, a common approach for
> such clean up is usage of the owner's reference
> ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)]
> Adding owner reference support to Flink Job manager would be a nice addition
> to Flink kubernetes native support to accommodate such use cases
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245914#comment-17245914 ] Boris Lublinsky commented on FLINK-20359: - Is it possible to do it before 1.13 - 1.12.X? > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Priority: Major > Labels: pull-request-available > Fix For: 1.13.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241612#comment-17241612 ] Boris Lublinsky commented on FLINK-20359: - Redid PR https://github.com/apache/flink/pull/14281 > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Priority: Major > Fix For: 1.12.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241300#comment-17241300 ] Yang Wang commented on FLINK-20359: --- [~lublinsky] Thanks for your contribution. Could you please split the PR-14265 into some dedicated small PRs? Each PR has a corresponding JIRA ticket. And I think we could get this ticket done first. For the volume mounting support FLINK-15649, we need to get more feedback from other users/devs. > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Priority: Major > Fix For: 1.12.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241195#comment-17241195 ] Boris Lublinsky commented on FLINK-20359: - Implementation is here [https://github.com/apache/flink/pull/14265] > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Priority: Major > Fix For: 1.12.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239009#comment-17239009 ] Yang Wang commented on FLINK-20359: --- If you could, I prefer to spin off the implementation of this ticket from [PR-14005| [https://github.com/apache/flink/pull/14005].] Then it will be easier to review. Also could you refine the commit message based on our contribution guide[1]? [1]. https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#commit-naming-conventions > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Priority: Major > Fix For: 1.12.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-20359) Support adding Owner Reference to Job Manager in native kubernetes setup
[ https://issues.apache.org/jira/browse/FLINK-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238891#comment-17238891 ] Boris Lublinsky commented on FLINK-20359: - An implementation of such support is part of An implementation of such support is provided in this pull request [https://github.com/apache/flink/pull/14005] > Support adding Owner Reference to Job Manager in native kubernetes setup > > > Key: FLINK-20359 > URL: https://issues.apache.org/jira/browse/FLINK-20359 > Project: Flink > Issue Type: New Feature > Components: Deployment / Kubernetes >Affects Versions: 1.11.2 >Reporter: Boris Lublinsky >Priority: Major > Fix For: 1.12.0 > > > Flink implementation is often a part of the larger application. As a result a > synchronized management - clean up of Flink resources, when a main > application is deleted is important. In Kubernetes, a common approach for > such clean up is usage of the owner's reference > ([https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/)] > Adding owner reference support to Flink Job manager would be a nice addition > to Flink kubernetes native support to accommodate such use cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
