[jira] [Commented] (FLINK-21220) Change the type of cpuCores in ResourceProfile to CPUResource

2021-02-26 Thread Chesnay Schepler (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-21220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291540#comment-17291540
 ] 

Chesnay Schepler commented on FLINK-21220:
--

[~karmagyz] sounds good

> Change the type of cpuCores in ResourceProfile to CPUResource
> -
>
> Key: FLINK-21220
> URL: https://issues.apache.org/jira/browse/FLINK-21220
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yangze Guo
>Priority: Minor
>  Labels: starter
>
> The {{cpuCores}} field in {{ResourceProfile}} should always be the 
> CPUResource. There is no need to generalize it to {{Resource}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-21220) Change the type of cpuCores in ResourceProfile to CPUResource

2021-02-18 Thread Yangze Guo (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-21220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286908#comment-17286908
 ] 

Yangze Guo commented on FLINK-21220:


[~chesnay] I think it has the following benefits:
- No need to check the argument type of the {{cpuCores}} when construct 
{{ResourceProfile}}.
- No need to manually do the type conversion when call the 
{{ResourceProfile#getCpuCores}}.

> Change the type of cpuCores in ResourceProfile to CPUResource
> -
>
> Key: FLINK-21220
> URL: https://issues.apache.org/jira/browse/FLINK-21220
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yangze Guo
>Priority: Minor
>  Labels: starter
>
> The {{cpuCores}} field in {{ResourceProfile}} should always be the 
> CPUResource. There is no need to generalize it to {{Resource}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-21220) Change the type of cpuCores in ResourceProfile to CPUResource

2021-02-12 Thread Chesnay Schepler (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-21220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283577#comment-17283577
 ] 

Chesnay Schepler commented on FLINK-21220:
--

Out of curiosity, what would be the benefit of changing it? The {{CPUResource}} 
doesn't seem to offer anything special.

> Change the type of cpuCores in ResourceProfile to CPUResource
> -
>
> Key: FLINK-21220
> URL: https://issues.apache.org/jira/browse/FLINK-21220
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Reporter: Yangze Guo
>Priority: Minor
>  Labels: starter
>
> The {{cpuCores}} field in {{ResourceProfile}} should always be the 
> CPUResource. There is no need to generalize it to {{Resource}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)