[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-04-20 Thread Flink Jira Bot (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326138#comment-17326138
 ] 

Flink Jira Bot commented on FLINK-21464:


This issue is assigned but has not received an update in 7 days so it has been 
labeled "stale-assigned". If you are still working on the issue, please give an 
update and remove the label. If you are no longer working on the issue, please 
unassign so someone else may work on it. In 7 days the issue will be 
automatically unassigned.

> Support ADD JAR command in sql client
> -
>
> Key: FLINK-21464
> URL: https://issues.apache.org/jira/browse/FLINK-21464
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Assignee: xiangtao
>Priority: Major
>  Labels: stale-assigned
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-04-12 Thread Shengkai Fang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319831#comment-17319831
 ] 

Shengkai Fang commented on FLINK-21464:
---

[~xiangtao] Thanks for your contribution. Will take a look soon.

> Support ADD JAR command in sql client
> -
>
> Key: FLINK-21464
> URL: https://issues.apache.org/jira/browse/FLINK-21464
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Assignee: xiangtao
>Priority: Major
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-04-11 Thread xiangtao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319019#comment-17319019
 ] 

xiangtao commented on FLINK-21464:
--

[~fsk119] PR submitted : https://github.com/apache/flink/pull/15558

> Support ADD JAR command in sql client
> -
>
> Key: FLINK-21464
> URL: https://issues.apache.org/jira/browse/FLINK-21464
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Assignee: xiangtao
>Priority: Major
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-04-08 Thread xiangtao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317302#comment-17317302
 ] 

xiangtao commented on FLINK-21464:
--

Hi [~fsk119] , i've found a solution. i will submit a PR soon ~~

 

> Support ADD JAR command in sql client
> -
>
> Key: FLINK-21464
> URL: https://issues.apache.org/jira/browse/FLINK-21464
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Assignee: xiangtao
>Priority: Major
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-04-05 Thread xiangtao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314917#comment-17314917
 ] 

xiangtao commented on FLINK-21464:
--

[~fsk119]  i'm sorry , my reply is a little late . 

my implementation plan is as follows: 
 # sql-client has one option `-j` that cloud add jar to sql classpath. so i can 
use this feature. 
 # when execute `add jar foo.jar` ,  need to store this jar list  to 
`SessionContext` as a member variable .  

 #  final when execute a select/insert/update  sql ,  it need to load this jar 
to `URLClassLoader` in `ExecutionContext`  because invoke sql  by `
context.wrapClassLoader(() -> tEnv.executeInternal(operation))` in 
`ExecutionContext`

but i has a question , how to support unload a jar use `remove jar` ? 

 

 

> Support ADD JAR command in sql client
> -
>
> Key: FLINK-21464
> URL: https://issues.apache.org/jira/browse/FLINK-21464
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Assignee: xiangtao
>Priority: Major
> Fix For: 1.14.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-04-01 Thread Shengkai Fang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313535#comment-17313535
 ] 

Shengkai Fang commented on FLINK-21464:
---

Any progress? [~xiangtao]

> Support ADD JAR command in sql client
> -
>
> Key: FLINK-21464
> URL: https://issues.apache.org/jira/browse/FLINK-21464
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Assignee: xiangtao
>Priority: Major
> Fix For: 1.13.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-03-26 Thread xiangtao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309475#comment-17309475
 ] 

xiangtao commented on FLINK-21464:
--

[~fsk119] , [~jark]  please assign to me. maybe I can try to implement  this 
feature.

> Support ADD JAR command in sql client
> -
>
> Key: FLINK-21464
> URL: https://issues.apache.org/jira/browse/FLINK-21464
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
> Fix For: 1.13.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-03-22 Thread zoucao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306305#comment-17306305
 ] 

zoucao commented on FLINK-21464:


hi [~fsk119] and [~jark], in FLIP-163, only local jar is considered, maybe we 
can consider to support local jar and remote jar(http/https) in the future by 
using URLCLassLoader.

> Support ADD JAR command in sql client
> -
>
> Key: FLINK-21464
> URL: https://issues.apache.org/jira/browse/FLINK-21464
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Client
>Affects Versions: 1.13.0
>Reporter: Shengkai Fang
>Priority: Major
> Fix For: 1.13.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)