[jira] [Commented] (FLINK-22776) Delete casting to byte[] in AbstractJdbcRowConverter class
[
https://issues.apache.org/jira/browse/FLINK-22776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356118#comment-17356118
]
Ada Wong commented on FLINK-22776:
--
cc [~jark] please assign it to me. thanks.
> Delete casting to byte[] in AbstractJdbcRowConverter class
> --
>
> Key: FLINK-22776
> URL: https://issues.apache.org/jira/browse/FLINK-22776
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / JDBC, Table SQL / Ecosystem
>Affects Versions: 1.13.0
>Reporter: Ada Wong
>Priority: Minor
> Labels: pull-request-available
> Attachments: image-2021-05-26-10-38-04-578.png
>
>
> Casting to 'byte[]' is redundant. Could we delete it?
> {code:java}
> case BINARY:
> case VARBINARY:
> return val -> (byte[]) val;
> {code}
> !image-2021-05-26-10-38-04-578.png|thumbnail!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22776) Delete casting to byte[] in AbstractJdbcRowConverter class
[
https://issues.apache.org/jira/browse/FLINK-22776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354851#comment-17354851
]
luoyuxia commented on FLINK-22776:
--
+1
I think we can delete it.
You can sumit pr and we will review it for you.
> Delete casting to byte[] in AbstractJdbcRowConverter class
> --
>
> Key: FLINK-22776
> URL: https://issues.apache.org/jira/browse/FLINK-22776
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / JDBC, Table SQL / Ecosystem
>Affects Versions: 1.13.0
>Reporter: Ada Wong
>Priority: Minor
> Attachments: image-2021-05-26-10-38-04-578.png
>
>
> Casting to 'byte[]' is redundant. Could we delete it?
> {code:java}
> case BINARY:
> case VARBINARY:
> return val -> (byte[]) val;
> {code}
> !image-2021-05-26-10-38-04-578.png|thumbnail!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22776) Delete casting to byte[] in AbstractJdbcRowConverter class
[ https://issues.apache.org/jira/browse/FLINK-22776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351451#comment-17351451 ] Ada Wong commented on FLINK-22776: -- If we can do it, please assign to me. > Delete casting to byte[] in AbstractJdbcRowConverter class > -- > > Key: FLINK-22776 > URL: https://issues.apache.org/jira/browse/FLINK-22776 > Project: Flink > Issue Type: Improvement > Components: Connectors / JDBC >Affects Versions: 1.13.0 >Reporter: Ada Wong >Priority: Minor > Attachments: image-2021-05-26-10-38-04-578.png > > > Casting to 'byte[]' is redundant. Could we delete it? > !image-2021-05-26-10-38-04-578.png|thumbnail! -- This message was sent by Atlassian Jira (v8.3.4#803005)
