[jira] [Commented] (FLINK-2362) distinct is missing in DataSet API documentation
[
https://issues.apache.org/jira/browse/FLINK-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635630#comment-14635630
]
ASF GitHub Bot commented on FLINK-2362:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/922
distinct is missing in DataSet API documentation
Key: FLINK-2362
URL: https://issues.apache.org/jira/browse/FLINK-2362
Project: Flink
Issue Type: Bug
Components: Documentation, Java API, Scala API
Affects Versions: 0.9, 0.10
Reporter: Fabian Hueske
Assignee: pietro pinoli
Fix For: 0.10, 0.9.1
The DataSet transformation {{distinct}} is not described or listed in the
documentation. It is not contained in the DataSet API programming guide
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/programming_guide.html)
and not in the DataSet Transformation
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/dataset_transformations.html)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2362) distinct is missing in DataSet API documentation
[
https://issues.apache.org/jira/browse/FLINK-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635173#comment-14635173
]
ASF GitHub Bot commented on FLINK-2362:
---
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/922#issuecomment-123330725
Looks good, will merge this...
distinct is missing in DataSet API documentation
Key: FLINK-2362
URL: https://issues.apache.org/jira/browse/FLINK-2362
Project: Flink
Issue Type: Bug
Components: Documentation, Java API, Scala API
Affects Versions: 0.9, 0.10
Reporter: Fabian Hueske
Assignee: pietro pinoli
Fix For: 0.10, 0.9.1
The DataSet transformation {{distinct}} is not described or listed in the
documentation. It is not contained in the DataSet API programming guide
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/programming_guide.html)
and not in the DataSet Transformation
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/dataset_transformations.html)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2362) distinct is missing in DataSet API documentation
[
https://issues.apache.org/jira/browse/FLINK-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633150#comment-14633150
]
ASF GitHub Bot commented on FLINK-2362:
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/922#discussion_r34974826
--- Diff: docs/apis/dataset_transformations.md ---
@@ -924,6 +924,183 @@ Not supported.
**Note:** Extending the set of supported aggregation functions is on our
roadmap.
+### Distinct
+
+The Distinct transformation computes the DataSet of the distinct elements
of the source DataSet.
+The following code removes from the DataSet the duplicate elements:
--- End diff --
I'd rephrase this sentence to
The following code removes duplicate elements from the DataSet:
distinct is missing in DataSet API documentation
Key: FLINK-2362
URL: https://issues.apache.org/jira/browse/FLINK-2362
Project: Flink
Issue Type: Bug
Components: Documentation, Java API, Scala API
Affects Versions: 0.9, 0.10
Reporter: Fabian Hueske
Assignee: pietro pinoli
Fix For: 0.10, 0.9.1
The DataSet transformation {{distinct}} is not described or listed in the
documentation. It is not contained in the DataSet API programming guide
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/programming_guide.html)
and not in the DataSet Transformation
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/dataset_transformations.html)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2362) distinct is missing in DataSet API documentation
[
https://issues.apache.org/jira/browse/FLINK-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633152#comment-14633152
]
ASF GitHub Bot commented on FLINK-2362:
---
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/922#issuecomment-122805962
Thanks for improving the documentation. Looks good to merge for me.
distinct is missing in DataSet API documentation
Key: FLINK-2362
URL: https://issues.apache.org/jira/browse/FLINK-2362
Project: Flink
Issue Type: Bug
Components: Documentation, Java API, Scala API
Affects Versions: 0.9, 0.10
Reporter: Fabian Hueske
Assignee: pietro pinoli
Fix For: 0.10, 0.9.1
The DataSet transformation {{distinct}} is not described or listed in the
documentation. It is not contained in the DataSet API programming guide
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/programming_guide.html)
and not in the DataSet Transformation
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/dataset_transformations.html)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2362) distinct is missing in DataSet API documentation
[
https://issues.apache.org/jira/browse/FLINK-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633189#comment-14633189
]
ASF GitHub Bot commented on FLINK-2362:
---
Github user pp86 commented on the pull request:
https://github.com/apache/flink/pull/922#issuecomment-122815918
Thanks for the suggestion @mxm , I updated the documentation.
distinct is missing in DataSet API documentation
Key: FLINK-2362
URL: https://issues.apache.org/jira/browse/FLINK-2362
Project: Flink
Issue Type: Bug
Components: Documentation, Java API, Scala API
Affects Versions: 0.9, 0.10
Reporter: Fabian Hueske
Assignee: pietro pinoli
Fix For: 0.10, 0.9.1
The DataSet transformation {{distinct}} is not described or listed in the
documentation. It is not contained in the DataSet API programming guide
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/programming_guide.html)
and not in the DataSet Transformation
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/dataset_transformations.html)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2362) distinct is missing in DataSet API documentation
[
https://issues.apache.org/jira/browse/FLINK-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633428#comment-14633428
]
ASF GitHub Bot commented on FLINK-2362:
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/922#discussion_r34984880
--- Diff: docs/apis/programming_guide.md ---
@@ -606,7 +606,17 @@ DataSetTuple3Integer, String, Double output =
input.sum(0).andMin(2);
/td
/tr
+tr
+ tdstrongDistinct/strong/td
+ td
+pReturns the distinct elements of a data set./p
--- End diff --
Could you add a sentence here to explain what distinct means?
distinct is missing in DataSet API documentation
Key: FLINK-2362
URL: https://issues.apache.org/jira/browse/FLINK-2362
Project: Flink
Issue Type: Bug
Components: Documentation, Java API, Scala API
Affects Versions: 0.9, 0.10
Reporter: Fabian Hueske
Assignee: pietro pinoli
Fix For: 0.10, 0.9.1
The DataSet transformation {{distinct}} is not described or listed in the
documentation. It is not contained in the DataSet API programming guide
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/programming_guide.html)
and not in the DataSet Transformation
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/dataset_transformations.html)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2362) distinct is missing in DataSet API documentation
[
https://issues.apache.org/jira/browse/FLINK-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632953#comment-14632953
]
ASF GitHub Bot commented on FLINK-2362:
---
GitHub user pp86 opened a pull request:
https://github.com/apache/flink/pull/922
[FLINK-2362] - distinct is missing in DataSet API documentation
add scala and java documentation for the distinct transformation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pp86/flink distinctDoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/922.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #922
commit 942dc1a51e44195ef907ae5c75fba3b3162e8771
Author: Pietro Pinoli pie...@pietros-mbp.lan
Date: 2015-07-19T22:51:52Z
add scala and java documentation for the distinct transformation
distinct is missing in DataSet API documentation
Key: FLINK-2362
URL: https://issues.apache.org/jira/browse/FLINK-2362
Project: Flink
Issue Type: Bug
Components: Documentation, Java API, Scala API
Affects Versions: 0.9, 0.10
Reporter: Fabian Hueske
Assignee: pietro pinoli
Fix For: 0.10, 0.9.1
The DataSet transformation {{distinct}} is not described or listed in the
documentation. It is not contained in the DataSet API programming guide
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/programming_guide.html)
and not in the DataSet Transformation
(https://ci.apache.org/projects/flink/flink-docs-release-0.9/apis/dataset_transformations.html)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
