[jira] [Commented] (FLINK-24802) Improve cast ROW to STRING
[ https://issues.apache.org/jira/browse/FLINK-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448559#comment-17448559 ] Fabian Paul commented on FLINK-24802: - Resolved on master: 44ed268426ac96d27402d57243234387d6e05c48 > Improve cast ROW to STRING > -- > > Key: FLINK-24802 > URL: https://issues.apache.org/jira/browse/FLINK-24802 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Timo Walther >Assignee: Shen Zhu >Priority: Major > Labels: pull-request-available > > When casting ROW to string, we should have a space after the comma to be > consistent with ARRAY, MAP, etc. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-24802) Improve cast ROW to STRING
[ https://issues.apache.org/jira/browse/FLINK-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446856#comment-17446856 ] Shen Zhu commented on FLINK-24802: -- Thanks [~slinkydeveloper] ! I created a PR for this ticket, would you mind taking a look at it when you have a moment? > Improve cast ROW to STRING > -- > > Key: FLINK-24802 > URL: https://issues.apache.org/jira/browse/FLINK-24802 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Timo Walther >Assignee: Shen Zhu >Priority: Major > Labels: pull-request-available > > When casting ROW to string, we should have a space after the comma to be > consistent with ARRAY, MAP, etc. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-24802) Improve cast ROW to STRING
[ https://issues.apache.org/jira/browse/FLINK-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444328#comment-17444328 ] Francesco Guardiani commented on FLINK-24802: - That's all yours, thank you! If you need any help, feel free to ping me in the comments here. > Improve cast ROW to STRING > -- > > Key: FLINK-24802 > URL: https://issues.apache.org/jira/browse/FLINK-24802 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Timo Walther >Assignee: Shen Zhu >Priority: Major > > When casting ROW to string, we should have a space after the comma to be > consistent with ARRAY, MAP, etc. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-24802) Improve cast ROW to STRING
[ https://issues.apache.org/jira/browse/FLINK-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444268#comment-17444268 ] Shen Zhu commented on FLINK-24802: -- Got it, thanks [~slinkydeveloper] ! I'm interested in picking up this ticket, would you mind assigning it to me? > Improve cast ROW to STRING > -- > > Key: FLINK-24802 > URL: https://issues.apache.org/jira/browse/FLINK-24802 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Timo Walther >Priority: Major > > When casting ROW to string, we should have a space after the comma to be > consistent with ARRAY, MAP, etc. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-24802) Improve cast ROW to STRING
[ https://issues.apache.org/jira/browse/FLINK-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442839#comment-17442839 ] Francesco Guardiani commented on FLINK-24802: - Hi [~shenzhu0127], timo is referring to this class: https://github.com/apache/flink/blob/da24fbf23c244771084bf0a31cdbb9749d72e80a/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RowToStringCastRule.java similar issue applies to ARRAY and MAP types > Improve cast ROW to STRING > -- > > Key: FLINK-24802 > URL: https://issues.apache.org/jira/browse/FLINK-24802 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Timo Walther >Priority: Major > > When casting ROW to string, we should have a space after the comma to be > consistent with ARRAY, MAP, etc. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-24802) Improve cast ROW to STRING
[ https://issues.apache.org/jira/browse/FLINK-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440850#comment-17440850 ] Shen Zhu commented on FLINK-24802: -- Hey Timo, I was checking the unit tests and seems casting from ROW to String is not supported either implicitly or explicitly: [https://github.com/apache/flink/blob/master/flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/LogicalTypeCastsTest.java#L159] Do you mean adding one explicit conversion for this? Thanks, Shen > Improve cast ROW to STRING > -- > > Key: FLINK-24802 > URL: https://issues.apache.org/jira/browse/FLINK-24802 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Timo Walther >Priority: Major > > When casting ROW to string, we should have a space after the comma to be > consistent with ARRAY, MAP, etc. -- This message was sent by Atlassian Jira (v8.20.1#820001)
