[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736922#comment-14736922
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1094#issuecomment-138923580
  
@chenliang613, thanks for the PR!
I'll check it and merge it if everything is fine. 


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737012#comment-14737012
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1094


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
> Fix For: 0.10
>
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733417#comment-14733417
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1094#issuecomment-138239089
  
Looks nice.

Can you help me quickly? I would like to understand why the internal maven 
dependencies on the Java examples have problems when you use the "finalName" 
classifier?


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733570#comment-14733570
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user chenliang613 commented on the pull request:

https://github.com/apache/flink/pull/1094#issuecomment-138276703
  
Just as maillist the last message mentioned: 
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/jira-FLINK-2493-Simplify-names-of-example-program-JARs-td7495.html.

After use the tag of "finalName" to replace classifier,

flink-scala-examples/flink-streaming-examples/flink-storm-compatibility-example"
  can't correctly unpack "flink-java-examples-0.10-SNAPSHOT.jar", have the 
below error:

[ERROR] 
/Users/chenliang/flink/flink-examples/flink-scala-examples/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala:148:
 error: not found: value KMeansData 
[ERROR]   val points = KMeansData.POINTS map { 
[ERROR]^ 
[WARNING] 
/Users/chenliang/flink/flink-examples/flink-scala-examples/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala:161:
 warning: Type org.apache.flink.examples.scala.clustering.KMeans.Centroid is no 
POJO, has immutable fields: value y, value x. 
[WARNING] .map { x => new Centroid(x._1, x._2, x._3)} 
[WARNING]  ^ 
[ERROR] 
/Users/chenliang/flink/flink-examples/flink-scala-examples/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala:164:
 error: not found: value KMeansData 
[ERROR]   val centroids = KMeansData.CENTROIDS map { 





> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733686#comment-14733686
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1094#issuecomment-138294037
  
Strange, the dependency here should not be dependent on the individual 
program jars, but on the aggregate `flink-java-examples-0.10-SNAPSHOT.jar`, 
which is not affected by the change...

Anyways, as long as your version works, let's use it :-)


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730854#comment-14730854
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user chenliang613 commented on the pull request:

https://github.com/apache/flink/pull/1087#issuecomment-137744893
  
The CI failure be reported from flink-yarn-tests .but in my local machine, 
i did many times checking with "mvn clean verify" in flink-yarn-tests, all are 
successful. 

Tests run: 12, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 146.192 
sec - in org.apache.flink.yarn.YARNSessionFIFOITCase

Results :

Tests run: 14, Failures: 0, Errors: 0, Skipped: 2

[INFO] 
[INFO] --- maven-failsafe-plugin:2.17:verify (default) @ flink-yarn-tests 
---
[INFO] Failsafe report directory: 
/Users/chenliang/flink/flink-yarn-tests/target/failsafe-reports
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 04:08 min
[INFO] Finished at: 2015-09-04T21:52:47+08:00
[INFO] Final Memory: 36M/758M
[INFO] 



> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731687#comment-14731687
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

GitHub user chenliang613 opened a pull request:

https://github.com/apache/flink/pull/1094

[FLINK-2493] Simplify names of example program JARs

The names of the example JARs under build-target/examples have some 
confusion, the version number might stop users from submitting examples to 
incompatible versions of Flink
Propose to name the file examples/ConnectedComponents.jar rather than 
examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar.
The result as below:
build-target
  examples
ConnectedComponents.jar
EnumTrianglesBasic.jar
EnumTrianglesOpt.jar
..


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenliang613/flink FLINK-2493

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1094


commit edd1a1da2b81413e04de007f1655159cb709960a
Author: chenliang613 
Date:   2015-09-05T01:16:53Z

FLINK-2493 Simplify names of example program JARs




> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731740#comment-14731740
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user chenliang613 commented on the pull request:

https://github.com/apache/flink/pull/1094#issuecomment-137896176
  
The implementation method may not the best solution. Actually i tried a 
couple of solutions(for example:use finalName tag to replace classifier),but 
because there having many dependency with java examples internally, "rename 
depended Jars" would generate too much influence for other programs, so  
selecting such change has least influence on the system :)


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731674#comment-14731674
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user chenliang613 closed the pull request at:

https://github.com/apache/flink/pull/1087


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727885#comment-14727885
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

GitHub user chenliang613 opened a pull request:

https://github.com/apache/flink/pull/1087

[FLINK-2493] Simplify names of example program JARs

The names of the example JARs under build-target/examples have some 
confusion, the version number might stop users from submitting examples to 
incompatible versions of Flink
Propose to name the file examples/ConnectedComponents.jar rather than 
examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenliang613/flink FLINK-2493

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1087


commit 20bb7420b9fad61b11a8bc9bc6423ac458235ec0
Author: CHEN LIANG 
Date:   2015-09-02T19:24:56Z

FLINK-2493




> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727359#comment-14727359
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user chenliang613 closed the pull request at:

https://github.com/apache/flink/pull/1068


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727394#comment-14727394
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1068#issuecomment-137095444
  
@chenliang613 Do you want to open another poll request with the fix?


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727409#comment-14727409
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user chenliang613 commented on the pull request:

https://github.com/apache/flink/pull/1068#issuecomment-137098642
  
@StephanEwen  yes.  may use another solution :)


> Simplify names of example program JARs
> --
>
> Key: FLINK-2493
> URL: https://issues.apache.org/jira/browse/FLINK-2493
> Project: Flink
>  Issue Type: Improvement
>  Components: Examples
>Affects Versions: 0.10
>Reporter: Stephan Ewen
>Assignee: chenliang
>Priority: Minor
>  Labels: easyfix, starter
>
> I find the names of the example JARs a bit annoying.
> Why not name the file {{examples/ConnectedComponents.jar}} rather than 
> {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716624#comment-14716624
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

Github user mbalassi commented on the pull request:

https://github.com/apache/flink/pull/1068#issuecomment-135420490
  
Thanks for picking up the issue. Could you make the changes for the 
`flink-streaming-examples` and the `flink-storm-compatibility-example` modules 
too, please? Also travis suggests you have unintentionally broken some 
references.


 Simplify names of example program JARs
 --

 Key: FLINK-2493
 URL: https://issues.apache.org/jira/browse/FLINK-2493
 Project: Flink
  Issue Type: Improvement
  Components: Examples
Affects Versions: 0.10
Reporter: Stephan Ewen
Assignee: chenliang
Priority: Minor
  Labels: easyfix, starter

 I find the names of the example JARs a bit annoying.
 Why not name the file {{examples/ConnectedComponents.jar}} rather than 
 {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716420#comment-14716420
 ] 

ASF GitHub Bot commented on FLINK-2493:
---

GitHub user chenliang613 opened a pull request:

https://github.com/apache/flink/pull/1068

[FLINK-2493] Simplify names of example program JARs

The names of example JARs have a bit annoying, propose to replace
examples/flinnk-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar
with examples/ConnectedComponents.jar
1. Changing java and scala examples'  pom.xml, set finalName to replace
default name artifactId+version+classifer.
2.update quickstart doc which referring to examples

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenliang613/flink FLINK-2493

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1068.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1068


commit 741c846584936a8caca25269cf22cee4f0e3fa6e
Author: unknown c00246...@szxy1c002460671.china.huawei.com
Date:   2015-08-27T10:02:51Z

[FLINK-2493] Simplify names of example program JARs

commit 658ffad9e20a511c9c377fbf438c54521291ea50
Author: unknown c00246...@szxy1c002460671.china.huawei.com
Date:   2015-08-27T10:12:15Z

[FLINK-2493] Simplify names of example program JARs




 Simplify names of example program JARs
 --

 Key: FLINK-2493
 URL: https://issues.apache.org/jira/browse/FLINK-2493
 Project: Flink
  Issue Type: Improvement
  Components: Examples
Affects Versions: 0.10
Reporter: Stephan Ewen
Assignee: chenliang
Priority: Minor
  Labels: easyfix, starter

 I find the names of the example JARs a bit annoying.
 Why not name the file {{examples/ConnectedComponents.jar}} rather than 
 {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-13 Thread Stephan Ewen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694854#comment-14694854
 ] 

Stephan Ewen commented on FLINK-2493:
-

Still, seeking consensus on the dev list is a good idea, let's do that!

 Simplify names of example program JARs
 --

 Key: FLINK-2493
 URL: https://issues.apache.org/jira/browse/FLINK-2493
 Project: Flink
  Issue Type: Improvement
  Components: Examples
Affects Versions: 0.10
Reporter: Stephan Ewen
Assignee: chenliang
Priority: Minor
  Labels: easyfix, starter

 I find the names of the example JARs a bit annoying.
 Why not name the file {{examples/ConnectedComponents.jar}} rather than 
 {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}
 And combine flink-java-examples and flink-scala-examples  project to one 
 examples project。



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-13 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694852#comment-14694852
 ] 

Márton Balassi commented on FLINK-2493:
---

Ok, fair enough then.

 Simplify names of example program JARs
 --

 Key: FLINK-2493
 URL: https://issues.apache.org/jira/browse/FLINK-2493
 Project: Flink
  Issue Type: Improvement
  Components: Examples
Affects Versions: 0.10
Reporter: Stephan Ewen
Assignee: chenliang
Priority: Minor
  Labels: easyfix, starter

 I find the names of the example JARs a bit annoying.
 Why not name the file {{examples/ConnectedComponents.jar}} rather than 
 {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}
 And combine flink-java-examples and flink-scala-examples  project to one 
 examples project。



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-13 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694842#comment-14694842
 ] 

Márton Balassi commented on FLINK-2493:
---

Hey [~chenliang], please do not combine the scala and java examples into one 
big project. Personally I am opposed to that change, we have seen trouble with 
maven modules having both java and scala dependencies. If you are still in 
favor of that please propose the change on the dev mailinglist.

 Simplify names of example program JARs
 --

 Key: FLINK-2493
 URL: https://issues.apache.org/jira/browse/FLINK-2493
 Project: Flink
  Issue Type: Improvement
  Components: Examples
Affects Versions: 0.10
Reporter: Stephan Ewen
Assignee: chenliang
Priority: Minor
  Labels: easyfix, starter

 I find the names of the example JARs a bit annoying.
 Why not name the file {{examples/ConnectedComponents.jar}} rather than 
 {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}
 And combine flink-java-examples and flink-scala-examples  project to one 
 examples project。



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-13 Thread Stephan Ewen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694851#comment-14694851
 ] 

Stephan Ewen commented on FLINK-2493:
-

I think there was a discussion about combining the examples into one project a 
bit back, in the context of also re-organizing the Gelly examples.

I actually like this idea. Will help us reduce the Jungle of projects a bit.

The problems occur mostly when referencing Scala from Java code, and the two 
sets of code are completely separate here. There should be no harm in combining 
the example projects.

 Simplify names of example program JARs
 --

 Key: FLINK-2493
 URL: https://issues.apache.org/jira/browse/FLINK-2493
 Project: Flink
  Issue Type: Improvement
  Components: Examples
Affects Versions: 0.10
Reporter: Stephan Ewen
Assignee: chenliang
Priority: Minor
  Labels: easyfix, starter

 I find the names of the example JARs a bit annoying.
 Why not name the file {{examples/ConnectedComponents.jar}} rather than 
 {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}
 And combine flink-java-examples and flink-scala-examples  project to one 
 examples project。



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-08-07 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662462#comment-14662462
 ] 

Márton Balassi commented on FLINK-2493:
---

+1

It can be done by replacing the `classifier` tag of the jar plugin making the 
self-contained jars by the `finalName` tag. One should be careful doing this 
change to include all the example poms and also update the quickstart docs. [1]

[1] 
https://ci.apache.org/projects/flink/flink-docs-release-0.9/quickstart/setup_quickstart.html

 Simplify names of example program JARs
 --

 Key: FLINK-2493
 URL: https://issues.apache.org/jira/browse/FLINK-2493
 Project: Flink
  Issue Type: Improvement
  Components: Examples
Affects Versions: 0.10
Reporter: Stephan Ewen
Priority: Minor
  Labels: easyfix, starter

 I find the names of the example JARs a bit annoying.
 Why not name the file {{examples/ConnectedComponents.jar}} rather than 
 {{examples/flink-java-examples-0.10-SNAPSHOT-ConnectedComponents.jar}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)