[jira] [Commented] (FLINK-26493) Use state machine based mechanism to simply the reconciler
[
https://issues.apache.org/jira/browse/FLINK-26493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556719#comment-17556719
]
Gyula Fora commented on FLINK-26493:
[~aitozi] I have started working on refactoring the reconcilers to unify the
Application and SessionJob reconcilers. This would make the logic consistent
and would unify the features (rollback etc.)
> Use state machine based mechanism to simply the reconciler
> --
>
> Key: FLINK-26493
> URL: https://issues.apache.org/jira/browse/FLINK-26493
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> As discussed in
> [link|https://lists.apache.org/list?d...@flink.apache.org:lte=1M:controller%20flow]
> , we reach a consensus to use the state machine mechanism to simplify the
> annoying if-else in the reconciler. Since the modular {{Observer}}
> {{Reconciler}} and {{validator}} have completed. I think we can start this
> work now.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-26493) Use state machine based mechanism to simply the reconciler
[
https://issues.apache.org/jira/browse/FLINK-26493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551968#comment-17551968
]
Gyula Fora commented on FLINK-26493:
Sounds good, I was also planning to spend some time brainstorming on this let's
sync before we start any big work on this :)
> Use state machine based mechanism to simply the reconciler
> --
>
> Key: FLINK-26493
> URL: https://issues.apache.org/jira/browse/FLINK-26493
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> As discussed in
> [link|https://lists.apache.org/list?d...@flink.apache.org:lte=1M:controller%20flow]
> , we reach a consensus to use the state machine mechanism to simplify the
> annoying if-else in the reconciler. Since the modular {{Observer}}
> {{Reconciler}} and {{validator}} have completed. I think we can start this
> work now.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-26493) Use state machine based mechanism to simply the reconciler
[
https://issues.apache.org/jira/browse/FLINK-26493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551864#comment-17551864
]
Aitozi commented on FLINK-26493:
[~gyfora] I have not invest time to start this work, but I still think it's
worth to try. My intention is try to make the control flow more flexible (avoid
much state condition check in current version) I will ping you for feedback
when I have some thoughts
> Use state machine based mechanism to simply the reconciler
> --
>
> Key: FLINK-26493
> URL: https://issues.apache.org/jira/browse/FLINK-26493
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> As discussed in
> [link|https://lists.apache.org/list?d...@flink.apache.org:lte=1M:controller%20flow]
> , we reach a consensus to use the state machine mechanism to simplify the
> annoying if-else in the reconciler. Since the modular {{Observer}}
> {{Reconciler}} and {{validator}} have completed. I think we can start this
> work now.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-26493) Use state machine based mechanism to simply the reconciler
[
https://issues.apache.org/jira/browse/FLINK-26493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551671#comment-17551671
]
Gyula Fora commented on FLINK-26493:
I am bit hesitant about this ticket at this stage. It would be good to capture
the shared parts of the main reconciler logic between Session/Application &&
Application/SessionJob but not sure what design will be the most suitable
overall.
> Use state machine based mechanism to simply the reconciler
> --
>
> Key: FLINK-26493
> URL: https://issues.apache.org/jira/browse/FLINK-26493
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
>
> As discussed in
> [link|https://lists.apache.org/list?d...@flink.apache.org:lte=1M:controller%20flow]
> , we reach a consensus to use the state machine mechanism to simplify the
> annoying if-else in the reconciler. Since the modular {{Observer}}
> {{Reconciler}} and {{validator}} have completed. I think we can start this
> work now.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-26493) Use state machine based mechanism to simply the reconciler
[
https://issues.apache.org/jira/browse/FLINK-26493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501409#comment-17501409
]
Aitozi commented on FLINK-26493:
Agree, I will try to capture the current state transitions first.
> Use state machine based mechanism to simply the reconciler
> --
>
> Key: FLINK-26493
> URL: https://issues.apache.org/jira/browse/FLINK-26493
> Project: Flink
> Issue Type: Sub-task
>Reporter: Aitozi
>Priority: Major
>
> As discussed in
> [link|https://lists.apache.org/list?d...@flink.apache.org:lte=1M:controller%20flow]
> , we reach a consensus to use the state machine mechanism to simplify the
> annoying if-else in the reconciler. Since the modular {{Observer}}
> {{Reconciler}} and {{validator}} have completed. I think we can start this
> work now.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26493) Use state machine based mechanism to simply the reconciler
[
https://issues.apache.org/jira/browse/FLINK-26493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501391#comment-17501391
]
Gyula Fora commented on FLINK-26493:
It would be good to first try to capture the current state transitions how the
operator works because it is not going to be the same as in the lyft operator.
Because most of our operations are synchronous, there are less states here I
think right now.
> Use state machine based mechanism to simply the reconciler
> --
>
> Key: FLINK-26493
> URL: https://issues.apache.org/jira/browse/FLINK-26493
> Project: Flink
> Issue Type: Sub-task
>Reporter: Aitozi
>Priority: Major
>
> As discussed in
> [link|https://lists.apache.org/list?d...@flink.apache.org:lte=1M:controller%20flow]
> , we reach a consensus to use the state machine mechanism to simplify the
> annoying if-else in the reconciler. Since the modular {{Observer}}
> {{Reconciler}} and {{validator}} have completed. I think we can start this
> work now.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26493) Use state machine based mechanism to simply the reconciler
[
https://issues.apache.org/jira/browse/FLINK-26493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501381#comment-17501381
]
Aitozi commented on FLINK-26493:
I will try to define a initial state machine transfer flow we are target as
described in the dev mail
[https://github.com/lyft/flinkk8soperator/blob/master/docs/state_machine.md]
> Use state machine based mechanism to simply the reconciler
> --
>
> Key: FLINK-26493
> URL: https://issues.apache.org/jira/browse/FLINK-26493
> Project: Flink
> Issue Type: Sub-task
>Reporter: Aitozi
>Priority: Major
>
> As discussed in
> [link|https://lists.apache.org/list?d...@flink.apache.org:lte=1M:controller%20flow]
> , we reach a consensus to use the state machine mechanism to simplify the
> annoying if-else in the reconciler. Since the modular {{Observer}}
> {{Reconciler}} and {{validator}} have completed. I think we can start this
> work now.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26493) Use state machine based mechanism to simply the reconciler
[
https://issues.apache.org/jira/browse/FLINK-26493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501379#comment-17501379
]
Aitozi commented on FLINK-26493:
Do you have some inputs for this [~gyfora] [~wangyang0918] ?
> Use state machine based mechanism to simply the reconciler
> --
>
> Key: FLINK-26493
> URL: https://issues.apache.org/jira/browse/FLINK-26493
> Project: Flink
> Issue Type: Sub-task
>Reporter: Aitozi
>Priority: Major
>
> As discussed in
> [link|https://lists.apache.org/list?d...@flink.apache.org:lte=1M:controller%20flow]
> , we reach a consensus to use the state machine mechanism to simplify the
> annoying if-else in the reconciler. Since the modular {{Observer}}
> {{Reconciler}} and {{validator}} have completed. I think we can start this
> work now.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
