[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740424#comment-14740424
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139491178
  
Sorry Henry. I've updated the description.


> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740412#comment-14740412
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/1117#discussion_r39251890
  
--- Diff: 
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
 ---
@@ -356,29 +357,24 @@ public void run() {
// make sure that all partitions have some 
offsets to start with
// those partitions that do not have an offset 
from a checkpoint need to get
// their start offset from ZooKeeper
-   
-   List partitionsToGetOffsetsFor 
= new ArrayList<>();
+   {
--- End diff --

I'm opening a new scope for the `partitionsToGetOffsetsFor` variable.
I'm using another list with the same name later in the code. WIth a new 
scope for the operation here, I can use the same variable name later again.



> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740665#comment-14740665
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139529822
  
LGTM


> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740557#comment-14740557
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139514082
  
Good and critical fix. Should go to
  - `master`
  - `release-0.10.0-milestone1`
  - `0.9.2`


> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740666#comment-14740666
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139529893
  
Thank you for the review. I'll merge it


> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740673#comment-14740673
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1117


> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739106#comment-14739106
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

GitHub user rmetzger opened a pull request:

https://github.com/apache/flink/pull/1117

[FLINK-2656] Fix behavior of FlinkKafkaConsumer for out of range offsets



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rmetzger/flink flink2656

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1117


commit 582d265e7ac068ff74a107e2bdcfbce87828c810
Author: Robert Metzger 
Date:   2015-09-10T16:47:45Z

[FLINK-2656] Fix behavior of FlinkKafkaConsumer for out of range offsets




> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739259#comment-14739259
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/flink/pull/1117#discussion_r39193575
  
--- Diff: 
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
 ---
@@ -356,29 +357,24 @@ public void run() {
// make sure that all partitions have some 
offsets to start with
// those partitions that do not have an offset 
from a checkpoint need to get
// their start offset from ZooKeeper
-   
-   List partitionsToGetOffsetsFor 
= new ArrayList<>();
+   {
--- End diff --

Just curious what is the extra "{" for?


> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2656) FlinkKafkaConsumer is failing with OutOfRangeException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739261#comment-14739261
 ] 

ASF GitHub Bot commented on FLINK-2656:
---

Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/1117#issuecomment-139331689
  
Hi @rmetzger, could you tell bit summary what the fix should do in the 
description of this PR? Thanks.


> FlinkKafkaConsumer is failing with OutOfRangeException
> --
>
> Key: FLINK-2656
> URL: https://issues.apache.org/jira/browse/FLINK-2656
> Project: Flink
>  Issue Type: Bug
>  Components: Kafka Connector
>Affects Versions: 0.10, 0.9.1
>Reporter: Robert Metzger
>Priority: Critical
>
> FlinkKafkaConsumer is failing with an OutOfRangeException. There is actually 
> a configuration parameter for the high level kafka consumer how to handle 
> these situations (the high level c) doesn't fail on that exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)