[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517890#comment-17517890
]
Martijn Visser commented on FLINK-27010:
[~ana4] I don't understand why you don't want to set them every time the SQL
Client starts. Can you please explain what is the problem that you're trying to
solve? That might help in better understanding how to solve it in a proper way,
without mixing cluster-level configuration and SQL client behavior.
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the flink-conf.yaml will be overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517773#comment-17517773
]
LuNng Wang commented on FLINK-27010:
[~martijnvisser] [~fsk119] When we use SQL Client, '-i', '-l' and '-pyexec'
are stable option. We don't want to set them every time SQL Client starts. The
'-pyexec' can be set in YAML via 'python.executable', but '-i' and '-l' can not.
Can we add `sql-client.execution.init-file`, etc. in SQL Client configuration?
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the flink-conf.yaml will be overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517768#comment-17517768
]
Shengkai Fang commented on FLINK-27010:
---
[~martijnvisser] +1. The flink-conf.yaml is cluster-level configuration and SQL
Client shouldn't influence these.
Do you want to execute file after the sql-client starts, e.g. SOURCE xxx.sql ?
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the Flink default conf in yaml will be
> overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517603#comment-17517603
]
Martijn Visser commented on FLINK-27010:
[~ana4] The link you've provided
https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/table/sqlclient/#sql-client-configuration
is not configuration that ends up in the flink-conf.yaml by default. Those are
documented at
https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/
What you're linking to are specific configuration options for Table/SQL
applications.
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the Flink default conf in yaml will be
> overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517504#comment-17517504
]
LuNng Wang commented on FLINK-27010:
[~martijnvisser] the SQL client already relying on flink-conf.yaml
configuration.
https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/table/sqlclient/#sql-client-configuration
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the Flink default conf in yaml will be
> overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516780#comment-17516780
]
Moses commented on FLINK-27010:
---
[~martijnvisser] +1
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the Flink default conf in yaml will be
> overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516706#comment-17516706
]
Martijn Visser commented on FLINK-27010:
I don't think this is a good idea. I think the SQL client should be just a
client, without relying on flink-conf.yaml configuration.
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the Flink default conf in yaml will be
> overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516260#comment-17516260
]
LuNng Wang commented on FLINK-27010:
[~ZhangChaoming] There is two scenarios:
1) Users '-i' or '-l' options are stable, they don't want to set them every
time.
2) Some users enclosure SQL Client to a SQL Gatawey server. If the Flink has
these options, the SQL Gatawey server doesn't need to define new options. They
just use the Flink native options.
You can check out the apache Kyuubi issue
https://github.com/apache/incubator-kyuubi/issues/2153
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the Flink default conf in yaml will be
> overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516255#comment-17516255
]
Moses commented on FLINK-27010:
---
[~ana4] I think there is no need to mix them together, it's advisable for use
to use `-i` to specify a initializing file.
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: LuNng Wang
>Priority: Major
>
> '-i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
> When startup options are set, the Flink default conf in yaml will be
> overridden.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-27010) Support setting sql client args via flink conf
[
https://issues.apache.org/jira/browse/FLINK-27010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516252#comment-17516252
]
Luning Wang commented on FLINK-27010:
-
I would like to take this, please assign it to me.
> Support setting sql client args via flink conf
> --
>
> Key: FLINK-27010
> URL: https://issues.apache.org/jira/browse/FLINK-27010
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
>Affects Versions: 1.14.4
>Reporter: Luning Wang
>Priority: Major
>
> -i' '-j' and '-l' only be set in startup options.
> I want to add the following options in flink-conf.yaml to set SQL Client
> options.
> {code:java}
> sql-client.execution.init-file: /foo/foo.sql
> sql-client.execution.jar: foo.jar
> sql-client.execution.library: /foo{code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
