[jira] [Commented] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530384#comment-17530384 ] Aitozi commented on FLINK-27337: OK, I will implement the deletions logic first, and will think about the update part again. If necessary, I will open a discussion on mailing list. > Prevent session cluster to be deleted when there are running jobs > - > > Key: FLINK-27337 > URL: https://issues.apache.org/jira/browse/FLINK-27337 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator >Reporter: Yang Wang >Priority: Major > Fix For: kubernetes-operator-1.0.0 > > > We should prevent the session cluster to be deleted when there are running > jobs. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530056#comment-17530056 ] Gyula Fora commented on FLINK-27337: I agree for deletions, the upgrade situation is a bit trickier. I would not want to block cluster upgrades, but thats a different question :) > Prevent session cluster to be deleted when there are running jobs > - > > Key: FLINK-27337 > URL: https://issues.apache.org/jira/browse/FLINK-27337 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator >Reporter: Yang Wang >Priority: Major > Fix For: kubernetes-operator-1.0.0 > > > We should prevent the session cluster to be deleted when there are running > jobs. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529879#comment-17529879 ] Aitozi commented on FLINK-27337: I want to solve this in the following way # In webhook we can prevent the deletion/upgrade if there is session jobs in the session cluster. # In SessionReconciler cleanup and reconcile we should also check whether there is session job and decide to upgrade/delete session cluster or postpone to do that until there is no session jobs. (Because user may not enable the webhook) # Make the check configurable, users can choose to manually suspend the job before upgrade/delete the session cluster or directly done by the operator (propagating the delete or upgrade) what do you think [~wangyang0918] [~gyfora] > Prevent session cluster to be deleted when there are running jobs > - > > Key: FLINK-27337 > URL: https://issues.apache.org/jira/browse/FLINK-27337 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator >Reporter: Yang Wang >Priority: Major > Fix For: kubernetes-operator-1.0.0 > > > We should prevent the session cluster to be deleted when there are running > jobs. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs
[
https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526161#comment-17526161
]
Yang Wang commented on FLINK-27337:
---
I lean to not propagate the deletion to all the session jobs. It may cause some
serious problems in production environment. What in my mind is let the webhook
to prevent the deletion and print the warning message to users. Or at least we
could do this in the {{{}SessionReconciler#shutdow{}}}.
I am not pretty sure whether we should also prevent the upgrade when there are
running jobs.
> Prevent session cluster to be deleted when there are running jobs
> -
>
> Key: FLINK-27337
> URL: https://issues.apache.org/jira/browse/FLINK-27337
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Yang Wang
>Priority: Major
> Fix For: kubernetes-operator-1.0.0
>
>
> We should prevent the session cluster to be deleted when there are running
> jobs.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525579#comment-17525579 ] Aitozi commented on FLINK-27337: As discussed in the [mailing list|https://lists.apache.org/thread/9xvdwtf5tbr28lonj21p58tn5gdndns5], the deletion of all the session job may be a critical operation. So if there is an upgrade or cleanup event for the session cluster, we can postpone the real cleanup/stop until all the session job suspended by user. We can avoid to remove the finializer and re-schedule to check whether all the job are stopped. This way is more safe but may involve more step when user want to delete or upgrade the session cluster, what about make it both supported. > Prevent session cluster to be deleted when there are running jobs > - > > Key: FLINK-27337 > URL: https://issues.apache.org/jira/browse/FLINK-27337 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator >Reporter: Yang Wang >Priority: Major > Fix For: kubernetes-operator-1.0.0 > > > We should prevent the session cluster to be deleted when there are running > jobs. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525495#comment-17525495 ] Gyula Fora commented on FLINK-27337: An alternative would be to first propagating delete to the session jobs. > Prevent session cluster to be deleted when there are running jobs > - > > Key: FLINK-27337 > URL: https://issues.apache.org/jira/browse/FLINK-27337 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator >Reporter: Yang Wang >Priority: Major > Fix For: kubernetes-operator-1.0.0 > > > We should prevent the session cluster to be deleted when there are running > jobs. -- This message was sent by Atlassian Jira (v8.20.7#820007)
