[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946659#comment-14946659
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-146151202
  
Thanks for the update @chiwanpark!
LGTM, will merge it.


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946904#comment-14946904
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1197


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943701#comment-14943701
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user chiwanpark commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-145606437
  
It occured by jline library version mismatching between Scala 2.10 and 
2.11. Since Scala 2.11.5, we don't need jline dependency. Scala REPL uses its 
own jline library. So I upgraded Scala minor version to 2.11.7 and moved jline 
to Scala 2.10 only dependencies list.


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944329#comment-14944329
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-145708723
  
Thank you for the review @nikste!


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943297#comment-14943297
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user nikste commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-145510215
  
For me it says:
~~~bash
Failed to created JLineReader: java.lang.NoClassDefFoundError: 
jline/console/completer/Completer
Falling back to SimpleReader.
~~~


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943291#comment-14943291
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user nikste commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-145509252
  
Code looks fine. However, I noticed if I compile the code (for scala 
version 2.11), and start up the scala shell manually (./start-scala-shell.sh), 
the autocomplete function (tab) and history (arrow up) are not working anymore.


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939526#comment-14939526
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-144660508
  
@nikste, can you quickly review this PR?


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936578#comment-14936578
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-144330468
  
Cool, looks like a very nice solution.

The package directors structure seems a bit strange for teh file 
`flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkILoop.scala`.
 Is that on purpose?


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936576#comment-14936576
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

GitHub user chiwanpark opened a pull request:

https://github.com/apache/flink/pull/1197

[FLINK-2767] [scala shell] Add Scala 2.11 support to Scala shell

This PR contains following changes:

* Add `ILoopCompat` class for supporting both Scala 2.10 and Scala 2.11 
(Inspired by [Scalding 
REPL](https://github.com/twitter/scalding/blob/develop/scalding-repl/src/main/scala-2.11/com/twitter/scalding/ILoopCompat.scala))
* Some modification of POM to include `flink-scala-shell` with Scala 2.11

I have tested local execution and remote execution with standalone Flink 
cluster.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chiwanpark/flink FLINK-2767

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1197


commit a0ad8fbc90262d6ceb8699b02e5a9661f836d405
Author: Chiwan Park 
Date:   2015-09-25T17:47:06Z

[FLINK-2767] [scala shell] Add Scala 2.11 support to Scala shell




> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936611#comment-14936611
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user chiwanpark commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-144335229
  
AFAIK, the directory structure is planned to correct in #1106. But I didn't 
know #1106 is closed. I'll update the directory structure.


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2767) Add support Scala 2.11 to Scala shell

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936620#comment-14936620
 ] 

ASF GitHub Bot commented on FLINK-2767:
---

Github user chiwanpark commented on the pull request:

https://github.com/apache/flink/pull/1197#issuecomment-144336975
  
The directory name is changed.


> Add support Scala 2.11 to Scala shell
> -
>
> Key: FLINK-2767
> URL: https://issues.apache.org/jira/browse/FLINK-2767
> Project: Flink
>  Issue Type: Improvement
>  Components: Scala Shell
>Affects Versions: 0.10
>Reporter: Chiwan Park
>Assignee: Chiwan Park
>
> Since FLINK-2200 is resolved, the Flink community provides JARs for Scala 
> 2.11. But currently, there is no Scala shell with Scala 2.11. If we add 
> support Scala 2.11 to Scala shell, the user with Scala 2.11 could use Flink 
> easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)