[jira] [Commented] (FLINK-29283) Remove hardcoded apiVersion from operator unit test

2022-09-14 Thread Jira 


[ 
https://issues.apache.org/jira/browse/FLINK-29283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604772#comment-17604772
 ] 

Márton Balassi commented on FLINK-29283:


Thanks, in the meantime there is a PR open from another contributor:

[https://github.com/apache/flink-kubernetes-operator/pull/367]

Based on [~matyas] 's comment on the PR the setup might be intentional there.

> Remove hardcoded apiVersion from operator unit test
> ---
>
> Key: FLINK-29283
> URL: https://issues.apache.org/jira/browse/FLINK-29283
> Project: Flink
>  Issue Type: Improvement
>  Components: Kubernetes Operator
>Affects Versions: kubernetes-operator-1.1.0
>Reporter: Tony Garrard
>Priority: Minor
>  Labels: pull-request-available
> Fix For: kubernetes-operator-1.2.0
>
>
> The unit test 
> flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/utils/ReconciliationUtilsTest.java
>  has a hardcoded apiVersion. To facilitate modifications, it should be using 
> the constants provided in the class CrdConstants i.e. 
> assertEquals(API_GROUP + "/" + API_VERSION, 
> internalMeta.get("apiVersion").asText());
> instead of "flink.apache.org/v1beta1"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29283) Remove hardcoded apiVersion from operator unit test

2022-09-14 Thread Tony Garrard (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17604758#comment-17604758
 ] 

Tony Garrard commented on FLINK-29283:
--

Absolutely, assign it to me

> Remove hardcoded apiVersion from operator unit test
> ---
>
> Key: FLINK-29283
> URL: https://issues.apache.org/jira/browse/FLINK-29283
> Project: Flink
>  Issue Type: Improvement
>  Components: Kubernetes Operator
>Affects Versions: kubernetes-operator-1.1.0
>Reporter: Tony Garrard
>Priority: Minor
>  Labels: pull-request-available
> Fix For: kubernetes-operator-1.2.0
>
>
> The unit test 
> flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/utils/ReconciliationUtilsTest.java
>  has a hardcoded apiVersion. To facilitate modifications, it should be using 
> the constants provided in the class CrdConstants i.e. 
> assertEquals(API_GROUP + "/" + API_VERSION, 
> internalMeta.get("apiVersion").asText());
> instead of "flink.apache.org/v1beta1"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29283) Remove hardcoded apiVersion from operator unit test

2022-09-13 Thread Jira 


[ 
https://issues.apache.org/jira/browse/FLINK-29283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603632#comment-17603632
 ] 

Márton Balassi commented on FLINK-29283:


Good catch, [~tagarr]. Would you be interested in creating a PR for this change?

> Remove hardcoded apiVersion from operator unit test
> ---
>
> Key: FLINK-29283
> URL: https://issues.apache.org/jira/browse/FLINK-29283
> Project: Flink
>  Issue Type: Improvement
>  Components: Kubernetes Operator
>Affects Versions: kubernetes-operator-1.1.0
>Reporter: Tony Garrard
>Priority: Minor
> Fix For: kubernetes-operator-1.2.0
>
>
> The unit test 
> flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/utils/ReconciliationUtilsTest.java
>  has a hardcoded apiVersion. To facilitate modifications, it should be using 
> the constants provided in the class CrdConstants i.e. 
> assertEquals(API_GROUP + "/" + API_VERSION, 
> internalMeta.get("apiVersion").asText());
> instead of "flink.apache.org/v1beta1"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)