[jira] [Commented] (FLINK-29432) Replace GenericUDFNvl with GenericUDFCoalesce
[
https://issues.apache.org/jira/browse/FLINK-29432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615480#comment-17615480
]
Samrat Deb commented on FLINK-29432:
Thanks [~luoyuxia] for your view on the issue !
I completely agree with the fact that there are known bugs with
`GenericUDFCoalesce` and still haven't reached to complete maturity. We wont go
ahead with the proposed changes and keep it on hold untill flink start
supporting hive-4.
> Replace GenericUDFNvl with GenericUDFCoalesce
> -
>
> Key: FLINK-29432
> URL: https://issues.apache.org/jira/browse/FLINK-29432
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Hive
>Affects Versions: 1.15.2
>Reporter: Prabhu Joseph
>Priority: Major
> Labels: pull-request-available
>
> Hive NVL() function has many issues like
> [HIVE-25193|https://issues.apache.org/jira/browse/HIVE-25193] and it is
> retired [HIVE-20961|https://issues.apache.org/jira/browse/HIVE-20961]. Our
> internal hive distribution has the fix for HIVE-20961. With this fix, Flink
> Build is failing with below as there is no more GenericUDFNvl in Hive. This
> needs to be replaced with GenericUDFCoalesce.
> {code}
> [INFO]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserDefaultGraphWalker.java:
> Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[75,45]
> cannot find symbol
> symbol: class GenericUDFNvl
> location: package org.apache.hadoop.hive.ql.udf.generic
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[1216,41]
> cannot find symbol
> symbol: class GenericUDFNvl
> location: class
> org.apache.flink.table.planner.delegation.hive.HiveParserTypeCheckProcFactory.DefaultExprProcessor
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserSemanticAnalyzer.java:[231,26]
> constructor GlobalLimitCtx in class
> org.apache.hadoop.hive.ql.parse.GlobalLimitCtx cannot be applied to given
> types;
> required: org.apache.hadoop.hive.conf.HiveConf
> found: no arguments
> reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-29432) Replace GenericUDFNvl with GenericUDFCoalesce
[
https://issues.apache.org/jira/browse/FLINK-29432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615410#comment-17615410
]
luoyuxia commented on FLINK-29432:
--
Thanks for contribution. But to put it briefly, I prefer not to change it
immediately.
Actally, HIVE-20961 is a patch of Hive 4.0. Hive 4.0 is not released and Flink
doesn't provide official support for hive 4. Of course it should be fixed if we
want to support hive4, but at least, seems we have no such plan in short term.
Also, we can't just only change replace `GenericUDFNvl` with
`GenericUDFCoalesce` to fix it for it may bring other bugs to Hive dialect as
reported in [Hive-24902| https://issues.apache.org/jira/browse/HIVE-24902].
Also, I'm doubt it may bring other bugs that have't been found.
For your problem, you can change in your flink distribution.
> Replace GenericUDFNvl with GenericUDFCoalesce
> -
>
> Key: FLINK-29432
> URL: https://issues.apache.org/jira/browse/FLINK-29432
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Hive
>Affects Versions: 1.15.2
>Reporter: Prabhu Joseph
>Priority: Major
> Labels: pull-request-available
>
> Hive NVL() function has many issues like
> [HIVE-25193|https://issues.apache.org/jira/browse/HIVE-25193] and it is
> retired [HIVE-20961|https://issues.apache.org/jira/browse/HIVE-20961]. Our
> internal hive distribution has the fix for HIVE-20961. With this fix, Flink
> Build is failing with below as there is no more GenericUDFNvl in Hive. This
> needs to be replaced with GenericUDFCoalesce.
> {code}
> [INFO]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserDefaultGraphWalker.java:
> Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[75,45]
> cannot find symbol
> symbol: class GenericUDFNvl
> location: package org.apache.hadoop.hive.ql.udf.generic
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[1216,41]
> cannot find symbol
> symbol: class GenericUDFNvl
> location: class
> org.apache.flink.table.planner.delegation.hive.HiveParserTypeCheckProcFactory.DefaultExprProcessor
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserSemanticAnalyzer.java:[231,26]
> constructor GlobalLimitCtx in class
> org.apache.hadoop.hive.ql.parse.GlobalLimitCtx cannot be applied to given
> types;
> required: org.apache.hadoop.hive.conf.HiveConf
> found: no arguments
> reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-29432) Replace GenericUDFNvl with GenericUDFCoalesce
[
https://issues.apache.org/jira/browse/FLINK-29432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610560#comment-17610560
]
xiaochen zhou commented on FLINK-29432:
---
hi，I would like to deal with it. Can you assign this ticket to me ?:)
> Replace GenericUDFNvl with GenericUDFCoalesce
> -
>
> Key: FLINK-29432
> URL: https://issues.apache.org/jira/browse/FLINK-29432
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Hive
>Affects Versions: 1.15.2
>Reporter: Prabhu Joseph
>Priority: Major
> Labels: pull-request-available
>
> Hive NVL() function has many issues like
> [HIVE-25193|https://issues.apache.org/jira/browse/HIVE-25193] and it is
> retired [HIVE-20961|https://issues.apache.org/jira/browse/HIVE-20961]. Our
> internal hive distribution has the fix for HIVE-20961. With this fix, Flink
> Build is failing with below as there is no more GenericUDFNvl in Hive. This
> needs to be replaced with GenericUDFCoalesce.
> {code}
> [INFO]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserDefaultGraphWalker.java:
> Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[75,45]
> cannot find symbol
> symbol: class GenericUDFNvl
> location: package org.apache.hadoop.hive.ql.udf.generic
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:[1216,41]
> cannot find symbol
> symbol: class GenericUDFNvl
> location: class
> org.apache.flink.table.planner.delegation.hive.HiveParserTypeCheckProcFactory.DefaultExprProcessor
> [ERROR]
> /codebuild/output/src366217558/src/build/flink/rpm/BUILD/flink-1.15.2/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserSemanticAnalyzer.java:[231,26]
> constructor GlobalLimitCtx in class
> org.apache.hadoop.hive.ql.parse.GlobalLimitCtx cannot be applied to given
> types;
> required: org.apache.hadoop.hive.conf.HiveConf
> found: no arguments
> reason: actual and formal argument lists differ in length
> [INFO] 3 errors
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
