[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-11-20 Thread Yun Gao (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636277#comment-17636277
 ] 

Yun Gao commented on FLINK-29557:
-

Merged on master via a56af3b5702f805b477f8cf11a27167e626ad9fe.

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Assignee: Aitozi
>Priority: Major
>  Labels: pull-request-available
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-27 Thread Aitozi (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624987#comment-17624987
 ] 

Aitozi commented on FLINK-29557:


Yes, I will open a PR to fix this. Please help assign the ticket

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-26 Thread Yun Gao (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624867#comment-17624867
 ] 

Yun Gao commented on FLINK-29557:
-

Hi [~aitozi] LGTM, very thanks for tracking the issue. Would you like to open a 
PR to fix the issue? Both side is ok to me. 

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-25 Thread Aitozi (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623665#comment-17623665
 ] 

Aitozi commented on FLINK-29557:


I make a solution to add a common interface {{SinkFunctionOperator}} in the 
{{flink-streaming-java}} module and let the {{SinkOperator}} and {{StreamSink}} 
extends from it. So that we can check for the 
{{SinkFunctionOperator#sinkFunction}} in the {{SimpleOperatorFactory}} 
directly. what do you think ?

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-25 Thread Yun Gao (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623601#comment-17623601
 ] 

Yun Gao commented on FLINK-29557:
-

Thanks [~aitozi] for reporting the issue! Now I have understood why there is 
issue here, I'll have a double confirmation of the proper way to fix it here, 
and do you already have some thoughts on it?

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-20 Thread Aitozi (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621475#comment-17621475
 ] 

Aitozi commented on FLINK-29557:


ping [~gaoyunhaii] 

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-15 Thread Aitozi (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618052#comment-17618052
 ] 

Aitozi commented on FLINK-29557:


Thanks [~gaoyunhaii] for your reply. The {{OutputFormatProvider}} in the table 
module will generate the {{SinkOperator}}. And the {{SinkOperator}} with 
{{OutputFormatSinkFunction}} will not be treated as an operator with 
{{OutputFormat}} in the {{SimpleOperatorFactory}}. In the end, it will miss the 
chance to execute the hook method eg: {{InitializeOnMaster}}

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-14 Thread Yun Gao (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617598#comment-17617598
 ] 

Yun Gao commented on FLINK-29557:
-

Hi [~aitozi] may I have a double confirmation on the scenario of this issue? 
Namely why we could not directly use OutputFormatSinkFunction so that it could 
be registered as SimpleOutputFormatOperatorFactory? 

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-11 Thread Aitozi (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616135#comment-17616135
 ] 

Aitozi commented on FLINK-29557:


Anyone can help confirm this issue ? 

> The SinkOperator's OutputFormat function is not recognized
> --
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
>  Issue Type: Bug
>  Components: API / Core, Table SQL / API
>Reporter: Aitozi
>Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to 
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output 
> format information in  {{SinkOperator}}. Then some hook functions like 
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached 
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra 
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator 
> and handle it individually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)