[jira] [Commented] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-11-04 Thread Jiale Tan (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628690#comment-17628690
 ] 

Jiale Tan commented on FLINK-29610:
---

[~gaoyunhaii] thanks for the info!

I created a PR [https://github.com/apache/flink/pull/21239] as per my 
understanding, it would be nice if you may take a look. [~gaoyunhaii] [~chesnay]

 

Meanwhile I am tracking how this Timeout will be used all the way till 
[here|https://github.com/apache/flink/blob/e9f3ec93aad7cec795c765c937ee71807f5478cf/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java#L856-L879].
 And it seems all those timeout are not being used? 

 

FYI [~thomasWeise] this is part of unfinished work from FLINK-27101

> Infinite timeout is used in SavepointHandlers calls to RestfulGateway
> -
>
> Key: FLINK-29610
> URL: https://issues.apache.org/jira/browse/FLINK-29610
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Reporter: Jiale Tan
>Assignee: Jiale Tan
>Priority: Major
>  Labels: pull-request-available
>
> In {{{}SavepointHandlers{}}}, both 
> {{[StopWithSavepointHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L214]}}
>  and 
> {{[SavepointTriggerHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L258]}}
>  are calling {{RestfulGateway}} with {{RpcUtils.INF_TIMEOUT}}
>  
> As pointed out in 
> [this|https://github.com/apache/flink/pull/20852#discussion_r992218970] 
> discussion, we will need to either figure out why {{RpcUtils.INF_TIMEOUT}} is 
> used, or remove it if there is no strong reason to use it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-31 Thread Yun Gao (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626504#comment-17626504
 ] 

Yun Gao commented on FLINK-29610:
-

Hi [~Jiale] , It looks to me RestConfiguration.timeout is used for the REST 
Handlers requests, while the above method  use INF_TIMEOUT while requesting to 
the dispatcher, which is in fact an akka actor. 

> Infinite timeout is used in SavepointHandlers calls to RestfulGateway
> -
>
> Key: FLINK-29610
> URL: https://issues.apache.org/jira/browse/FLINK-29610
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Reporter: Jiale Tan
>Assignee: Jiale Tan
>Priority: Major
>  Labels: pull-request-available
>
> In {{{}SavepointHandlers{}}}, both 
> {{[StopWithSavepointHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L214]}}
>  and 
> {{[SavepointTriggerHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L258]}}
>  are calling {{RestfulGateway}} with {{RpcUtils.INF_TIMEOUT}}
>  
> As pointed out in 
> [this|https://github.com/apache/flink/pull/20852#discussion_r992218970] 
> discussion, we will need to either figure out why {{RpcUtils.INF_TIMEOUT}} is 
> used, or remove it if there is no strong reason to use it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-28 Thread Jiale Tan (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625989#comment-17625989
 ] 

Jiale Tan commented on FLINK-29610:
---

[~gaoyunhaii] I am curious what is the difference between ASK_TIMEOUT_DURATION 
and 
[RestConfiguration.timeout|https://github.com/apache/flink/blob/5d66e82915eace9342c175163b17f610bfbf7fa4/flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java#L282]
 and why it is preferred to use ASK_TIMEOUT_DURATION in this case?

> Infinite timeout is used in SavepointHandlers calls to RestfulGateway
> -
>
> Key: FLINK-29610
> URL: https://issues.apache.org/jira/browse/FLINK-29610
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Reporter: Jiale Tan
>Assignee: Jiale Tan
>Priority: Major
>  Labels: pull-request-available
>
> In {{{}SavepointHandlers{}}}, both 
> {{[StopWithSavepointHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L214]}}
>  and 
> {{[SavepointTriggerHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L258]}}
>  are calling {{RestfulGateway}} with {{RpcUtils.INF_TIMEOUT}}
>  
> As pointed out in 
> [this|https://github.com/apache/flink/pull/20852#discussion_r992218970] 
> discussion, we will need to either figure out why {{RpcUtils.INF_TIMEOUT}} is 
> used, or remove it if there is no strong reason to use it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-27 Thread Yun Gao (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624896#comment-17624896
 ] 

Yun Gao commented on FLINK-29610:
-

Thanks [~Jiale] for tracking the issue! I assigned the issue to you. 

> Infinite timeout is used in SavepointHandlers calls to RestfulGateway
> -
>
> Key: FLINK-29610
> URL: https://issues.apache.org/jira/browse/FLINK-29610
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Reporter: Jiale Tan
>Priority: Major
>
> In {{{}SavepointHandlers{}}}, both 
> {{[StopWithSavepointHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L214]}}
>  and 
> {{[SavepointTriggerHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L258]}}
>  are calling {{RestfulGateway}} with {{RpcUtils.INF_TIMEOUT}}
>  
> As pointed out in 
> [this|https://github.com/apache/flink/pull/20852#discussion_r992218970] 
> discussion, we will need to either figure out why {{RpcUtils.INF_TIMEOUT}} is 
> used, or remove it if there is no strong reason to use it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-20 Thread Jiale Tan (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621406#comment-17621406
 ] 

Jiale Tan commented on FLINK-29610:
---

Thanks [~gaoyunhaii] for the extra context. Will look into this and potentially 
follow up here with a PR.

> Infinite timeout is used in SavepointHandlers calls to RestfulGateway
> -
>
> Key: FLINK-29610
> URL: https://issues.apache.org/jira/browse/FLINK-29610
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Reporter: Jiale Tan
>Priority: Major
>
> In {{{}SavepointHandlers{}}}, both 
> {{[StopWithSavepointHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L214]}}
>  and 
> {{[SavepointTriggerHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L258]}}
>  are calling {{RestfulGateway}} with {{RpcUtils.INF_TIMEOUT}}
>  
> As pointed out in 
> [this|https://github.com/apache/flink/pull/20852#discussion_r992218970] 
> discussion, we will need to either figure out why {{RpcUtils.INF_TIMEOUT}} is 
> used, or remove it if there is no strong reason to use it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29610) Infinite timeout is used in SavepointHandlers calls to RestfulGateway

2022-10-20 Thread Yun Gao (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620844#comment-17620844
 ] 

Yun Gao commented on FLINK-29610:
-

Thanks [~Jiale] for creating the issue. Since it seems the handler only submits 
a request to the timer thread of the CheckpointCoordinator, it looks to me that 
we might also use ASK_TIMEOUT_DURATION for these rpc calls. 

> Infinite timeout is used in SavepointHandlers calls to RestfulGateway
> -
>
> Key: FLINK-29610
> URL: https://issues.apache.org/jira/browse/FLINK-29610
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Reporter: Jiale Tan
>Priority: Major
>
> In {{{}SavepointHandlers{}}}, both 
> {{[StopWithSavepointHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L214]}}
>  and 
> {{[SavepointTriggerHandler|https://github.com/apache/flink/blob/cd8ea8d5b207569f68acc5a3c8db95cd2ca47ba6/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L258]}}
>  are calling {{RestfulGateway}} with {{RpcUtils.INF_TIMEOUT}}
>  
> As pointed out in 
> [this|https://github.com/apache/flink/pull/20852#discussion_r992218970] 
> discussion, we will need to either figure out why {{RpcUtils.INF_TIMEOUT}} is 
> used, or remove it if there is no strong reason to use it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)