[jira] [Commented] (FLINK-3049) Move "Either" type to package "org.apache.flink.types"

2016-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128066#comment-15128066
 ] 

ASF GitHub Bot commented on FLINK-3049:
---

Github user vasia closed the pull request at:

https://github.com/apache/flink/pull/1572


> Move "Either" type to package "org.apache.flink.types"
> --
>
> Key: FLINK-3049
> URL: https://issues.apache.org/jira/browse/FLINK-3049
> Project: Flink
>  Issue Type: Improvement
>  Components: Core, Java API
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Vasia Kalavri
> Fix For: 1.0.0
>
>
> Types reside in package "org.apache.flink.types", the type utils in 
> "typeutils".
> One can either move the type to "flink-core" or create that package in 
> flink-java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3049) Move "Either" type to package "org.apache.flink.types"

2016-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128065#comment-15128065
 ] 

ASF GitHub Bot commented on FLINK-3049:
---

Github user vasia commented on the pull request:

https://github.com/apache/flink/pull/1572#issuecomment-178509129
  
Then I'll close it :)


> Move "Either" type to package "org.apache.flink.types"
> --
>
> Key: FLINK-3049
> URL: https://issues.apache.org/jira/browse/FLINK-3049
> Project: Flink
>  Issue Type: Improvement
>  Components: Core, Java API
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Vasia Kalavri
> Fix For: 1.0.0
>
>
> Types reside in package "org.apache.flink.types", the type utils in 
> "typeutils".
> One can either move the type to "flink-core" or create that package in 
> flink-java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3049) Move "Either" type to package "org.apache.flink.types"

2016-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128040#comment-15128040
 ] 

ASF GitHub Bot commented on FLINK-3049:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1572#issuecomment-178503870
  
Ah, I actually included this already in #1570



> Move "Either" type to package "org.apache.flink.types"
> --
>
> Key: FLINK-3049
> URL: https://issues.apache.org/jira/browse/FLINK-3049
> Project: Flink
>  Issue Type: Improvement
>  Components: Core, Java API
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Vasia Kalavri
> Fix For: 1.0.0
>
>
> Types reside in package "org.apache.flink.types", the type utils in 
> "typeutils".
> One can either move the type to "flink-core" or create that package in 
> flink-java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3049) Move "Either" type to package "org.apache.flink.types"

2016-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127992#comment-15127992
 ] 

ASF GitHub Bot commented on FLINK-3049:
---

GitHub user vasia opened a pull request:

https://github.com/apache/flink/pull/1572

[FLINK-3049] move Either type to org.apache.flink.types

I went for option 2, i.e. creating the package in `flink-java`. Let me know 
if you think it makes more sense to move the type to `flink-core`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vasia/flink flink-3049

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1572


commit 681ca600c209d5f7bfc6f5f27d3f5a53b8159d40
Author: vasia 
Date:   2016-02-02T09:41:56Z

[FLINK-3049] move Either type to org.apache.flink.types




> Move "Either" type to package "org.apache.flink.types"
> --
>
> Key: FLINK-3049
> URL: https://issues.apache.org/jira/browse/FLINK-3049
> Project: Flink
>  Issue Type: Improvement
>  Components: Core, Java API
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Vasia Kalavri
> Fix For: 1.0.0
>
>
> Types reside in package "org.apache.flink.types", the type utils in 
> "typeutils".
> One can either move the type to "flink-core" or create that package in 
> flink-java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3049) Move "Either" type to package "org.apache.flink.types"

2015-11-19 Thread Vasia Kalavri (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013577#comment-15013577
 ] 

Vasia Kalavri commented on FLINK-3049:
--

I see. I was actually confused to see types both in {{flink-core}} and 
{{flink-java}}.
Also, {{flink-core}} has the types in {{common.types}}, type infos in 
{{common.typeinfo}} and serializers in {{common.typeutils}}, while 
{{flink-java}} has type infos in {{java.typeutils}} and serializers in 
{{java.typeutils.runtime}}.

So, are you suggesting moving the type, typeinfo and serializer to flink-core 
or just the type?

> Move "Either" type to package "org.apache.flink.types"
> --
>
> Key: FLINK-3049
> URL: https://issues.apache.org/jira/browse/FLINK-3049
> Project: Flink
>  Issue Type: Improvement
>  Components: Core, Java API
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Vasia Kalavri
> Fix For: 1.0.0
>
>
> Types reside in package "org.apache.flink.types", the type utils in 
> "typeutils".
> One can either move the type to "flink-core" or create that package in 
> flink-java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)