[jira] [Commented] (FLINK-30551) Add open method to PartitionCommitPolicy
[
https://issues.apache.org/jira/browse/FLINK-30551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691568#comment-17691568
]
Aitozi commented on FLINK-30551:
In my PR, only the table's with properties will be passed to the open method.
But I think it will be convenient to also pass the flink conf to the open
method, because some custom metaStore's config are in job level can be set to
the flink conf. What about keeping the both by adding the interface like
{code:java}
default void open(Configuration tableOptions, Configuration flinkConf) {}
{code}
> Add open method to PartitionCommitPolicy
>
>
> Key: FLINK-30551
> URL: https://issues.apache.org/jira/browse/FLINK-30551
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / FileSystem
>Reporter: Aitozi
>Priority: Major
> Labels: pull-request-available
>
> Currently, the {{PartitionCommitPolicy}} do not have the open hook. The
> custom partition commit policy does not have an appropriate entry point for
> the init work.
> So I purpose to add an {{open}} method to make this work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-30551) Add open method to PartitionCommitPolicy
[
https://issues.apache.org/jira/browse/FLINK-30551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691406#comment-17691406
]
tanjialiang commented on FLINK-30551:
-
I think it is necessary for custom partition commit policy to get the flink
configuration from open method. I can set some custom option into flink conf,
and use in my custom commit policy. WDYT? [~gaoyunhaii] [~lzljs3620320]
> Add open method to PartitionCommitPolicy
>
>
> Key: FLINK-30551
> URL: https://issues.apache.org/jira/browse/FLINK-30551
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / FileSystem
>Reporter: Aitozi
>Priority: Major
> Labels: pull-request-available
>
> Currently, the {{PartitionCommitPolicy}} do not have the open hook. The
> custom partition commit policy does not have an appropriate entry point for
> the init work.
> So I purpose to add an {{open}} method to make this work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-30551) Add open method to PartitionCommitPolicy
[
https://issues.apache.org/jira/browse/FLINK-30551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653949#comment-17653949
]
Aitozi commented on FLINK-30551:
cc [~gaoyunhaii] what do you think of this ?
> Add open method to PartitionCommitPolicy
>
>
> Key: FLINK-30551
> URL: https://issues.apache.org/jira/browse/FLINK-30551
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / FileSystem
>Reporter: Aitozi
>Priority: Major
>
> Currently, the {{PartitionCommitPolicy}} do not have the open hook. The
> custom partition commit policy does not have an appropriate entry point for
> the init work.
> So I purpose to add an {{open}} method to make this work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
