[jira] [Commented] (FLINK-31310) Force clear directory no matter what situation in HiveCatalog.dropTable

2023-03-06 Thread Jingsong Lee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696809#comment-17696809
 ] 

Jingsong Lee commented on FLINK-31310:
--

[~nicholasjiang] You are right, it is good to keep the files on DFS.

> Force clear directory no matter what situation in HiveCatalog.dropTable
> ---
>
> Key: FLINK-31310
> URL: https://issues.apache.org/jira/browse/FLINK-31310
> Project: Flink
>  Issue Type: Improvement
>  Components: Table Store
>Reporter: Jingsong Lee
>Assignee: Nicholas Jiang
>Priority: Major
> Fix For: table-store-0.4.0
>
>
> Currently, if no table in hive, will not clear the table.
> We should clear table directory in any situation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31310) Force clear directory no matter what situation in HiveCatalog.dropTable

2023-03-04 Thread Nicholas Jiang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696460#comment-17696460
 ] 

Nicholas Jiang commented on FLINK-31310:


[~lzljs3620320], the `dropTable` interface is invoked after `getTable`, 
therefore if no tale in hive, the `dropTable` could not be invoked, because 
there is a check whether table exist in `getDataTableSchema`. IMO, when no 
table in hive, users could use the FileSystemCatalog to drop the table and 
clear table directory and HiveCatalog only drops the table in Hive and clear 
table directory via hive metastore client.

> Force clear directory no matter what situation in HiveCatalog.dropTable
> ---
>
> Key: FLINK-31310
> URL: https://issues.apache.org/jira/browse/FLINK-31310
> Project: Flink
>  Issue Type: Improvement
>  Components: Table Store
>Reporter: Jingsong Lee
>Assignee: Nicholas Jiang
>Priority: Major
> Fix For: table-store-0.4.0
>
>
> Currently, if no table in hive, will not clear the table.
> We should clear table directory in any situation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31310) Force clear directory no matter what situation in HiveCatalog.dropTable

2023-03-03 Thread Jingsong Lee (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696077#comment-17696077
 ] 

Jingsong Lee commented on FLINK-31310:
--

[~nicholasjiang] Thanks!

> Force clear directory no matter what situation in HiveCatalog.dropTable
> ---
>
> Key: FLINK-31310
> URL: https://issues.apache.org/jira/browse/FLINK-31310
> Project: Flink
>  Issue Type: Improvement
>  Components: Table Store
>Reporter: Jingsong Lee
>Assignee: Nicholas Jiang
>Priority: Major
> Fix For: table-store-0.4.0
>
>
> Currently, if no table in hive, will not clear the table.
> We should clear table directory in any situation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31310) Force clear directory no matter what situation in HiveCatalog.dropTable

2023-03-02 Thread Nicholas Jiang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696048#comment-17696048
 ] 

Nicholas Jiang commented on FLINK-31310:


[~lzljs3620320], could you assign this to me?

> Force clear directory no matter what situation in HiveCatalog.dropTable
> ---
>
> Key: FLINK-31310
> URL: https://issues.apache.org/jira/browse/FLINK-31310
> Project: Flink
>  Issue Type: Improvement
>  Components: Table Store
>Reporter: Jingsong Lee
>Priority: Major
> Fix For: table-store-0.4.0
>
>
> Currently, if no table in hive, will not clear the table.
> We should clear table directory in any situation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)