[jira] [Commented] (FLINK-31487) Add targetColumns to DynamicTableSink#Context
[ https://issues.apache.org/jira/browse/FLINK-31487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747225#comment-17747225 ] lincoln lee commented on FLINK-31487: - [~knaufk] Yes, only the javadoc is currently available. It may be beneficial for connector developers to add appropriate notes to the current documentation. I've created a subtask and updated the doc. > Add targetColumns to DynamicTableSink#Context > - > > Key: FLINK-31487 > URL: https://issues.apache.org/jira/browse/FLINK-31487 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Reporter: lincoln lee >Assignee: lincoln lee >Priority: Major > Labels: pull-request-available > Fix For: 1.18.0 > > > FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null > overwrite problem of partial-insert > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240885081 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-31487) Add targetColumns to DynamicTableSink#Context
[ https://issues.apache.org/jira/browse/FLINK-31487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746922#comment-17746922 ] Konstantin Knauf commented on FLINK-31487: -- [~lincoln.86xy] Is this feature already documented for users/developers? Should it be documented beyond JavaDocs? > Add targetColumns to DynamicTableSink#Context > - > > Key: FLINK-31487 > URL: https://issues.apache.org/jira/browse/FLINK-31487 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Reporter: lincoln lee >Assignee: lincoln lee >Priority: Major > Labels: pull-request-available > Fix For: 1.18.0 > > > FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null > overwrite problem of partial-insert > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240885081 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-31487) Add targetColumns to DynamicTableSink#Context
[ https://issues.apache.org/jira/browse/FLINK-31487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708928#comment-17708928 ] lincoln lee commented on FLINK-31487: - [~martijnvisser] As expected by flip-300, the `SinkRuntimeProviderContext` provided to the connector has a new constructor that supports the `targetColumns` parameter, so there are no compatibility issues in the production code path. However, the compilation error here appears to be that the connector built the mockContext for testing purposes, which does require adaptation to the new interface, I can fix these errors, but the connector main branch I checked out only sees a dependency on flink-1.17, so how do we switch to flink-1.18? > Add targetColumns to DynamicTableSink#Context > - > > Key: FLINK-31487 > URL: https://issues.apache.org/jira/browse/FLINK-31487 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Reporter: lincoln lee >Assignee: lincoln lee >Priority: Major > Labels: pull-request-available > Fix For: 1.18.0 > > > FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null > overwrite problem of partial-insert > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240885081 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-31487) Add targetColumns to DynamicTableSink#Context
[ https://issues.apache.org/jira/browse/FLINK-31487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708724#comment-17708724 ] Martijn Visser commented on FLINK-31487: Same for Opensearch https://github.com/apache/flink-connector-opensearch/actions/runs/4615625503/jobs/8159702829#step:13:142 > Add targetColumns to DynamicTableSink#Context > - > > Key: FLINK-31487 > URL: https://issues.apache.org/jira/browse/FLINK-31487 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Reporter: lincoln lee >Assignee: lincoln lee >Priority: Major > Labels: pull-request-available > Fix For: 1.18.0 > > > FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null > overwrite problem of partial-insert > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240885081 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-31487) Add targetColumns to DynamicTableSink#Context
[ https://issues.apache.org/jira/browse/FLINK-31487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708514#comment-17708514 ] Martijn Visser commented on FLINK-31487: [~lincoln.86xy] Is this breaking existing connectors? For example, Elasticsearch can't compile against 1.18-SNAPSHOT https://github.com/apache/flink-connector-elasticsearch/actions/runs/4610232254/jobs/8148440894#step:13:154 > Add targetColumns to DynamicTableSink#Context > - > > Key: FLINK-31487 > URL: https://issues.apache.org/jira/browse/FLINK-31487 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Reporter: lincoln lee >Assignee: lincoln lee >Priority: Major > Labels: pull-request-available > Fix For: 1.18.0 > > > FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null > overwrite problem of partial-insert > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240885081 -- This message was sent by Atlassian Jira (v8.20.10#820010)
