[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018652#comment-16018652 ] ASF GitHub Bot commented on FLINK-3155: --- Github user kdombeck closed the pull request at: https://github.com/apache/flink/pull/3490 > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: Docker >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018651#comment-16018651 ] ASF GitHub Bot commented on FLINK-3155: --- Github user kdombeck commented on the issue: https://github.com/apache/flink/pull/3490 Sounds great. Thanks > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: Docker >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017538#comment-16017538 ] ASF GitHub Bot commented on FLINK-3155: --- Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3490 @kdombeck thank you for this PR! We now have [official Docker images](https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/docker.html) and I see that the contrib Dockerfile no longer hard codes a Flink version. If this satisfies your request please close this PR. > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: Docker >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901447#comment-15901447 ] ASF GitHub Bot commented on FLINK-3155: --- Github user kdombeck commented on a diff in the pull request: https://github.com/apache/flink/pull/3490#discussion_r104945513 --- Diff: flink-contrib/docker-flink/Dockerfile --- @@ -22,7 +22,7 @@ FROM java:8-jre-alpine RUN apk add --no-cache bash snappy # Configure Flink version -ARG FLINK_VERSION=1.1.3 +ARG FLINK_VERSION=1.1.4 --- End diff -- The main reason for the upgrade that I needed was the the mirrors did not have version 1.1.3. They only had 1.1.4 and 1.2.0. Which is probably a different issue. Example: http://mirrors.advancedhosters.com/apache/flink/ > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901439#comment-15901439 ] ASF GitHub Bot commented on FLINK-3155: --- Github user kdombeck commented on the issue: https://github.com/apache/flink/pull/3490 Added to existing Jira [issue](https://issues.apache.org/jira/browse/FLINK-3155) > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424545#comment-15424545 ] ASF GitHub Bot commented on FLINK-3155: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2340 > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424534#comment-15424534 ] ASF GitHub Bot commented on FLINK-3155: --- Github user mxm commented on the issue: https://github.com/apache/flink/pull/2340 Thanks for addressing my comments! Looks very good. I'm sorry I asked whether you have tested the changes. It may seem natural to you but trust me that is not always the case :) Merging... > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424529#comment-15424529
]
ASF GitHub Bot commented on FLINK-3155:
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r75123833
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,31 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink version
-ARG FLINK_VERSION=1.0.3
+ARG FLINK_VERSION=1.1.1
ARG HADOOP_VERSION=27
ARG SCALA_VERSION=2.11
+# Flink environment variables
+ARG FLINK_INSTALL_PATH=/opt
+ENV FLINK_HOME $FLINK_INSTALL_PATH/flink
+ENV PATH $PATH:$FLINK_HOME/bin
+
# Install build dependencies and flink
RUN set -x && \
+ mkdir -p $FLINK_INSTALL_PATH && \
apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
- awk '/preferred/ {gsub(/"/,""); print
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
- tar xvz -C /usr/local/ && \
- ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
- sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g"
/usr/local/flink/bin/flink-daemon.sh && \
+ curl -s $(curl -s
https://www.apache.org/dyn/closer.cgi\?preferred\=true)flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
--- End diff --
Much better! Thanks :)
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Maximilian Michels
>Priority: Minor
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417467#comment-15417467 ] ASF GitHub Bot commented on FLINK-3155: --- Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2340 And remember that my ultimate goal is not to host that image but that we can convert it into an official one. > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417465#comment-15417465 ] ASF GitHub Bot commented on FLINK-3155: --- Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2340 Of course, who do you think I am :P You can check a ready to run build here in case you don't want to test that one. But it is true that we need some kind of automatized tests for the image. https://hub.docker.com/r/iemejia/flink/ > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417450#comment-15417450 ] ASF GitHub Bot commented on FLINK-3155: --- Github user mxm commented on the issue: https://github.com/apache/flink/pull/2340 Thanks! Looks good. Did you run the changes with Docker? > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417447#comment-15417447
]
ASF GitHub Bot commented on FLINK-3155:
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74445659
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink version
-ARG FLINK_VERSION=1.0.3
+ARG FLINK_VERSION=1.1.0
ARG HADOOP_VERSION=27
ARG SCALA_VERSION=2.11
+# Flink environment variables
+ENV FLINK_HOME /opt/flink
+ENV PATH $PATH:$FLINK_HOME/bin
+
# Install build dependencies and flink
RUN set -x && \
+ mkdir -p /opt && \
apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
- awk '/preferred/ {gsub(/"/,""); print
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
- tar xvz -C /usr/local/ && \
- ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
- sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g"
/usr/local/flink/bin/flink-daemon.sh && \
+ curl -s
https://archive.apache.org/dist/flink/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz
| \
--- End diff --
Still would like to keep it because it is strongly encouraged to not use
the load balanced servers instead of the archive server.
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Maximilian Michels
>Priority: Minor
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417442#comment-15417442
]
ASF GitHub Bot commented on FLINK-3155:
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74445485
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink version
-ARG FLINK_VERSION=1.0.3
+ARG FLINK_VERSION=1.1.0
ARG HADOOP_VERSION=27
ARG SCALA_VERSION=2.11
+# Flink environment variables
+ENV FLINK_HOME /opt/flink
+ENV PATH $PATH:$FLINK_HOME/bin
+
# Install build dependencies and flink
RUN set -x && \
+ mkdir -p /opt && \
apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
- awk '/preferred/ {gsub(/"/,""); print
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
- tar xvz -C /usr/local/ && \
- ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
- sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g"
/usr/local/flink/bin/flink-daemon.sh && \
+ curl -s
https://archive.apache.org/dist/flink/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz
| \
--- End diff --
I see your point concerning fragility. You're probably right. Btw, you can
always validate the download using the MD5/SHA256 files from the archive server
:)
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Maximilian Michels
>Priority: Minor
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417104#comment-15417104 ] ASF GitHub Bot commented on FLINK-3155: --- Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2340 @mxm this should be ready now. > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415397#comment-15415397
]
ASF GitHub Bot commented on FLINK-3155:
---
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74261518
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink version
-ARG FLINK_VERSION=1.0.3
+ARG FLINK_VERSION=1.1.0
ARG HADOOP_VERSION=27
ARG SCALA_VERSION=2.11
+# Flink environment variables
+ENV FLINK_HOME /opt/flink
+ENV PATH $PATH:$FLINK_HOME/bin
+
# Install build dependencies and flink
RUN set -x && \
+ mkdir -p /opt && \
apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
- awk '/preferred/ {gsub(/"/,""); print
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
- tar xvz -C /usr/local/ && \
- ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
- sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g"
/usr/local/flink/bin/flink-daemon.sh && \
+ curl -s
https://archive.apache.org/dist/flink/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz
| \
--- End diff --
Notice that I have another argument against the mirrors and it is the
security issue, imagine that a malign mirror puts a wrong version of flink, I
wonder what is the recomended approach to validate this case (of course notice
that I asume that hacking apache would be harder).
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Maximilian Michels
>Priority: Minor
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415382#comment-15415382 ] ASF GitHub Bot commented on FLINK-3155: --- Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2340 We should maybe wait for 1.1.1 to be up before doing this merge, I will add the commit for this and probably rebase everything once it is ready. Is it ok ? > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415381#comment-15415381
]
ASF GitHub Bot commented on FLINK-3155:
---
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74259291
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink version
-ARG FLINK_VERSION=1.0.3
+ARG FLINK_VERSION=1.1.0
ARG HADOOP_VERSION=27
ARG SCALA_VERSION=2.11
+# Flink environment variables
+ENV FLINK_HOME /opt/flink
+ENV PATH $PATH:$FLINK_HOME/bin
+
# Install build dependencies and flink
RUN set -x && \
+ mkdir -p /opt && \
apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
- awk '/preferred/ {gsub(/"/,""); print
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
- tar xvz -C /usr/local/ && \
- ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
- sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g"
/usr/local/flink/bin/flink-daemon.sh && \
+ curl -s
https://archive.apache.org/dist/flink/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz
| \
+ tar xvz -C /opt/ && \
--- End diff --
Ok.
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Maximilian Michels
>Priority: Minor
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415264#comment-15415264
]
ASF GitHub Bot commented on FLINK-3155:
---
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74243197
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink version
-ARG FLINK_VERSION=1.0.3
+ARG FLINK_VERSION=1.1.0
ARG HADOOP_VERSION=27
ARG SCALA_VERSION=2.11
+# Flink environment variables
+ENV FLINK_HOME /opt/flink
+ENV PATH $PATH:$FLINK_HOME/bin
+
# Install build dependencies and flink
RUN set -x && \
+ mkdir -p /opt && \
apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
- awk '/preferred/ {gsub(/"/,""); print
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
- tar xvz -C /usr/local/ && \
- ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
- sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g"
/usr/local/flink/bin/flink-daemon.sh && \
+ curl -s
https://archive.apache.org/dist/flink/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz
| \
--- End diff --
I agree, I just changed it because I find the older code so ugly (and
fragile) for what it does, also my other argument to do this was the fact that
people will probably won't build the image as much as they will pull it from
the official hub.docker image (once we publish this image as the official one).
I can let it like it was if this is better for you.
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Maximilian Michels
>Priority: Minor
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415160#comment-15415160 ] ASF GitHub Bot commented on FLINK-3155: --- Github user mxm commented on the issue: https://github.com/apache/flink/pull/2340 Thanks for the PR! It would be nice to have the install path configurable. Also, we should use ASF's load balancing script for downloading the binaries. > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415159#comment-15415159
]
ASF GitHub Bot commented on FLINK-3155:
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74229989
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink version
-ARG FLINK_VERSION=1.0.3
+ARG FLINK_VERSION=1.1.0
ARG HADOOP_VERSION=27
ARG SCALA_VERSION=2.11
+# Flink environment variables
+ENV FLINK_HOME /opt/flink
+ENV PATH $PATH:$FLINK_HOME/bin
+
# Install build dependencies and flink
RUN set -x && \
+ mkdir -p /opt && \
apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
- awk '/preferred/ {gsub(/"/,""); print
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
- tar xvz -C /usr/local/ && \
- ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
- sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g"
/usr/local/flink/bin/flink-daemon.sh && \
+ curl -s
https://archive.apache.org/dist/flink/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz
| \
+ tar xvz -C /opt/ && \
--- End diff --
Could we make the install path configurable?
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Maximilian Michels
>Priority: Minor
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415158#comment-15415158
]
ASF GitHub Bot commented on FLINK-3155:
---
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74229920
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink version
-ARG FLINK_VERSION=1.0.3
+ARG FLINK_VERSION=1.1.0
ARG HADOOP_VERSION=27
ARG SCALA_VERSION=2.11
+# Flink environment variables
+ENV FLINK_HOME /opt/flink
+ENV PATH $PATH:$FLINK_HOME/bin
+
# Install build dependencies and flink
RUN set -x && \
+ mkdir -p /opt && \
apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s https://www.apache.org/dyn/closer.cgi\?as_json\=1 | \
- awk '/preferred/ {gsub(/"/,""); print
$2}')flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
- tar xvz -C /usr/local/ && \
- ln -s /usr/local/flink-$FLINK_VERSION /usr/local/flink && \
- sed -i -e "s/echo \$mypid >> \$pid/echo \$mypid >> \$pid \&\& wait/g"
/usr/local/flink/bin/flink-daemon.sh && \
+ curl -s
https://archive.apache.org/dist/flink/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz
| \
--- End diff --
The use of the archive mirror is discouraged. It's better to use the load
balancing script which you removed above.
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0, 1.1.0
>Reporter: Maximilian Michels
>Priority: Minor
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411100#comment-15411100 ] ASF GitHub Bot commented on FLINK-3155: --- Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2340 I added two additional changes, an extra security fix (default user is not root now) and I changed the path to the more appropriate /opt. Now this should be ready for review/merge. > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0, 1.1.0 >Reporter: Maximilian Michels >Priority: Minor > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410910#comment-15410910 ] ASF GitHub Bot commented on FLINK-3155: --- Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2340 (notice than when I said need to improve I refer at the missing automation to change the default release version on the Dockerfile). > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0 >Reporter: Maximilian Michels > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410909#comment-15410909 ] ASF GitHub Bot commented on FLINK-3155: --- Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2340 I referred to the older FLINK issue since this is something we need to still improve. I can try to fix it in a subsequent PR, do you have any hints of how can we achieve this ? R: @aljoscha or @mxm > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0 >Reporter: Maximilian Michels > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[
https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410908#comment-15410908
]
ASF GitHub Bot commented on FLINK-3155:
---
GitHub user iemejia opened a pull request:
https://github.com/apache/flink/pull/2340
[FLINK-3155] Update docker flink container to the latest release
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iemejia/flink new
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2340
commit 299a7536db6cb51dd9920989caaaf527a4cb4feb
Author: Ismaël Mejía
Date: 2016-08-07T10:57:48Z
[FLINK-3155] Update docker flink container to the latest release
I also simplified some stuff from the basic script
> Update Flink docker version to latest stable Flink version
> --
>
> Key: FLINK-3155
> URL: https://issues.apache.org/jira/browse/FLINK-3155
> Project: Flink
> Issue Type: Task
> Components: flink-contrib
>Affects Versions: 1.0.0
>Reporter: Maximilian Michels
> Fix For: 1.0.0
>
>
> It would be nice to always set the Docker Flink binary URL to point to the
> latest Flink version. Until then, this JIRA keeps track of the updates for
> releases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277920#comment-15277920 ] ASF GitHub Bot commented on FLINK-3155: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1969 > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0 >Reporter: Maximilian Michels > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277917#comment-15277917 ] ASF GitHub Bot commented on FLINK-3155: --- Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1969#issuecomment-218118993 Thanks for the pull request! Looks good. Merging.. > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0 >Reporter: Maximilian Michels > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3155) Update Flink docker version to latest stable Flink version
[ https://issues.apache.org/jira/browse/FLINK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048534#comment-15048534 ] ASF GitHub Bot commented on FLINK-3155: --- Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1443#issuecomment-163196855 Thanks @hsaputra for the reminder. I've filed a JIRA: https://issues.apache.org/jira/browse/FLINK-3155 Looks good to merge otherwise. > Update Flink docker version to latest stable Flink version > -- > > Key: FLINK-3155 > URL: https://issues.apache.org/jira/browse/FLINK-3155 > Project: Flink > Issue Type: Task > Components: flink-contrib >Affects Versions: 1.0.0 >Reporter: Maximilian Michels > Fix For: 1.0.0 > > > It would be nice to always set the Docker Flink binary URL to point to the > latest Flink version. Until then, this JIRA keeps track of the updates for > releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
