[jira] [Commented] (FLINK-31990) Use Flink Configuration to specify KDS Source configuration object

2023-06-19 Thread Danny Cranmer (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734168#comment-17734168
 ] 

Danny Cranmer commented on FLINK-31990:
---

ok thanks [~liangtl] 

 

> Use Flink Configuration to specify KDS Source configuration object
> --
>
> Key: FLINK-31990
> URL: https://issues.apache.org/jira/browse/FLINK-31990
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Hong Liang Teoh
>Assignee: Hong Liang Teoh
>Priority: Major
>  Labels: pull-request-available
>
> *What*
> Use the Flink Configuration object to standardise the method of specifying 
> configurations for the KDS source. 
>  
> Also include validations:
>  - -Check that region in config matches ARN. ARN should take priority.-
>  
> *Why*
> We want to standardise error messages + source serialization methods 
> implemented by Flink on the Flink Configuration objects.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31990) Use Flink Configuration to specify KDS Source configuration object

2023-06-15 Thread Hong Liang Teoh (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733249#comment-17733249
 ] 

Hong Liang Teoh commented on FLINK-31990:
-

Thanks for flagging, Danny!

I did some thinking about this, and actually just realise that this is not 
needed.

A user might want to make a cross-region call to a Kinesis stream. That way the 
config's Region can be different to the stream ARN's region. Will strike off in 
the description

 

 

> Use Flink Configuration to specify KDS Source configuration object
> --
>
> Key: FLINK-31990
> URL: https://issues.apache.org/jira/browse/FLINK-31990
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Hong Liang Teoh
>Assignee: Hong Liang Teoh
>Priority: Major
>  Labels: pull-request-available
>
> *What*
> Use the Flink Configuration object to standardise the method of specifying 
> configurations for the KDS source. 
>  
> Also include validations:
> - Check that region in config matches ARN. ARN should take priority.
>  
> *Why*
> We want to standardise error messages + source serialization methods 
> implemented by Flink on the Flink Configuration objects.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31990) Use Flink Configuration to specify KDS Source configuration object

2023-06-15 Thread Danny Cranmer (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733176#comment-17733176
 ] 

Danny Cranmer commented on FLINK-31990:
---

This bit is not done [~liangtl] "Check that region in config matches ARN. ARN 
should take priority.". Please extract to new Jira or open another PR

> Use Flink Configuration to specify KDS Source configuration object
> --
>
> Key: FLINK-31990
> URL: https://issues.apache.org/jira/browse/FLINK-31990
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Hong Liang Teoh
>Assignee: Hong Liang Teoh
>Priority: Major
>  Labels: pull-request-available
>
> *What*
> Use the Flink Configuration object to standardise the method of specifying 
> configurations for the KDS source. 
>  
> Also include validations:
> - Check that region in config matches ARN. ARN should take priority.
>  
> *Why*
> We want to standardise error messages + source serialization methods 
> implemented by Flink on the Flink Configuration objects.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31990) Use Flink Configuration to specify KDS Source configuration object

2023-06-15 Thread Danny Cranmer (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733175#comment-17733175
 ] 

Danny Cranmer commented on FLINK-31990:
---

Merged commit 
[{{1006e6a}}|https://github.com/apache/flink-connector-aws/commit/1006e6ae47bcc6185b2782188958dd1e6f45634a]
 into apache:main 

> Use Flink Configuration to specify KDS Source configuration object
> --
>
> Key: FLINK-31990
> URL: https://issues.apache.org/jira/browse/FLINK-31990
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Hong Liang Teoh
>Assignee: Hong Liang Teoh
>Priority: Major
>  Labels: pull-request-available
>
> *What*
> Use the Flink Configuration object to standardise the method of specifying 
> configurations for the KDS source. 
>  
> Also include validations:
> - Check that region in config matches ARN. ARN should take priority.
>  
> *Why*
> We want to standardise error messages + source serialization methods 
> implemented by Flink on the Flink Configuration objects.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)