[jira] [Commented] (FLINK-32782) Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default
[ https://issues.apache.org/jira/browse/FLINK-32782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762306#comment-17762306 ] Sergey Nuyanzin commented on FLINK-32782: - Thanks for the advice [~knaufk] I'm going to close it > Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default > > > Key: FLINK-32782 > URL: https://issues.apache.org/jira/browse/FLINK-32782 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.18.0 >Reporter: Qingsheng Ren >Priority: Major > Fix For: 1.18.0 > > > Covered by nightly tests, for example > - run_test "Resuming Externalized Checkpoint (rocks, incremental, no > parallelism change) end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 2 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale up) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 4 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale down) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 4 2 > rocks true true" "skip_check_exceptions" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-32782) Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default
[ https://issues.apache.org/jira/browse/FLINK-32782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762003#comment-17762003 ] Yun Tang commented on FLINK-32782: -- +1 for [~knaufk]'s advice, let's close this ticket [~renqs]. > Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default > > > Key: FLINK-32782 > URL: https://issues.apache.org/jira/browse/FLINK-32782 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.18.0 >Reporter: Qingsheng Ren >Priority: Major > Fix For: 1.18.0 > > > Covered by nightly tests, for example > - run_test "Resuming Externalized Checkpoint (rocks, incremental, no > parallelism change) end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 2 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale up) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 4 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale down) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 4 2 > rocks true true" "skip_check_exceptions" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-32782) Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default
[ https://issues.apache.org/jira/browse/FLINK-32782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761981#comment-17761981 ] Konstantin Knauf commented on FLINK-32782: -- I don't think we need to test it after talking to [~srichter]. The correctness is verified by our nightly tests. If someone wants to verify the performance improvements, we could leave it open, but I don't think this is strictly necessary. > Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default > > > Key: FLINK-32782 > URL: https://issues.apache.org/jira/browse/FLINK-32782 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.18.0 >Reporter: Qingsheng Ren >Priority: Major > Fix For: 1.18.0 > > > Covered by nightly tests, for example > - run_test "Resuming Externalized Checkpoint (rocks, incremental, no > parallelism change) end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 2 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale up) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 4 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale down) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 4 2 > rocks true true" "skip_check_exceptions" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-32782) Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default
[ https://issues.apache.org/jira/browse/FLINK-32782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761683#comment-17761683 ] Yun Tang commented on FLINK-32782: -- Same as I raised in FLINK-32783, why do we need to test this internal improvement manually? > Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default > > > Key: FLINK-32782 > URL: https://issues.apache.org/jira/browse/FLINK-32782 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.18.0 >Reporter: Qingsheng Ren >Priority: Major > Fix For: 1.18.0 > > > Covered by nightly tests, for example > - run_test "Resuming Externalized Checkpoint (rocks, incremental, no > parallelism change) end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 2 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale up) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 4 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale down) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 4 2 > rocks true true" "skip_check_exceptions" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-32782) Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default
[ https://issues.apache.org/jira/browse/FLINK-32782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760812#comment-17760812 ] Qingsheng Ren commented on FLINK-32782: --- [~srichter] IIUC this feature is not visible to end users, so we don't need to test it manually right? > Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default > > > Key: FLINK-32782 > URL: https://issues.apache.org/jira/browse/FLINK-32782 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.18.0 >Reporter: Qingsheng Ren >Priority: Major > Fix For: 1.18.0 > > > Covered by nightly tests, for example > - run_test "Resuming Externalized Checkpoint (rocks, incremental, no > parallelism change) end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 2 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale up) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 2 4 > rocks true true" "skip_check_exceptions" > - run_test "Resuming Externalized Checkpoint (rocks, incremental, scale down) > end-to-end test" > "$END_TO_END_DIR/test-scripts/test_resume_externalized_checkpoints.sh 4 2 > rocks true true" "skip_check_exceptions" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-32782) Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default
[ https://issues.apache.org/jira/browse/FLINK-32782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757262#comment-17757262 ] Qingsheng Ren commented on FLINK-32782: --- Unassigning the issue from the original author of the new feature. Please re-assign the ticket to the actual person doing the test. > Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default > > > Key: FLINK-32782 > URL: https://issues.apache.org/jira/browse/FLINK-32782 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.18.0 >Reporter: Qingsheng Ren >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-32782) Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default
[ https://issues.apache.org/jira/browse/FLINK-32782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757263#comment-17757263 ] Qingsheng Ren commented on FLINK-32782: --- [~srichter] Could you provide some instructions or link to the documentation in the "Description" field about how to verify the feature? Thanks! > Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default > > > Key: FLINK-32782 > URL: https://issues.apache.org/jira/browse/FLINK-32782 > Project: Flink > Issue Type: Sub-task > Components: Tests >Affects Versions: 1.18.0 >Reporter: Qingsheng Ren >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
