[jira] [Commented] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772516#comment-17772516 ] Etienne Chauchot commented on FLINK-33104: -- [~tzulitai] yes this is exactly what I wanted to do for Cassandra but it requires a change in the github actions scripts and/or on main build proposedĀ [here|https://issues.apache.org/jira/browse/FLINK-32563] but I received no feedback. Among the 3 proposed changes in that ticket, I prefer the one that links the dep convergence tests and the archunit tests into a single maven profile (like architecture tests). I'll do this change in a PR. > Nightly run for Flink Kafka connector fails due to architecture tests failing > - > > Key: FLINK-33104 > URL: https://issues.apache.org/jira/browse/FLINK-33104 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: kafka-3.1.0 >Reporter: Martijn Visser >Priority: Blocker > > {code:java} > 2023-09-17T00:29:07.1675694Z [WARNING] Tests run: 18, Failures: 0, Errors: 0, > Skipped: 9, Time elapsed: 308.532 s - in > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerMigrationTest > 2023-09-17T00:29:07.5171608Z [INFO] > 2023-09-17T00:29:07.5172360Z [INFO] Results: > 2023-09-17T00:29:07.5172773Z [INFO] > 2023-09-17T00:29:07.5173139Z [ERROR] Failures: > 2023-09-17T00:29:07.5174181Z [ERROR] Architecture Violation [Priority: > MEDIUM] - Rule 'ITCASE tests should use a MiniCluster resource or extension' > was violated (13 times): > 2023-09-17T00:29:07.5176050Z > org.apache.flink.connector.kafka.sink.FlinkKafkaInternalProducerITCase does > not satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5177452Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5179831Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5181277Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5182154Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5182951Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5183906Z > org.apache.flink.connector.kafka.sink.KafkaSinkITCase does not satisfy: only > one of the following predicates match: > 2023-09-17T00:29:07.5184769Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5185812Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5186880Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5187929Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5189073Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5190076Z > org.apache.flink.connector.kafka.sink.KafkaTransactionLogITCase does not > satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5190946Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5191983Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv >
[jira] [Commented] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772385#comment-17772385 ] Tzu-Li (Gordon) Tai commented on FLINK-33104: - [~echauchot] this seems to be the conclusion, correct?: [https://lists.apache.org/thread/pr0g812olzpgz21d9oodhc46db9jpxo3] If that's the case, I'll do the same for the Kafka connector as well then. i.e. * for now only run archunit tests when building against 1.17.1 * once 1.18 drops, update the violation store and switch to run archunit tests only against 1.18.0 > Nightly run for Flink Kafka connector fails due to architecture tests failing > - > > Key: FLINK-33104 > URL: https://issues.apache.org/jira/browse/FLINK-33104 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: kafka-3.1.0 >Reporter: Martijn Visser >Priority: Blocker > > {code:java} > 2023-09-17T00:29:07.1675694Z [WARNING] Tests run: 18, Failures: 0, Errors: 0, > Skipped: 9, Time elapsed: 308.532 s - in > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerMigrationTest > 2023-09-17T00:29:07.5171608Z [INFO] > 2023-09-17T00:29:07.5172360Z [INFO] Results: > 2023-09-17T00:29:07.5172773Z [INFO] > 2023-09-17T00:29:07.5173139Z [ERROR] Failures: > 2023-09-17T00:29:07.5174181Z [ERROR] Architecture Violation [Priority: > MEDIUM] - Rule 'ITCASE tests should use a MiniCluster resource or extension' > was violated (13 times): > 2023-09-17T00:29:07.5176050Z > org.apache.flink.connector.kafka.sink.FlinkKafkaInternalProducerITCase does > not satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5177452Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5179831Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5181277Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5182154Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5182951Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5183906Z > org.apache.flink.connector.kafka.sink.KafkaSinkITCase does not satisfy: only > one of the following predicates match: > 2023-09-17T00:29:07.5184769Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5185812Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5186880Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5187929Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5189073Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5190076Z > org.apache.flink.connector.kafka.sink.KafkaTransactionLogITCase does not > satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5190946Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5191983Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5192845Z * reside in a package >
[jira] [Commented] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770338#comment-17770338 ] Etienne Chauchot commented on FLINK-33104: -- [~martijnvisser] actually it was never fixed in cassandra (see FLINK-32353): the problem is that when archunit rules change we need to update the archunit violation store. And there is only a single violation store. As the nightly tests the connector against several versions of flink, there will be failures if not all these versions have the same archunit rules. To fix this problem we need to skip archunit tests on Flink versions that are not the main one (the one the connector is built against) so that the single arunit violation store contains the violations for the main flink version. I proposed some change in the github action script hereĀ for which I was waiting for your feedback. > Nightly run for Flink Kafka connector fails due to architecture tests failing > - > > Key: FLINK-33104 > URL: https://issues.apache.org/jira/browse/FLINK-33104 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: kafka-3.1.0 >Reporter: Martijn Visser >Priority: Blocker > > {code:java} > 2023-09-17T00:29:07.1675694Z [WARNING] Tests run: 18, Failures: 0, Errors: 0, > Skipped: 9, Time elapsed: 308.532 s - in > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerMigrationTest > 2023-09-17T00:29:07.5171608Z [INFO] > 2023-09-17T00:29:07.5172360Z [INFO] Results: > 2023-09-17T00:29:07.5172773Z [INFO] > 2023-09-17T00:29:07.5173139Z [ERROR] Failures: > 2023-09-17T00:29:07.5174181Z [ERROR] Architecture Violation [Priority: > MEDIUM] - Rule 'ITCASE tests should use a MiniCluster resource or extension' > was violated (13 times): > 2023-09-17T00:29:07.5176050Z > org.apache.flink.connector.kafka.sink.FlinkKafkaInternalProducerITCase does > not satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5177452Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5179831Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5181277Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5182154Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5182951Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5183906Z > org.apache.flink.connector.kafka.sink.KafkaSinkITCase does not satisfy: only > one of the following predicates match: > 2023-09-17T00:29:07.5184769Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5185812Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5186880Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5187929Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5189073Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5190076Z > org.apache.flink.connector.kafka.sink.KafkaTransactionLogITCase does not > satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5190946Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5191983Z * reside
[jira] [Commented] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770274#comment-17770274 ] Martijn Visser commented on FLINK-33104: [~mason6345] I don't think we have to update to JUnit5 in order to get this fixed. IIRC, we had a similar problem with the Cassandra connector on this topic and we managed to get it fixed there too. It's more because Flink 1.18 has an updated version of Archunit, while the rules that we have are still build for a lower version of Archunit in general. [~echauchot] do you recall this situation we had with the Cassandra connector? > Nightly run for Flink Kafka connector fails due to architecture tests failing > - > > Key: FLINK-33104 > URL: https://issues.apache.org/jira/browse/FLINK-33104 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: kafka-3.1.0 >Reporter: Martijn Visser >Priority: Blocker > > {code:java} > 2023-09-17T00:29:07.1675694Z [WARNING] Tests run: 18, Failures: 0, Errors: 0, > Skipped: 9, Time elapsed: 308.532 s - in > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerMigrationTest > 2023-09-17T00:29:07.5171608Z [INFO] > 2023-09-17T00:29:07.5172360Z [INFO] Results: > 2023-09-17T00:29:07.5172773Z [INFO] > 2023-09-17T00:29:07.5173139Z [ERROR] Failures: > 2023-09-17T00:29:07.5174181Z [ERROR] Architecture Violation [Priority: > MEDIUM] - Rule 'ITCASE tests should use a MiniCluster resource or extension' > was violated (13 times): > 2023-09-17T00:29:07.5176050Z > org.apache.flink.connector.kafka.sink.FlinkKafkaInternalProducerITCase does > not satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5177452Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5179831Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5181277Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5182154Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5182951Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5183906Z > org.apache.flink.connector.kafka.sink.KafkaSinkITCase does not satisfy: only > one of the following predicates match: > 2023-09-17T00:29:07.5184769Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5185812Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5186880Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5187929Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5189073Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5190076Z > org.apache.flink.connector.kafka.sink.KafkaTransactionLogITCase does not > satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5190946Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5191983Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv >
[jira] [Commented] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770197#comment-17770197 ] Mason Chen commented on FLINK-33104: [~martijnvisser] do we need any help with updating the particular unit tests to unblock this? I have some bandwidth. It seems arch test error report is valid and affects important tests so I wouldn't pursue an alternative method to ignore the errors > Nightly run for Flink Kafka connector fails due to architecture tests failing > - > > Key: FLINK-33104 > URL: https://issues.apache.org/jira/browse/FLINK-33104 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: kafka-3.1.0 >Reporter: Martijn Visser >Priority: Blocker > > {code:java} > 2023-09-17T00:29:07.1675694Z [WARNING] Tests run: 18, Failures: 0, Errors: 0, > Skipped: 9, Time elapsed: 308.532 s - in > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerMigrationTest > 2023-09-17T00:29:07.5171608Z [INFO] > 2023-09-17T00:29:07.5172360Z [INFO] Results: > 2023-09-17T00:29:07.5172773Z [INFO] > 2023-09-17T00:29:07.5173139Z [ERROR] Failures: > 2023-09-17T00:29:07.5174181Z [ERROR] Architecture Violation [Priority: > MEDIUM] - Rule 'ITCASE tests should use a MiniCluster resource or extension' > was violated (13 times): > 2023-09-17T00:29:07.5176050Z > org.apache.flink.connector.kafka.sink.FlinkKafkaInternalProducerITCase does > not satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5177452Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5179831Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5181277Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5182154Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5182951Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5183906Z > org.apache.flink.connector.kafka.sink.KafkaSinkITCase does not satisfy: only > one of the following predicates match: > 2023-09-17T00:29:07.5184769Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5185812Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5186880Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5187929Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5189073Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5190076Z > org.apache.flink.connector.kafka.sink.KafkaTransactionLogITCase does not > satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5190946Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5191983Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5192845Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5193532Z * reside outside
[jira] [Commented] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767232#comment-17767232 ] Mason Chen commented on FLINK-33104: Do we want to ignore the violations for now? or do we want to migrate tests to JUnit5? I can help do some of the refactoring. Moreover, it seems like any arch unit rule addition can easily break builds. I don't know if there is anything to make this situation more stable since we rely on the SNAPSHOT artifacts > Nightly run for Flink Kafka connector fails due to architecture tests failing > - > > Key: FLINK-33104 > URL: https://issues.apache.org/jira/browse/FLINK-33104 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: kafka-3.1.0 >Reporter: Martijn Visser >Priority: Blocker > > {code:java} > 2023-09-17T00:29:07.1675694Z [WARNING] Tests run: 18, Failures: 0, Errors: 0, > Skipped: 9, Time elapsed: 308.532 s - in > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerMigrationTest > 2023-09-17T00:29:07.5171608Z [INFO] > 2023-09-17T00:29:07.5172360Z [INFO] Results: > 2023-09-17T00:29:07.5172773Z [INFO] > 2023-09-17T00:29:07.5173139Z [ERROR] Failures: > 2023-09-17T00:29:07.5174181Z [ERROR] Architecture Violation [Priority: > MEDIUM] - Rule 'ITCASE tests should use a MiniCluster resource or extension' > was violated (13 times): > 2023-09-17T00:29:07.5176050Z > org.apache.flink.connector.kafka.sink.FlinkKafkaInternalProducerITCase does > not satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5177452Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5179831Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5181277Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5182154Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5182951Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5183906Z > org.apache.flink.connector.kafka.sink.KafkaSinkITCase does not satisfy: only > one of the following predicates match: > 2023-09-17T00:29:07.5184769Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5185812Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5186880Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5187929Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5189073Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5190076Z > org.apache.flink.connector.kafka.sink.KafkaTransactionLogITCase does not > satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5190946Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5191983Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5192845Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class >
[jira] [Commented] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766321#comment-17766321 ] Jiabao Sun commented on FLINK-33104: Hi [~martijnvisser]. Could you help assign this ticket to me? > Nightly run for Flink Kafka connector fails due to architecture tests failing > - > > Key: FLINK-33104 > URL: https://issues.apache.org/jira/browse/FLINK-33104 > Project: Flink > Issue Type: Bug > Components: Connectors / Kafka >Affects Versions: kafka-3.1.0 >Reporter: Martijn Visser >Priority: Blocker > > {code:java} > 2023-09-17T00:29:07.1675694Z [WARNING] Tests run: 18, Failures: 0, Errors: 0, > Skipped: 9, Time elapsed: 308.532 s - in > org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerMigrationTest > 2023-09-17T00:29:07.5171608Z [INFO] > 2023-09-17T00:29:07.5172360Z [INFO] Results: > 2023-09-17T00:29:07.5172773Z [INFO] > 2023-09-17T00:29:07.5173139Z [ERROR] Failures: > 2023-09-17T00:29:07.5174181Z [ERROR] Architecture Violation [Priority: > MEDIUM] - Rule 'ITCASE tests should use a MiniCluster resource or extension' > was violated (13 times): > 2023-09-17T00:29:07.5176050Z > org.apache.flink.connector.kafka.sink.FlinkKafkaInternalProducerITCase does > not satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5177452Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5179831Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5181277Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5182154Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5182951Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5183906Z > org.apache.flink.connector.kafka.sink.KafkaSinkITCase does not satisfy: only > one of the following predicates match: > 2023-09-17T00:29:07.5184769Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5185812Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5186880Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5187929Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5189073Z or contain any fields that are public, static, > and of type MiniClusterWithClientResource and final and annotated with > @ClassRule or contain any fields that is of type > MiniClusterWithClientResource and public and final and not static and > annotated with @Rule > 2023-09-17T00:29:07.5190076Z > org.apache.flink.connector.kafka.sink.KafkaTransactionLogITCase does not > satisfy: only one of the following predicates match: > 2023-09-17T00:29:07.5190946Z * reside in a package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type InternalMiniClusterExtension and annotated with @RegisterExtension > 2023-09-17T00:29:07.5191983Z * reside outside of package > 'org.apache.flink.runtime.*' and contain any fields that are static, final, > and of type MiniClusterExtension and annotated with @RegisterExtension or are > , and of type MiniClusterTestEnvironment and annotated with @TestEnv > 2023-09-17T00:29:07.5192845Z * reside in a package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > InternalMiniClusterExtension > 2023-09-17T00:29:07.5193532Z * reside outside of package > 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class > MiniClusterExtension > 2023-09-17T00:29:07.5194300Z or contain any fields that are public, static,