[jira] [Commented] (FLINK-3371) Move TriggerCotext and TriggerResult to their own classes
[
https://issues.apache.org/jira/browse/FLINK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141729#comment-15141729
]
ASF GitHub Bot commented on FLINK-3371:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1603
> Move TriggerCotext and TriggerResult to their own classes
> -
>
> Key: FLINK-3371
> URL: https://issues.apache.org/jira/browse/FLINK-3371
> Project: Flink
> Issue Type: Sub-task
> Components: Windowing Operators
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
> Fix For: 1.0.0
>
>
> As part of adding aligned window operators, we need aligned trigger classes.
> To make the {{TriggerResult}} and {{TriggerContext}} accessible to them, they
> should move to their own classes, from currently being internal classes of
> {{Trigger}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3371) Move TriggerCotext and TriggerResult to their own classes
[
https://issues.apache.org/jira/browse/FLINK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138777#comment-15138777
]
ASF GitHub Bot commented on FLINK-3371:
---
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1603#issuecomment-181813971
Exactly, the `AlignedTrigger` will have an `AlignedTriggerContext` without
Key/Value state.
> Move TriggerCotext and TriggerResult to their own classes
> -
>
> Key: FLINK-3371
> URL: https://issues.apache.org/jira/browse/FLINK-3371
> Project: Flink
> Issue Type: Sub-task
> Components: Windowing Operators
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
> Fix For: 1.0.0
>
>
> As part of adding aligned window operators, we need aligned trigger classes.
> To make the {{TriggerResult}} and {{TriggerContext}} accessible to them, they
> should move to their own classes, from currently being internal classes of
> {{Trigger}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3371) Move TriggerCotext and TriggerResult to their own classes
[
https://issues.apache.org/jira/browse/FLINK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138754#comment-15138754
]
ASF GitHub Bot commented on FLINK-3371:
---
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1603#issuecomment-181807335
You are not moving `TriggerContext` because it is specific to Trigger,
correct?
Otherwise it looks good to merge. :+1:
> Move TriggerCotext and TriggerResult to their own classes
> -
>
> Key: FLINK-3371
> URL: https://issues.apache.org/jira/browse/FLINK-3371
> Project: Flink
> Issue Type: Sub-task
> Components: Windowing Operators
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
> Fix For: 1.0.0
>
>
> As part of adding aligned window operators, we need aligned trigger classes.
> To make the {{TriggerResult}} and {{TriggerContext}} accessible to them, they
> should move to their own classes, from currently being internal classes of
> {{Trigger}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3371) Move TriggerCotext and TriggerResult to their own classes
[
https://issues.apache.org/jira/browse/FLINK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137159#comment-15137159
]
ASF GitHub Bot commented on FLINK-3371:
---
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1603
[FLINK-3371] [api breaking] Move TriggerResult and TriggerContext to
dedicated classes
**This change should go into 1.0, because it is API breaking**
In order to prepare for adding aligned windows, this PR unnests some
classes needed for aligned triggers.
The functionality stays the same, only imports would need to be adjusted by
users.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink trigger_own_class
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1603.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1603
commit 3c05feef35384ac7ce9304ef461c7ef637fa3fe9
Author: Stephan Ewen
Date: 2016-02-07T20:46:16Z
Move TriggerResult and TriggerContext to dedicated classes
> Move TriggerCotext and TriggerResult to their own classes
> -
>
> Key: FLINK-3371
> URL: https://issues.apache.org/jira/browse/FLINK-3371
> Project: Flink
> Issue Type: Sub-task
> Components: Windowing Operators
>Affects Versions: 1.0.0
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
> Fix For: 1.0.0
>
>
> As part of adding aligned window operators, we need aligned trigger classes.
> To make the {{TriggerResult}} and {{TriggerContext}} accessible to them, they
> should move to their own classes, from currently being internal classes of
> {{Trigger}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
