[jira] [Commented] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
[
https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139530#comment-15139530
]
ASF GitHub Bot commented on FLINK-3382:
---
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1614#issuecomment-182025617
Shouldn't the current record remain valid if `hasNext()` returned true? I
mean the user might be holding on to the object returned in `next`, and expect
it to not be changed by a `hasNext` call:
```
T cur = it.next();
if(it.hasNext()) {
// here, I would expect cur to not have changed since the next() call
}
```
> Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
> -
>
> Key: FLINK-3382
> URL: https://issues.apache.org/jira/browse/FLINK-3382
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime
>Affects Versions: 1.0.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Minor
>
> Object reuse in {{ReusingMutableToRegularIteratorWrapper.hasNext()}} can be
> clarified by creating a single object and storing the iterator's next value
> into the second reference.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
[
https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139652#comment-15139652
]
ASF GitHub Bot commented on FLINK-3382:
---
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1614#issuecomment-182035391
Ah, yes, now I see. I'll just burn this.
> Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
> -
>
> Key: FLINK-3382
> URL: https://issues.apache.org/jira/browse/FLINK-3382
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime
>Affects Versions: 1.0.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Minor
>
> Object reuse in {{ReusingMutableToRegularIteratorWrapper.hasNext()}} can be
> clarified by creating a single object and storing the iterator's next value
> into the second reference.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
[
https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139653#comment-15139653
]
ASF GitHub Bot commented on FLINK-3382:
---
Github user greghogan closed the pull request at:
https://github.com/apache/flink/pull/1614
> Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
> -
>
> Key: FLINK-3382
> URL: https://issues.apache.org/jira/browse/FLINK-3382
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime
>Affects Versions: 1.0.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Minor
>
> Object reuse in {{ReusingMutableToRegularIteratorWrapper.hasNext()}} can be
> clarified by creating a single object and storing the iterator's next value
> into the second reference.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3382) Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
[
https://issues.apache.org/jira/browse/FLINK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139441#comment-15139441
]
ASF GitHub Bot commented on FLINK-3382:
---
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1614
[FLINK-3382] Improve clarity of object reuse in
ReusingMutableToRegularIteratorWrapper
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
3382_improve_clarity_of_object_reuse_in_ReusingMutableToRegularIteratorWrapper
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1614.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1614
> Improve clarity of object reuse in ReusingMutableToRegularIteratorWrapper
> -
>
> Key: FLINK-3382
> URL: https://issues.apache.org/jira/browse/FLINK-3382
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime
>Affects Versions: 1.0.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Minor
>
> Object reuse in {{ReusingMutableToRegularIteratorWrapper.hasNext()}} can be
> clarified by creating a single object and storing the iterator's next value
> into the second reference.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
