[jira] [Commented] (FLINK-33994) Use Datadog api key from environment variables if not set in conf

2024-01-04 Thread Sweta Kalakuntla (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803289#comment-17803289
 ] 

Sweta Kalakuntla commented on FLINK-33994:
--

Ok, I just shared the PR that was done by someone in that regard. 

However this is still needed for to store config in environment and not in code.

> Use Datadog api key from environment variables if not set in conf
> -
>
> Key: FLINK-33994
> URL: https://issues.apache.org/jira/browse/FLINK-33994
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Metrics
>Reporter: Sweta Kalakuntla
>Priority: Major
>
> Add a way to set Datadog API key from the environment variables. This way 
> during deployment, there is way to set the value from secrets/vault instead 
> of hardcoding key into code.
> Someone has created PR :
> [https://github.com/apache/flink/pull/19684/files] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-33994) Use Datadog api key from environment variables if not set in conf

2024-01-04 Thread Martijn Visser (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803251#comment-17803251
 ] 

Martijn Visser commented on FLINK-33994:


That PR isn't in good shape (doesn't have a test and it just changes the 
behavior from one thing to another, instead of properly configuring it). 

> Use Datadog api key from environment variables if not set in conf
> -
>
> Key: FLINK-33994
> URL: https://issues.apache.org/jira/browse/FLINK-33994
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Metrics
>Reporter: Sweta Kalakuntla
>Priority: Major
>
> Add a way to set Datadog API key from the environment variables. This way 
> during deployment, there is way to set the value from secrets/vault instead 
> of hardcoding key into code.
> Someone has created PR :
> [https://github.com/apache/flink/pull/19684/files] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)