[jira] [Commented] (FLINK-3808) Refactor the whole file monitoring source to take a fileInputFormat as an argument.
[ https://issues.apache.org/jira/browse/FLINK-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286690#comment-15286690 ] Kostas Kloudas commented on FLINK-3808: --- This is included in FLINK-3889 > Refactor the whole file monitoring source to take a fileInputFormat as an > argument. > --- > > Key: FLINK-3808 > URL: https://issues.apache.org/jira/browse/FLINK-3808 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Kostas Kloudas >Assignee: Kostas Kloudas > > This issue is just an intermediate step towards making the file source > fault-tolerant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3808) Refactor the whole file monitoring source to take a fileInputFormat as an argument.
[ https://issues.apache.org/jira/browse/FLINK-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286702#comment-15286702 ] ASF GitHub Bot commented on FLINK-3808: --- Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/1929 > Refactor the whole file monitoring source to take a fileInputFormat as an > argument. > --- > > Key: FLINK-3808 > URL: https://issues.apache.org/jira/browse/FLINK-3808 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Kostas Kloudas >Assignee: Kostas Kloudas > > This issue is just an intermediate step towards making the file source > fault-tolerant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3808) Refactor the whole file monitoring source to take a fileInputFormat as an argument.
[ https://issues.apache.org/jira/browse/FLINK-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286701#comment-15286701 ] ASF GitHub Bot commented on FLINK-3808: --- Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-219732847 This is now included in https://github.com/apache/flink/pull/1984 > Refactor the whole file monitoring source to take a fileInputFormat as an > argument. > --- > > Key: FLINK-3808 > URL: https://issues.apache.org/jira/browse/FLINK-3808 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Kostas Kloudas >Assignee: Kostas Kloudas > > This issue is just an intermediate step towards making the file source > fault-tolerant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3808) Refactor the whole file monitoring source to take a fileInputFormat as an argument.
[ https://issues.apache.org/jira/browse/FLINK-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268790#comment-15268790 ] ASF GitHub Bot commented on FLINK-3808: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-216545948 Ah man, you're right, the test needs to be moved to the `flink-fs-tests` package, I think. > Refactor the whole file monitoring source to take a fileInputFormat as an > argument. > --- > > Key: FLINK-3808 > URL: https://issues.apache.org/jira/browse/FLINK-3808 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Kostas Kloudas >Assignee: Kostas Kloudas > > This issue is just an intermediate step towards making the file source > fault-tolerant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3808) Refactor the whole file monitoring source to take a fileInputFormat as an argument.
[ https://issues.apache.org/jira/browse/FLINK-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268567#comment-15268567 ] ASF GitHub Bot commented on FLINK-3808: --- Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-216503327 One related test failure; the hadoop dependency could not be found for PROFILE="-Dhadoop.profile=1" > Refactor the whole file monitoring source to take a fileInputFormat as an > argument. > --- > > Key: FLINK-3808 > URL: https://issues.apache.org/jira/browse/FLINK-3808 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Kostas Kloudas >Assignee: Kostas Kloudas > > This issue is just an intermediate step towards making the file source > fault-tolerant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3808) Refactor the whole file monitoring source to take a fileInputFormat as an argument.
[ https://issues.apache.org/jira/browse/FLINK-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262238#comment-15262238 ] ASF GitHub Bot commented on FLINK-3808: --- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-215446453 I'm very happy with this now. 😃 Looks good to merge. Now for the checkpointable `InputFormat` and actually putting it into the API... > Refactor the whole file monitoring source to take a fileInputFormat as an > argument. > --- > > Key: FLINK-3808 > URL: https://issues.apache.org/jira/browse/FLINK-3808 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Kostas Kloudas >Assignee: Kostas Kloudas > > This issue is just an intermediate step towards making the file source > fault-tolerant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3808) Refactor the whole file monitoring source to take a fileInputFormat as an argument.
[ https://issues.apache.org/jira/browse/FLINK-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262107#comment-15262107 ] ASF GitHub Bot commented on FLINK-3808: --- Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-215418217 Thanks for the comments @aljoscha I integrated them. Let me know how it looks now. > Refactor the whole file monitoring source to take a fileInputFormat as an > argument. > --- > > Key: FLINK-3808 > URL: https://issues.apache.org/jira/browse/FLINK-3808 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Kostas Kloudas >Assignee: Kostas Kloudas > > This issue is just an intermediate step towards making the file source > fault-tolerant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3808) Refactor the whole file monitoring source to take a fileInputFormat as an argument.
[ https://issues.apache.org/jira/browse/FLINK-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256418#comment-15256418 ] Kostas Kloudas commented on FLINK-3808: --- PR https://github.com/apache/flink/pull/1929 addresses this. > Refactor the whole file monitoring source to take a fileInputFormat as an > argument. > --- > > Key: FLINK-3808 > URL: https://issues.apache.org/jira/browse/FLINK-3808 > Project: Flink > Issue Type: Sub-task > Components: Streaming >Reporter: Kostas Kloudas >Assignee: Kostas Kloudas > > This issue is just an intermediate step towards making the file source > fault-tolerant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)