[jira] [Commented] (FLINK-3877) Create TranslateFunction interface for Graph translators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276545#comment-15276545
 ] 

ASF GitHub Bot commented on FLINK-3877:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1968


> Create TranslateFunction interface for Graph translators
> 
>
> Key: FLINK-3877
> URL: https://issues.apache.org/jira/browse/FLINK-3877
> Project: Flink
>  Issue Type: Bug
>  Components: Gelly
>Affects Versions: 1.1.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Minor
> Fix For: 1.1.0
>
>
> I now recall why FLINK-3771 had a {{Translator}} interface with a 
> {{translate}} method taking a field for reuse: when we translate edge ID the 
> translator must be called twice.
> {{TranslateFunction}} will be modeled after {{MapFunction}} and 
> {{RichTranslateFunction}} will be modeled after {{RichMapFunction}}.
> The unit test should have caught this but I was reusing values between fields 
> which did not detect that values were overwritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3877) Create TranslateFunction interface for Graph translators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276536#comment-15276536
 ] 

ASF GitHub Bot commented on FLINK-3877:
---

Github user greghogan commented on the pull request:

https://github.com/apache/flink/pull/1968#issuecomment-217904645
  
Merging ...


> Create TranslateFunction interface for Graph translators
> 
>
> Key: FLINK-3877
> URL: https://issues.apache.org/jira/browse/FLINK-3877
> Project: Flink
>  Issue Type: Bug
>  Components: Gelly
>Affects Versions: 1.1.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Minor
> Fix For: 1.1.0
>
>
> I now recall why FLINK-3771 had a {{Translator}} interface with a 
> {{translate}} method taking a field for reuse: when we translate edge ID the 
> translator must be called twice.
> {{TranslateFunction}} will be modeled after {{MapFunction}} and 
> {{RichTranslateFunction}} will be modeled after {{RichMapFunction}}.
> The unit test should have caught this but I was reusing values between fields 
> which did not detect that values were overwritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3877) Create TranslateFunction interface for Graph translators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274331#comment-15274331
 ] 

ASF GitHub Bot commented on FLINK-3877:
---

GitHub user greghogan opened a pull request:

https://github.com/apache/flink/pull/1968

[FLINK-3877] [gelly] Create TranslateFunction interface for Graph 
translators

The TranslateFunction interface is similar to MapFunction but may be called 
multiple times before serialization.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greghogan/flink 
3877_create_translatefunction_interface_for_graph_translators

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1968


commit b1d838a276c9c0f2e6b79b34f924cc42c93c371d
Author: Greg Hogan 
Date:   2016-05-04T20:51:23Z

[FLINK-3877] [gelly] Create TranslateFunction interface for Graph 
translators

The TranslateFunction interface is similar to MapFunction but may be
called multiple times before serialization.




> Create TranslateFunction interface for Graph translators
> 
>
> Key: FLINK-3877
> URL: https://issues.apache.org/jira/browse/FLINK-3877
> Project: Flink
>  Issue Type: Bug
>  Components: Gelly
>Affects Versions: 1.1.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Minor
> Fix For: 1.1.0
>
>
> I now recall why FLINK-3771 had a {{Translator}} interface with a 
> {{translate}} method taking a field for reuse: when we translate edge ID the 
> translator must be called twice.
> {{TranslateFunction}} will be modeled after {{MapFunction}} and 
> {{RichTranslateFunction}} will be modeled after {{RichMapFunction}}.
> The unit test should have caught this but I was reusing values between fields 
> which did not detect that values were overwritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)