[jira] [Commented] (FLINK-3883) Rename flink clients for inclusion on system path
[ https://issues.apache.org/jira/browse/FLINK-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696125#comment-15696125 ] Maximilian Michels commented on FLINK-3883: --- +1 for the proposed renaming. All scripts which import {{config.sh}} automatically switch to the symlink resolved directory. So you can use {{pwd}} or look it up in the {{SYMLINK_RESOLVED_BIN}} variable. > Rename flink clients for inclusion on system path > - > > Key: FLINK-3883 > URL: https://issues.apache.org/jira/browse/FLINK-3883 > Project: Flink > Issue Type: Bug > Components: Client >Reporter: Eron Wright >Priority: Minor > > I ran into some trouble in preparing a Homebrew formula to install Flink on > Mac ([homebrew-core#968|https://github.com/Homebrew/homebrew-core/pull/968]). > Homebrew can install bin scripts into the system path, e.g. > `/usr/local/bin/flink`: > {code} > $ cat /usr/local/bin/flink > #!/bin/bash > exec "/usr/local/Cellar/apache-flink/1.0.2/libexec/bin/flink" "$@" > {code} > It would be nice to install the various Flink shells too, but their names > don't seem ideal for inclusion on the system path. I propose that they be > renamed or aliased to have the following names (old -> new): > {code} > "pyflink2.sh" -> "pyflink2" > "pyflink3.sh" -> "pyflink3" > "start-scala-shell.sh" -> "flink-scala-shell" (note: updated based on > feedback) > {code} > A related issue is, the shell scripts don't correctly determine their install > location when called via a symlink. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3883) Rename flink clients for inclusion on system path
[ https://issues.apache.org/jira/browse/FLINK-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276313#comment-15276313 ] Greg Hogan commented on FLINK-3883: --- +1 with a consideration for "start-scala-shell.sh" -> "flink-scala-shell" since Java 9 is planned to include a Java REPL. > Rename flink clients for inclusion on system path > - > > Key: FLINK-3883 > URL: https://issues.apache.org/jira/browse/FLINK-3883 > Project: Flink > Issue Type: Bug > Components: Command-line client >Reporter: Eron Wright >Priority: Minor > > I ran into some trouble in preparing a Homebrew formula to install Flink on > Mac ([homebrew-core#968|https://github.com/Homebrew/homebrew-core/pull/968]). > Homebrew can install bin scripts into the system path, e.g. > `/usr/local/bin/flink`: > {code} > $ cat /usr/local/bin/flink > #!/bin/bash > exec "/usr/local/Cellar/apache-flink/1.0.2/libexec/bin/flink" "$@" > {code} > It would be nice to install the various Flink shells too, but their names > don't seem ideal for inclusion on the system path. I propose that they be > renamed or aliased to have the following names (old -> new): > {code} > "pyflink2.sh" -> "pyflink2" > "pyflink3.sh" -> "pyflink3" > "start-scala-shell.sh" -> "flink-shell" > {code} > A related issue is, the shell scripts don't correctly determine their install > location when called via a symlink. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3883) Rename flink clients for inclusion on system path
[ https://issues.apache.org/jira/browse/FLINK-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276130#comment-15276130 ] Aljoscha Krettek commented on FLINK-3883: - +1 The symlink thing should be fixed quickly. > Rename flink clients for inclusion on system path > - > > Key: FLINK-3883 > URL: https://issues.apache.org/jira/browse/FLINK-3883 > Project: Flink > Issue Type: Bug > Components: Command-line client >Reporter: Eron Wright >Priority: Minor > > I ran into some trouble in preparing a Homebrew formula to install Flink on > Mac ([homebrew-core#968|https://github.com/Homebrew/homebrew-core/pull/968]). > Homebrew can install bin scripts into the system path, e.g. > `/usr/local/bin/flink`: > {code} > $ cat /usr/local/bin/flink > #!/bin/bash > exec "/usr/local/Cellar/apache-flink/1.0.2/libexec/bin/flink" "$@" > {code} > It would be nice to install the various Flink shells too, but their names > don't seem ideal for inclusion on the system path. I propose that they be > renamed or aliased to have the following names (old -> new): > {code} > "pyflink2.sh" -> "pyflink2" > "pyflink3.sh" -> "pyflink3" > "start-scala-shell.sh" -> "flink-shell" > {code} > A related issue is, the shell scripts don't correctly determine their install > location when called via a symlink. -- This message was sent by Atlassian JIRA (v6.3.4#6332)