[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[ https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372895#comment-15372895 ] ASF GitHub Bot commented on FLINK-3916: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2197 > Allow generic types passing the Table API > - > > Key: FLINK-3916 > URL: https://issues.apache.org/jira/browse/FLINK-3916 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > The Table API currently only supports BasicTypes that can pass the Table API. > Other types should also be supported but treated as black boxes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[ https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372887#comment-15372887 ] ASF GitHub Bot commented on FLINK-3916: --- Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2197 Merging... > Allow generic types passing the Table API > - > > Key: FLINK-3916 > URL: https://issues.apache.org/jira/browse/FLINK-3916 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > The Table API currently only supports BasicTypes that can pass the Table API. > Other types should also be supported but treated as black boxes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[ https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372624#comment-15372624 ] ASF GitHub Bot commented on FLINK-3916: --- Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2197 I would like to merge this if there are no objections. It is a very important improvement. > Allow generic types passing the Table API > - > > Key: FLINK-3916 > URL: https://issues.apache.org/jira/browse/FLINK-3916 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > The Table API currently only supports BasicTypes that can pass the Table API. > Other types should also be supported but treated as black boxes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[ https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362791#comment-15362791 ] ASF GitHub Bot commented on FLINK-3916: --- Github user vasia commented on the issue: https://github.com/apache/flink/pull/2197 Thanks for the ping @twalthr! I don't see anything suspicious :) > Allow generic types passing the Table API > - > > Key: FLINK-3916 > URL: https://issues.apache.org/jira/browse/FLINK-3916 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > The Table API currently only supports BasicTypes that can pass the Table API. > Other types should also be supported but treated as black boxes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[ https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361396#comment-15361396 ] ASF GitHub Bot commented on FLINK-3916: --- Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2197 @vasia Could you review the `FlinkPlannerImpl` changes? I changed many lines that you wrote. All test cases are still successful but maybe I forgot something. > Allow generic types passing the Table API > - > > Key: FLINK-3916 > URL: https://issues.apache.org/jira/browse/FLINK-3916 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Timo Walther > > The Table API currently only supports BasicTypes that can pass the Table API. > Other types should also be supported but treated as black boxes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[
https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361393#comment-15361393
]
ASF GitHub Bot commented on FLINK-3916:
---
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2197
[FLINK-3916] [table] Allow generic types passing the Table API
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
This PR reworks the type handling of Flink's TypeInformation to Calcite's
RelDataTypes. The new approach allows generic types passing through the Table
API and enables improved Pojo field access in future. The PR might also
implements parts of FLINK-3615.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink TableApiGenericTypePassThrough
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2197.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2197
commit e0d048f28dda56aea2ba3dfb5e75e17376667dd9
Author: twalthr
Date: 2016-05-17T14:14:29Z
[FLINK-3916] [table] Allow generic types passing the Table API
> Allow generic types passing the Table API
> -
>
> Key: FLINK-3916
> URL: https://issues.apache.org/jira/browse/FLINK-3916
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Timo Walther
>Assignee: Timo Walther
>
> The Table API currently only supports BasicTypes that can pass the Table API.
> Other types should also be supported but treated as black boxes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[
https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332354#comment-15332354
]
Vasia Kalavri commented on FLINK-3916:
--
FLINK-3615 is about extending or refactoring {{sqlTypeToTypeInfo}}. I do not
recall what kind of trouble it had caused at that time, but it looks like we
were thinking of refactoring the code to determine return types per operator.
> Allow generic types passing the Table API
> -
>
> Key: FLINK-3916
> URL: https://issues.apache.org/jira/browse/FLINK-3916
> Project: Flink
> Issue Type: Improvement
> Components: Table API
>Reporter: Timo Walther
>Assignee: Timo Walther
>
> The Table API currently only supports BasicTypes that can pass the Table API.
> Other types should also be supported but treated as black boxes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[ https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331490#comment-15331490 ] Timo Walther commented on FLINK-3916: - I'm not sure if this is a duplicate. [~vkalavri] what was the intention of FLINK-3615? > Allow generic types passing the Table API > - > > Key: FLINK-3916 > URL: https://issues.apache.org/jira/browse/FLINK-3916 > Project: Flink > Issue Type: Improvement > Components: Table API >Reporter: Timo Walther >Assignee: Timo Walther > > The Table API currently only supports BasicTypes that can pass the Table API. > Other types should also be supported but treated as black boxes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API
[ https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289220#comment-15289220 ] Fabian Hueske commented on FLINK-3916: -- Duplicate of FLINK-3615? > Allow generic types passing the Table API > - > > Key: FLINK-3916 > URL: https://issues.apache.org/jira/browse/FLINK-3916 > Project: Flink > Issue Type: Improvement > Components: Table API >Reporter: Timo Walther >Assignee: Timo Walther > > The Table API currently only supports BasicTypes that can pass the Table API. > Other types should also be supported but treated as black boxes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
