[jira] [Commented] (FLINK-4026) Fix code, grammar, and link issues in the Streaming documentation

2016-06-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318152#comment-15318152
 ] 

ASF GitHub Bot commented on FLINK-4026:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2077


> Fix code, grammar, and link issues in the Streaming documentation
> -
>
> Key: FLINK-4026
> URL: https://issues.apache.org/jira/browse/FLINK-4026
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Dyana Rose
>Priority: Trivial
> Fix For: 1.1.0
>
>
> The streaming API section of the documentation has issues with grammar that 
> make it hard to follow in places. As well as an incorrect code example, and 
> places of unnecessary parentheses on the Windows page, and a missing link for 
> Kinesis Streams on the Connectors index page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-4026) Fix code, grammar, and link issues in the Streaming documentation

2016-06-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318148#comment-15318148
 ] 

ASF GitHub Bot commented on FLINK-4026:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/2077
  
Thanks for your fixes! I'm merging. 😃 


> Fix code, grammar, and link issues in the Streaming documentation
> -
>
> Key: FLINK-4026
> URL: https://issues.apache.org/jira/browse/FLINK-4026
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Dyana Rose
>Priority: Trivial
>
> The streaming API section of the documentation has issues with grammar that 
> make it hard to follow in places. As well as an incorrect code example, and 
> places of unnecessary parentheses on the Windows page, and a missing link for 
> Kinesis Streams on the Connectors index page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-4026) Fix code, grammar, and link issues in the Streaming documentation

2016-06-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316643#comment-15316643
 ] 

ASF GitHub Bot commented on FLINK-4026:
---

GitHub user dyanarose opened a pull request:

https://github.com/apache/flink/pull/2077

[FLINK-4026] Fix code, grammar, and link issues in the Streaming 
documentation

* fixing grammar issues with he streaming API section of the documentation 
that make it hard to follow in places. 
* fixing an incorrect code example, and places of unnecessary parentheses 
on the Windows page
* adding a missing link for Kineses Streams on the Connectors index page.
* correcting the nav position of the Pre-defined Timestamp Extractors / 
Watermark Emitters page

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dyanarose/flink FLINK-4026

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2077.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2077


commit 9c561fb4825d202cefbe382df36abce7a6d825b3
Author: Dyana Rose 
Date:   2016-05-18T21:14:15Z

[FLINK-4026] Fix code, grammar, and link issues in the Streaming 
documentation




> Fix code, grammar, and link issues in the Streaming documentation
> -
>
> Key: FLINK-4026
> URL: https://issues.apache.org/jira/browse/FLINK-4026
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Dyana Rose
>Priority: Trivial
>
> The streaming API section of the documentation has issues with grammar that 
> make it hard to follow in places. As well as an incorrect code example, and 
> places of unnecessary parentheses on the Windows page, and a missing link for 
> Kineses Streams on the Connectors index page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-4026) Fix code, grammar, and link issues in the Streaming documentation

2016-06-06 Thread Dyana Rose (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316665#comment-15316665
 ] 

Dyana Rose commented on FLINK-4026:
---

oh the indignity, I fixed my own misspellings in the PR message, but the bot 
was too fast for me.

> Fix code, grammar, and link issues in the Streaming documentation
> -
>
> Key: FLINK-4026
> URL: https://issues.apache.org/jira/browse/FLINK-4026
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Dyana Rose
>Priority: Trivial
>
> The streaming API section of the documentation has issues with grammar that 
> make it hard to follow in places. As well as an incorrect code example, and 
> places of unnecessary parentheses on the Windows page, and a missing link for 
> Kineses Streams on the Connectors index page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FLINK-4026) Fix code, grammar, and link issues in the Streaming documentation

2016-06-06 Thread Dyana Rose (JIRA)

[ 
https://issues.apache.org/jira/browse/FLINK-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316631#comment-15316631
 ] 

Dyana Rose commented on FLINK-4026:
---

I've a branch for this that I'll PR shortly

> Fix code, grammar, and link issues in the Streaming documentation
> -
>
> Key: FLINK-4026
> URL: https://issues.apache.org/jira/browse/FLINK-4026
> Project: Flink
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Dyana Rose
>Priority: Trivial
>
> The streaming API section of the documentation has issues with grammar that 
> make it hard to follow in places. As well as an incorrect code example, and 
> places of unnecessary parentheses on the Windows page, and a missing link for 
> Kineses Streams on the Connectors index page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)