[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637665#comment-15637665
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2724


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache, 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637449#comment-15637449
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/2724
  
I'll merge the change ...


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636487#comment-15636487
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/2724
  
I have no issue with removing the properties tab. @iampeter the new UI 
features look very nice!


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636481#comment-15636481
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86554520
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@ 
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng-if="job")
 
nav.navbar.navbar-default.navbar-fixed-top.navbar-main-additional(ng-if="job")
   ul.nav.nav-tabs
 li(ui-sref-active='active')
-  a(ui-sref=".plan") Plan
+  a(ui-sref=".plan") Overview
 
-//- li(ui-sref-active='active' ng-if="job['end-time'] > -1")
 li(ui-sref-active='active')
   a(ui-sref=".timeline") Timeline
 
 li(ui-sref-active='active')
   a(ui-sref=".exceptions") Exceptions
 
 li(ui-sref-active='active')
-  a(ui-sref=".properties") Properties
-
-li(ui-sref-active='active')
   a(ui-sref=".config") Configuration
--- End diff --

I see it now. You have to click on an operator. I think I had filed this in 
a general UI ticket I had filed a while back but never gotten around to working 
on.


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636399#comment-15636399
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86549923
  
--- Diff: 
flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.node-list.metrics.jade
 ---
@@ -0,0 +1,47 @@
+//
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+ 
+  http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+
+p.p-info(ng-if="!nodeid")
+  em Select node to see the metrics
--- End diff --

Good point. I'll change it



> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636381#comment-15636381
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86548295
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@ 
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng-if="job")
 
nav.navbar.navbar-default.navbar-fixed-top.navbar-main-additional(ng-if="job")
   ul.nav.nav-tabs
 li(ui-sref-active='active')
-  a(ui-sref=".plan") Plan
+  a(ui-sref=".plan") Overview
 
-//- li(ui-sref-active='active' ng-if="job['end-time'] > -1")
 li(ui-sref-active='active')
   a(ui-sref=".timeline") Timeline
 
 li(ui-sref-active='active')
   a(ui-sref=".exceptions") Exceptions
 
 li(ui-sref-active='active')
-  a(ui-sref=".properties") Properties
-
-li(ui-sref-active='active')
   a(ui-sref=".config") Configuration
--- End diff --

I think it was originally meant to show properties from the batch optimizer.

This is how it looked:

![image](https://cloud.githubusercontent.com/assets/89049/20007707/ddb8c3b4-a29d-11e6-9ab5-53f1b48c74c6.png)

We can add it again once the page is showing some meaningful information.


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636385#comment-15636385
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user uce commented on the issue:

https://github.com/apache/flink/pull/2724
  
OK, thanks. Please don't forget the non-inline comments though with the 2nd 
PR ;) And maybe don't remove the properties tab if you are going to merge this 
before @greghogan replies.


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636371#comment-15636371
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/2724
  
Thank you for the review. I'm going to address your inline comments.
However, if you are okay with it, I would like to address your general 
comments with the next web interface pull request. @iampeter and I will soon 
open another PR (mainly to improve the job visualization and add low watermarks 
to the UI). We would address your comments with that PR.


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636133#comment-15636133
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86530365
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@ 
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng-if="job")
 
nav.navbar.navbar-default.navbar-fixed-top.navbar-main-additional(ng-if="job")
   ul.nav.nav-tabs
 li(ui-sref-active='active')
-  a(ui-sref=".plan") Plan
+  a(ui-sref=".plan") Overview
 
-//- li(ui-sref-active='active' ng-if="job['end-time'] > -1")
 li(ui-sref-active='active')
   a(ui-sref=".timeline") Timeline
 
 li(ui-sref-active='active')
   a(ui-sref=".exceptions") Exceptions
 
 li(ui-sref-active='active')
-  a(ui-sref=".properties") Properties
-
-li(ui-sref-active='active')
   a(ui-sref=".config") Configuration
--- End diff --

What is expected to be displayed in the Properties tab?


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636076#comment-15636076
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86396887
  
--- Diff: .gitignore ---
@@ -28,3 +30,5 @@ out/
 /docs/Gemfile.lock
 /docs/.bundle
 /docs/.rubydeps
+*.ipr
+*.iws
--- End diff --

What are `ipr` and `iws` files? I think we should remove these lines too.


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636075#comment-15636075
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86397283
  
--- Diff: flink-runtime-web/web-dashboard/bower.json ---
@@ -21,7 +20,9 @@
 "dagre-d3": "0.4.17",
 "font-awesome": "4.5.0",
 "moment-duration-format": "1.3.0",
-"qtip2": "2.2.1"
+"qtip2": "2.2.1",
+"angular-drag-and-drop-lists": "^1.4.0",
+"nvd3": "^1.8.4"
--- End diff --

Do we need to add these new dependencies to the license/notice files?


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636078#comment-15636078
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86526375
  
--- Diff: 
flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.node-list.metrics.jade
 ---
@@ -0,0 +1,47 @@
+//
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+ 
+  http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+
+p.p-info(ng-if="!nodeid")
+  em Select node to see the metrics
--- End diff --

Should we say operator instead of node here? 


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636074#comment-15636074
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86526289
  
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@ 
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng-if="job")
 
nav.navbar.navbar-default.navbar-fixed-top.navbar-main-additional(ng-if="job")
   ul.nav.nav-tabs
 li(ui-sref-active='active')
-  a(ui-sref=".plan") Plan
+  a(ui-sref=".plan") Overview
 
-//- li(ui-sref-active='active' ng-if="job['end-time'] > -1")
 li(ui-sref-active='active')
   a(ui-sref=".timeline") Timeline
 
 li(ui-sref-active='active')
   a(ui-sref=".exceptions") Exceptions
 
 li(ui-sref-active='active')
-  a(ui-sref=".properties") Properties
-
-li(ui-sref-active='active')
   a(ui-sref=".config") Configuration
--- End diff --

+1 to remove it since it doesn't help with streaming jobs. For batch it 
might be interesting. Did we have consensus to remove it? It's OK from my side.


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636073#comment-15636073
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86526490
  
--- Diff: 
flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.node-list.subtasks.jade
 ---
@@ -26,6 +26,7 @@ 
table.table.table-body-hover.table-clickable.table-activable
   th Records received
   th Bytes sent
   th Records sent
+  th Parallelism
--- End diff --

Good addition :)


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636077#comment-15636077
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user uce commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r86396834
  
--- Diff: .gitignore ---
@@ -16,6 +16,8 @@ tmp
 *.jar
 *.log
 .DS_Store
+_site
+docs/api
--- End diff --

Changes here should not be ignored

In general, we should remove both new ignores I think.


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622781#comment-15622781
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/2724
  
Thank you for the review @zentol. I addressed your comments and rebased to 
master again.


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616495#comment-15616495
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r85604825
  
--- Diff: flink-runtime-web/web-dashboard/app/scripts/index.coffee ---
@@ -39,6 +39,8 @@ angular.module('flinkApp', ['ui.router', 'angularMoment'])
 .run (JobsService, MainService, flinkConfig, $interval) ->
   MainService.loadConfig().then (config) ->
 angular.extend flinkConfig, config
+#console.log flinkConfig
--- End diff --

leftovers?


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616494#comment-15616494
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r85604628
  
--- Diff: 
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/socket/SocketWindowWordCount.java
 ---
@@ -30,7 +30,7 @@
  * Implements a streaming windowed version of the "WordCount" program.
  *
  * This program connects to a server socket and reads strings from the 
socket.
- * The easiest way to try this out is to open a text sever (at port 12345) 
+ * The easiest way to try this out is to open a text sever (at port 12345)
--- End diff --

typo: sever -> server


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616493#comment-15616493
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/2724#discussion_r85606565
  
--- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
 ---
@@ -383,25 +384,28 @@ private void connect(Integer headOfChain, StreamEdge 
edge) {

downStreamConfig.setNumberOfInputs(downStreamConfig.getNumberOfInputs() + 1);
 
StreamPartitioner partitioner = edge.getPartitioner();
+   JobEdge jobEdge = null;
if (partitioner instanceof ForwardPartitioner) {
-   downStreamVertex.connectNewDataSetAsInput(
+   jobEdge = downStreamVertex.connectNewDataSetAsInput(
headVertex,
DistributionPattern.POINTWISE,
ResultPartitionType.PIPELINED,
true);
} else if (partitioner instanceof RescalePartitioner){
-   downStreamVertex.connectNewDataSetAsInput(
+   jobEdge = downStreamVertex.connectNewDataSetAsInput(
headVertex,
DistributionPattern.POINTWISE,
ResultPartitionType.PIPELINED,
true);
} else {
-   downStreamVertex.connectNewDataSetAsInput(
+   jobEdge = downStreamVertex.connectNewDataSetAsInput(
headVertex,
DistributionPattern.ALL_TO_ALL,
ResultPartitionType.PIPELINED,
true);
}
+   // set strategy name so that web interface can show it.
+   jobEdge.setShipStrategyName(partitioner.toString());
--- End diff --

are these encoded in the JSON plan returned by 
`ExecutionGraph.getJsonPlan()`?


> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615958#comment-15615958
 ] 

ASF GitHub Bot commented on FLINK-4221:
---

GitHub user rmetzger opened a pull request:

https://github.com/apache/flink/pull/2724

[FLINK-4221] Show metrics in WebFrontend + general improvements

Other included changes:
- Removed Properties tab
- Renamed plan to overview
- Added parallelism to task list

Screenshot:

![image](https://cloud.githubusercontent.com/assets/89049/19815050/4d827396-9d41-11e6-9531-ba22a9bf8ba4.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rmetzger/flink piotr_rebase_2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2724


commit 921ea1fd59cec46d4103ead8170eb72848406858
Author: Piotr Godek 
Date:   2016-04-19T13:19:16Z

[FLINK-4221] Show metrics in WebFrontend + general improvements

Other included changes:
- Removed Properties tab
- Renamed plan to overview
- Added parallelism to task list




> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

[Robert Metzger (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575212#comment-15575212
 ] 

Robert Metzger commented on FLINK-4221:
---

I assigned the issue to myself, however, [~Zentol] and [~iampeter] are working 
on this as well.

> Show metrics in WebFrontend
> ---
>
> Key: FLINK-4221
> URL: https://issues.apache.org/jira/browse/FLINK-4221
> Project: Flink
>  Issue Type: Sub-task
>  Components: Metrics, Webfrontend
>Affects Versions: 1.0.0
>Reporter: Chesnay Schepler
>Assignee: Robert Metzger
> Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)