[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428349#comment-15428349 ] ASF GitHub Bot commented on FLINK-4402: --- Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2382 Thank you @rmetzger and @zentol > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Assignee: Neelesh Srinivas Salian >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428275#comment-15428275 ] ASF GitHub Bot commented on FLINK-4402: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2382 > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Assignee: Neelesh Srinivas Salian >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428266#comment-15428266 ] ASF GitHub Bot commented on FLINK-4402: --- Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2382 merging ... > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Assignee: Neelesh Srinivas Salian >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428211#comment-15428211 ] ASF GitHub Bot commented on FLINK-4402: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/2382 +1 > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Assignee: Neelesh Srinivas Salian >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428205#comment-15428205 ] ASF GitHub Bot commented on FLINK-4402: --- Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2382 Thank you for your contribution. I think its good to merge. @zentol can you confirm? > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Assignee: Neelesh Srinivas Salian >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425222#comment-15425222 ] ASF GitHub Bot commented on FLINK-4402: --- GitHub user nssalian opened a pull request: https://github.com/apache/flink/pull/2382 FLINK-4402: Wrong metrics parameter names in documentation Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - JIRA- https://issues.apache.org/jira/browse/FLINK-4402 - Title: Wrong metrics parameter names in documentation - [ ] Documentation - Changed the task and operator metrics in https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html to align with ConfigConstants.java - [ ] Tests & Build - `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/nssalian/flink FLINK-4402 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2382.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2382 commit 3d22950493abfdb8caae72447bb71bd6fcb8f709 Author: Neelesh Srinivas Salian Date: 2016-08-17T18:30:06Z FLINK-4402: Changed the documentation for the metrics in the System Scope Section > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Assignee: Neelesh Srinivas Salian >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425084#comment-15425084 ] Neelesh Srinivas Salian commented on FLINK-4402: Thank you. Posting a PR soon. > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425039#comment-15425039 ] RWenden commented on FLINK-4402: Ok with me. > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423395#comment-15423395 ] Neelesh Srinivas Salian commented on FLINK-4402: If you don't mind, shall I work on this JIRA? > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4402) Wrong metrics parameter names in documentation
[ https://issues.apache.org/jira/browse/FLINK-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423241#comment-15423241 ] Chesnay Schepler commented on FLINK-4402: - the documentation should be adjusted. > Wrong metrics parameter names in documentation > --- > > Key: FLINK-4402 > URL: https://issues.apache.org/jira/browse/FLINK-4402 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.1 > Environment: all >Reporter: RWenden >Priority: Trivial > Fix For: 1.1.2 > > Original Estimate: 4h > Remaining Estimate: 4h > > On the page > https://ci.apache.org/projects/flink/flink-docs-master/apis/metrics.html > the following metrics parameters should be > faulty: metrics.scope.tm.task , should be metrics.scope.task > faulty: metrics.scope.tm.operator , should be metrics.scope.operator > to make it work on Flink 1.1.1. > But to fix this, the constants in ConfigConstants.java can also be changed to > fit the documentation. Either way... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
