[jira] [Commented] (FLINK-4480) Incorrect link to elastic.co in documentation
[ https://issues.apache.org/jira/browse/FLINK-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439380#comment-15439380 ] ASF GitHub Bot commented on FLINK-4480: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2416 > Incorrect link to elastic.co in documentation > - > > Key: FLINK-4480 > URL: https://issues.apache.org/jira/browse/FLINK-4480 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.2.0, 1.1.1 >Reporter: Fabian Hueske >Assignee: Suneel Marthi >Priority: Trivial > > The link URL of the entry "Elasticsearch 2x (sink)" on the connector's > documentation page > https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/connectors/index.html > is pointing to http://elastic.com but should point to http://elastic.co -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4480) Incorrect link to elastic.co in documentation
[ https://issues.apache.org/jira/browse/FLINK-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437136#comment-15437136 ] ASF GitHub Bot commented on FLINK-4480: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2416 Merging this... > Incorrect link to elastic.co in documentation > - > > Key: FLINK-4480 > URL: https://issues.apache.org/jira/browse/FLINK-4480 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.2.0, 1.1.1 >Reporter: Fabian Hueske >Assignee: Suneel Marthi >Priority: Trivial > > The link URL of the entry "Elasticsearch 2x (sink)" on the connector's > documentation page > https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/connectors/index.html > is pointing to http://elastic.com but should point to http://elastic.co -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4480) Incorrect link to elastic.co in documentation
[ https://issues.apache.org/jira/browse/FLINK-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436847#comment-15436847 ] ASF GitHub Bot commented on FLINK-4480: --- Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2416 +1 to merge > Incorrect link to elastic.co in documentation > - > > Key: FLINK-4480 > URL: https://issues.apache.org/jira/browse/FLINK-4480 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.2.0, 1.1.1 >Reporter: Fabian Hueske >Assignee: Suneel Marthi >Priority: Trivial > > The link URL of the entry "Elasticsearch 2x (sink)" on the connector's > documentation page > https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/connectors/index.html > is pointing to http://elastic.com but should point to http://elastic.co -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4480) Incorrect link to elastic.co in documentation
[ https://issues.apache.org/jira/browse/FLINK-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436175#comment-15436175 ] ASF GitHub Bot commented on FLINK-4480: --- Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2416 Hi @smarthi, Thank you for picking this up. The changes LGTM :) Also tested the 2.3.5 ES version bump. Good catches on the Guava and broken example also! > Incorrect link to elastic.co in documentation > - > > Key: FLINK-4480 > URL: https://issues.apache.org/jira/browse/FLINK-4480 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.2.0, 1.1.1 >Reporter: Fabian Hueske >Assignee: Suneel Marthi >Priority: Trivial > > The link URL of the entry "Elasticsearch 2x (sink)" on the connector's > documentation page > https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/connectors/index.html > is pointing to http://elastic.com but should point to http://elastic.co -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4480) Incorrect link to elastic.co in documentation
[ https://issues.apache.org/jira/browse/FLINK-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435808#comment-15435808 ] ASF GitHub Bot commented on FLINK-4480: --- Github user smarthi commented on the issue: https://github.com/apache/flink/pull/2416 1. Changed the ES2 version to 2.3.5 2. Fixed broken ElasticsearchExample.java 3. Removed use of Guava API. > Incorrect link to elastic.co in documentation > - > > Key: FLINK-4480 > URL: https://issues.apache.org/jira/browse/FLINK-4480 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.2.0, 1.1.1 >Reporter: Fabian Hueske >Assignee: Suneel Marthi >Priority: Trivial > > The link URL of the entry "Elasticsearch 2x (sink)" on the connector's > documentation page > https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/connectors/index.html > is pointing to http://elastic.com but should point to http://elastic.co -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4480) Incorrect link to elastic.co in documentation
[
https://issues.apache.org/jira/browse/FLINK-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435804#comment-15435804
]
ASF GitHub Bot commented on FLINK-4480:
---
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2416
FLINK-4480: Incorrect link to elastic.co in documentation
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [X] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [X] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [X] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink FLINK-4480
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2416
commit ea53aa1e715a8d862282cfbaff2243431455c0ae
Author: smarthi
Date: 2016-08-24T22:07:23Z
FLINK-4480: Incorrect link to elastic.co in documentation
> Incorrect link to elastic.co in documentation
> -
>
> Key: FLINK-4480
> URL: https://issues.apache.org/jira/browse/FLINK-4480
> Project: Flink
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.2.0, 1.1.1
>Reporter: Fabian Hueske
>Assignee: Suneel Marthi
>Priority: Trivial
>
> The link URL of the entry "Elasticsearch 2x (sink)" on the connector's
> documentation page
> https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/connectors/index.html
> is pointing to http://elastic.com but should point to http://elastic.co
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
