[jira] [Commented] (FLINK-4494) Expose the TimeServiceProvider from the Task to each Operator.
[
https://issues.apache.org/jira/browse/FLINK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516455#comment-15516455
]
ASF GitHub Bot commented on FLINK-4494:
---
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2532
> Expose the TimeServiceProvider from the Task to each Operator.
> --
>
> Key: FLINK-4494
> URL: https://issues.apache.org/jira/browse/FLINK-4494
> Project: Flink
> Issue Type: Bug
>Reporter: Kostas Kloudas
>Assignee: Kostas Kloudas
>
> This change aims at simplifying the {{StreamTask}} class by exposing directly
> the {{TimeServiceProvider}} to the operators being executed.
> This implies removing the {{registerTimer()}} and
> {{getCurrentProcessingTime()}} methods from the {{StreamTask}}. Now, to
> register a timer and query the time, each operator will be able to get the
> {{TimeServiceProvider}} and call the corresponding methods directly on it.
> In addition, this will simplify many of the tests which now implement their
> own time providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4494) Expose the TimeServiceProvider from the Task to each Operator.
[
https://issues.apache.org/jira/browse/FLINK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516453#comment-15516453
]
ASF GitHub Bot commented on FLINK-4494:
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2532
Yes. Thanks a lot @aljoscha !
> Expose the TimeServiceProvider from the Task to each Operator.
> --
>
> Key: FLINK-4494
> URL: https://issues.apache.org/jira/browse/FLINK-4494
> Project: Flink
> Issue Type: Bug
>Reporter: Kostas Kloudas
>Assignee: Kostas Kloudas
>
> This change aims at simplifying the {{StreamTask}} class by exposing directly
> the {{TimeServiceProvider}} to the operators being executed.
> This implies removing the {{registerTimer()}} and
> {{getCurrentProcessingTime()}} methods from the {{StreamTask}}. Now, to
> register a timer and query the time, each operator will be able to get the
> {{TimeServiceProvider}} and call the corresponding methods directly on it.
> In addition, this will simplify many of the tests which now implement their
> own time providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4494) Expose the TimeServiceProvider from the Task to each Operator.
[
https://issues.apache.org/jira/browse/FLINK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516403#comment-15516403
]
ASF GitHub Bot commented on FLINK-4494:
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2532
Good work.
I merged this, so could you please close the two PRs and the relevant
issues.
> Expose the TimeServiceProvider from the Task to each Operator.
> --
>
> Key: FLINK-4494
> URL: https://issues.apache.org/jira/browse/FLINK-4494
> Project: Flink
> Issue Type: Bug
>Reporter: Kostas Kloudas
>Assignee: Kostas Kloudas
>
> This change aims at simplifying the {{StreamTask}} class by exposing directly
> the {{TimeServiceProvider}} to the operators being executed.
> This implies removing the {{registerTimer()}} and
> {{getCurrentProcessingTime()}} methods from the {{StreamTask}}. Now, to
> register a timer and query the time, each operator will be able to get the
> {{TimeServiceProvider}} and call the corresponding methods directly on it.
> In addition, this will simplify many of the tests which now implement their
> own time providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4494) Expose the TimeServiceProvider from the Task to each Operator.
[
https://issues.apache.org/jira/browse/FLINK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438695#comment-15438695
]
Aljoscha Krettek commented on FLINK-4494:
-
+1 that would be a very good change
> Expose the TimeServiceProvider from the Task to each Operator.
> --
>
> Key: FLINK-4494
> URL: https://issues.apache.org/jira/browse/FLINK-4494
> Project: Flink
> Issue Type: Bug
>Reporter: Kostas Kloudas
>Assignee: Kostas Kloudas
>
> This change aims at simplifying the {{StreamTask}} class by exposing directly
> the {{TimeServiceProvider}} to the operators being executed.
> This implies removing the {{registerTimer()}} and
> {{getCurrentProcessingTime()}} methods from the {{StreamTask}}. Now, to
> register a timer and query the time, each operator will be able to get the
> {{TimeServiceProvider}} and call the corresponding methods directly on it.
> In addition, this will simplify many of the tests which now implement their
> own time providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
