[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17336844#comment-17336844 ] Flink Jira Bot commented on FLINK-4864: --- This issue was labeled "stale-major" 7 ago and has not received any updates so it is being deprioritized. If this ticket is actually Major, please raise the priority and ask a committer to assign you the issue or revive the public discussion. > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Priority: Major > Labels: stale-major > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17328884#comment-17328884 ] Flink Jira Bot commented on FLINK-4864: --- This major issue is unassigned and itself and all of its Sub-Tasks have not been updated for 30 days. So, it has been labeled "stale-major". If this ticket is indeed "major", please either assign yourself or give an update. Afterwards, please remove the label. In 7 days the issue will be deprioritized. > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Priority: Major > Labels: stale-major > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009922#comment-16009922 ] ASF GitHub Bot commented on FLINK-4864: --- Github user wuchong closed the pull request at: https://github.com/apache/flink/pull/2673 > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606184#comment-15606184 ] ASF GitHub Bot commented on FLINK-4864: --- Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2673 Thank you for looking into the details of this. If the user who ran into the issue is using Java, they can fix the issue themselves by relocating our or their Calcite version locally. If the user uses Scala, we could look into fixing the issue with a patch to the shade plugin (maybe using a custom [transformer](https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#transformers)?) Since I ran into the issue before I suspect that we'll run into the issue again. > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605607#comment-15605607 ] ASF GitHub Bot commented on FLINK-4864: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2673 The problem is only present if the Flink application is compiled with the Scala compiler. If I use the Java Quickstart, everything works until the CALCITE-1461 bug appears. @rmetzger pointed me into the right direction. The Scala compiler does not rely on pure bytecode but seems to bypass some type and package information in a so-called `ScalaSig` attribute which is not evaluated by the Java compiler. Apparently, the Maven Shade plugin does not update this special Scala attribute. > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604599#comment-15604599 ] ASF GitHub Bot commented on FLINK-4864: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2673 OK, I could reproduce the issue on my setup, but I have no idea why this happens. I checked the jar file and the Calcite classes seem to be correctly relocated (files are at correct location in jar file, import statements of compiled classes are adapted) and also the Flink Table API classes are compiled with adapted import statements. I created a new Flink project from the Scala Quickstart and the compilation fails in IntelliJ and with Maven. I guess we have to take a deeper look into this issue :-/ > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601890#comment-15601890 ] ASF GitHub Bot commented on FLINK-4864: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2673 Thanks for looking into this @rmetzger. I'll check again on my setup. > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601887#comment-15601887 ] ASF GitHub Bot commented on FLINK-4864: --- Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2673 I tried reproducing the issue reported by @fhueske. The only issue I got was `Caused by: org.codehaus.commons.compiler.CompileException: Line 8, Column 13: Class "org.apache.calcite.rel.metadata.MetadataDef" not found`. I think that'll be fixed with CALCITE-1461. I guess @fhueske's issue is something local with the development environment. > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601535#comment-15601535 ] ASF GitHub Bot commented on FLINK-4864: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2673 Thanks for investigating this and submitting a PR to Calcite, @wuchong! Maybe @rmetzger has an idea of what's going wrong with the shading? > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601148#comment-15601148 ] ASF GitHub Bot commented on FLINK-4864: --- Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2673 Besides the compilation problem , Calcite has a bug [CALCITE-1461](https://issues.apache.org/jira/browse/CALCITE-1461) which will break shading. Maybe we should wait for this issue solved and released. > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597483#comment-15597483 ] ASF GitHub Bot commented on FLINK-4864: --- Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2673 Hi @fhueske . It seems that shading dependency in Scala project is very odd. By adding Calcite dependency to the Table API program project with the flink-table dependency, the compilation failure disappears. But this is not the way we want. Have no idea how to fix this... but I will try to figure it out. > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595076#comment-15595076 ] ASF GitHub Bot commented on FLINK-4864: --- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2673 Thanks for the PR @wuchong. I tried to build a Table API program with the flink-table dependency, but the compilation failed with the following error message: > Caused by: scala.reflect.internal.Types$TypeError: bad symbolic reference. A signature in TableEnvironment.class refers to term parser in value org.apache.sql which is not available. I'm not sure what exactly is going wrong, but it looks like the package `org.apache.sql` is not correct. It should probably be `org.apache.calcite.sql` which has a `parser` subpackage. Thanks, Fabian > Shade Calcite dependency in flink-table > --- > > Key: FLINK-4864 > URL: https://issues.apache.org/jira/browse/FLINK-4864 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL >Affects Versions: 1.2.0 >Reporter: Fabian Hueske >Assignee: Jark Wu > > The Table API has a dependency on Apache Calcite. > A user reported to have version conflicts when having a own Calcite > dependency in the classpath. > The solution would be to shade away the Calcite dependency (Calcite's > transitive dependencies are already shaded). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table
[
https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594176#comment-15594176
]
ASF GitHub Bot commented on FLINK-4864:
---
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2673
[FLINK-4864] [table] Shade Calcite dependency in flink-table
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
This can solve version conflicts when users have a own Calcite dependency
in the classpath.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink shade-calcite-FLINK-4864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2673
commit 61d6c80789cce00f47c04df1e97ed0ea016fcbb3
Author: Jark Wu
Date: 2016-10-21T05:50:21Z
[FLINK-4864] [table] Shade Calcite dependency in flink-table
> Shade Calcite dependency in flink-table
> ---
>
> Key: FLINK-4864
> URL: https://issues.apache.org/jira/browse/FLINK-4864
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Fabian Hueske
>Assignee: Jark Wu
>
> The Table API has a dependency on Apache Calcite.
> A user reported to have version conflicts when having a own Calcite
> dependency in the classpath.
> The solution would be to shade away the Calcite dependency (Calcite's
> transitive dependencies are already shaded).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
