[jira] [Commented] (FLINK-5268) Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase
[
https://issues.apache.org/jira/browse/FLINK-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825990#comment-15825990
]
ASF GitHub Bot commented on FLINK-5268:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3099
> Split TableProgramsTestBase into TableProgramsCollectionTestBase and
> TableProgramsClusterTestBase
> -
>
> Key: FLINK-5268
> URL: https://issues.apache.org/jira/browse/FLINK-5268
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Fabian Hueske
>Priority: Minor
>
> Currently the {{TableProgramsTestBase}} allows to run tests on a collection
> environment and a MiniCluster by setting a testing parameter. This was done
> to cover different execution path. However, testing on a MiniCluster is quite
> expensive and should only be done in rare cases.
> I propose to split the {{TableProgramsTestBase}} into
> * {{TableProgramsCollectionTestBase}} and
> * {{TableProgramsClusterTestBase}}
> to have the separation of both execution backends more clear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5268) Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase
[
https://issues.apache.org/jira/browse/FLINK-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825962#comment-15825962
]
ASF GitHub Bot commented on FLINK-5268:
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3099
LGTM. Merging...
> Split TableProgramsTestBase into TableProgramsCollectionTestBase and
> TableProgramsClusterTestBase
> -
>
> Key: FLINK-5268
> URL: https://issues.apache.org/jira/browse/FLINK-5268
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Fabian Hueske
>Priority: Minor
>
> Currently the {{TableProgramsTestBase}} allows to run tests on a collection
> environment and a MiniCluster by setting a testing parameter. This was done
> to cover different execution path. However, testing on a MiniCluster is quite
> expensive and should only be done in rare cases.
> I propose to split the {{TableProgramsTestBase}} into
> * {{TableProgramsCollectionTestBase}} and
> * {{TableProgramsClusterTestBase}}
> to have the separation of both execution backends more clear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5268) Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase
[
https://issues.apache.org/jira/browse/FLINK-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824028#comment-15824028
]
ASF GitHub Bot commented on FLINK-5268:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3099
Thanks for the PR @mtunique.
+1 to merge
> Split TableProgramsTestBase into TableProgramsCollectionTestBase and
> TableProgramsClusterTestBase
> -
>
> Key: FLINK-5268
> URL: https://issues.apache.org/jira/browse/FLINK-5268
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Fabian Hueske
>Priority: Minor
>
> Currently the {{TableProgramsTestBase}} allows to run tests on a collection
> environment and a MiniCluster by setting a testing parameter. This was done
> to cover different execution path. However, testing on a MiniCluster is quite
> expensive and should only be done in rare cases.
> I propose to split the {{TableProgramsTestBase}} into
> * {{TableProgramsCollectionTestBase}} and
> * {{TableProgramsClusterTestBase}}
> to have the separation of both execution backends more clear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5268) Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase
[
https://issues.apache.org/jira/browse/FLINK-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821889#comment-15821889
]
Jark Wu commented on FLINK-5268:
Hi [~fhueske] , do we have the case that an IT case should run both on
collection environment and cluster environment ?
And when should we use cluster environment ? I think we should add some
comments to remind developers when to use {{TableProgramsClusterTestBase}} .
> Split TableProgramsTestBase into TableProgramsCollectionTestBase and
> TableProgramsClusterTestBase
> -
>
> Key: FLINK-5268
> URL: https://issues.apache.org/jira/browse/FLINK-5268
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Fabian Hueske
>Priority: Minor
>
> Currently the {{TableProgramsTestBase}} allows to run tests on a collection
> environment and a MiniCluster by setting a testing parameter. This was done
> to cover different execution path. However, testing on a MiniCluster is quite
> expensive and should only be done in rare cases.
> I propose to split the {{TableProgramsTestBase}} into
> * {{TableProgramsCollectionTestBase}} and
> * {{TableProgramsClusterTestBase}}
> to have the separation of both execution backends more clear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5268) Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase
[
https://issues.apache.org/jira/browse/FLINK-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820589#comment-15820589
]
ASF GitHub Bot commented on FLINK-5268:
---
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3099
[FLINK-5268] Split TableProgramsTestBase into
TableProgramsCollectionTestBase and TableProgramsClusterTestBase
…TestBase and TableProgramsClusterTestBase
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink flink-5268
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3099.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3099
commit a99b2bfe5a06677163cf62dcc6716bf641422d5e
Author: mtunique
Date: 2017-01-12T09:30:57Z
[FLINK-5268] Split TableProgramsTestBase into
TableProgramsCollectionTestBase and TableProgramsClusterTestBase
> Split TableProgramsTestBase into TableProgramsCollectionTestBase and
> TableProgramsClusterTestBase
> -
>
> Key: FLINK-5268
> URL: https://issues.apache.org/jira/browse/FLINK-5268
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
>Affects Versions: 1.2.0
>Reporter: Fabian Hueske
>Priority: Minor
>
> Currently the {{TableProgramsTestBase}} allows to run tests on a collection
> environment and a MiniCluster by setting a testing parameter. This was done
> to cover different execution path. However, testing on a MiniCluster is quite
> expensive and should only be done in rare cases.
> I propose to split the {{TableProgramsTestBase}} into
> * {{TableProgramsCollectionTestBase}} and
> * {{TableProgramsClusterTestBase}}
> to have the separation of both execution backends more clear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
