[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745174#comment-15745174
]
ASF GitHub Bot commented on FLINK-5304:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2978
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745043#comment-15745043
]
ASF GitHub Bot commented on FLINK-5304:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2978
Merging
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735382#comment-15735382
]
ASF GitHub Bot commented on FLINK-5304:
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2978#discussion_r91718067
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCorrelate.scala
---
@@ -34,7 +34,7 @@ import
org.apache.flink.api.table.plan.nodes.FlinkCorrelate
import org.apache.flink.api.table.typeutils.TypeConverter._
/**
- * Flink RelNode which matches along with cross apply a user defined
table function.
+ * Flink RelNode which matches along with join a user defined table
function.
--- End diff --
`with a join on a user defined table function`
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735381#comment-15735381
]
ASF GitHub Bot commented on FLINK-5304:
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2978#discussion_r91718117
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamCorrelate.scala
---
@@ -33,7 +33,7 @@ import
org.apache.flink.api.table.typeutils.TypeConverter._
import org.apache.flink.streaming.api.datastream.DataStream
/**
- * Flink RelNode which matches along with cross apply a user defined
table function.
+ * Flink RelNode which matches along with join a user defined table
function.
--- End diff --
see above
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735383#comment-15735383
]
ASF GitHub Bot commented on FLINK-5304:
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2978#discussion_r91717856
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/FlinkCorrelate.scala
---
@@ -63,17 +63,17 @@ trait FlinkCorrelate {
""".stripMargin
if (joinType == SemiJoinType.INNER) {
- // cross apply
+ // cross join
--- End diff --
`cross join` -> `inner join`
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735174#comment-15735174
]
ASF GitHub Bot commented on FLINK-5304:
---
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2978
[FLINK-5304] [table] Change method name from crossApply to join in Table API
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
Currently, the UDTF in Table API is used with `crossApply`, but is used
with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
`.join("udtf(c) as (s)")` in Table API too, and join is more familiar to users
than `crossApply`. The `outerApply` should be renamed to `leftOuterJoin`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink change-crossApply-to-join
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2978.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2978
commit a8956658ab01e3a1de242771661cffea79fc512b
Author: Jark Wu
Date: 2016-12-09T02:31:15Z
[FLINK-5304] [table] Change method name from crossApply to join in Table API
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734992#comment-15734992
]
Jark Wu commented on FLINK-5304:
Yes. {{outerApply}} will be renamed to {{leftOuterJoin}}
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734941#comment-15734941
]
Timo Walther commented on FLINK-5304:
-
I'm fine with this change but what happens with {{outerApply}}? We should also
rename it to {{leftOuterJoin()}} to be consistent.
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
[
https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734857#comment-15734857
]
Fabian Hueske commented on FLINK-5304:
--
Makes sense to me.
What do you think [~twalthr]?
> Change method name from crossApply to join in Table API
> ---
>
> Key: FLINK-5304
> URL: https://issues.apache.org/jira/browse/FLINK-5304
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
>Reporter: Jark Wu
>Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used
> with JOIN in SQL. UDTF is something similar to Table, so it make sense to use
> {{.join("udtf(c) as (s)")}} in Table API too, and join is more familiar to
> users than {{crossApply}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
