[jira] [Commented] (FLINK-5330) Harden KafkaConsumer08Test

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748189#comment-15748189
 ] 

ASF GitHub Bot commented on FLINK-5330:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2998


> Harden KafkaConsumer08Test
> --
>
> Key: FLINK-5330
> URL: https://issues.apache.org/jira/browse/FLINK-5330
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{KafkaConsumer08Test}} assumes that some of the Kafka bootstrap server 
> hostname cannot be resolved. This can lead to failures if these names are 
> wrongly resolved by chance (e.g. if using Google's DNS server). Moreover, the 
> test cases take a long time to finish because the connection timeouts are set 
> to a high value. This can be decreased to speed these test cases up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5330) Harden KafkaConsumer08Test

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748014#comment-15748014
 ] 

ASF GitHub Bot commented on FLINK-5330:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2998
  
Merging this...


> Harden KafkaConsumer08Test
> --
>
> Key: FLINK-5330
> URL: https://issues.apache.org/jira/browse/FLINK-5330
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{KafkaConsumer08Test}} assumes that some of the Kafka bootstrap server 
> hostname cannot be resolved. This can lead to failures if these names are 
> wrongly resolved by chance (e.g. if using Google's DNS server). Moreover, the 
> test cases take a long time to finish because the connection timeouts are set 
> to a high value. This can be decreased to speed these test cases up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5330) Harden KafkaConsumer08Test

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747948#comment-15747948
 ] 

ASF GitHub Bot commented on FLINK-5330:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2998
  
Looks good to me, +1


> Harden KafkaConsumer08Test
> --
>
> Key: FLINK-5330
> URL: https://issues.apache.org/jira/browse/FLINK-5330
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{KafkaConsumer08Test}} assumes that some of the Kafka bootstrap server 
> hostname cannot be resolved. This can lead to failures if these names are 
> wrongly resolved by chance (e.g. if using Google's DNS server). Moreover, the 
> test cases take a long time to finish because the connection timeouts are set 
> to a high value. This can be decreased to speed these test cases up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5330) Harden KafkaConsumer08Test

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745330#comment-15745330
 ] 

ASF GitHub Bot commented on FLINK-5330:
---

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/2998

[FLINK-5330] [tests] Harden KafkaConsumer08Test to fail reliably with 
unknown host exception

Using static mocking to reliably fail the InetAddress.getByName call with 
an UnknowHostException.
Furthermore, the PR decreases the connection timeouts which speeds the test 
execution up.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink fixKafkaConsumer08Test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2998


commit e91b4593122ec223dbd3c2140ba7e82d2282bc1d
Author: Till Rohrmann 
Date:   2016-12-13T14:48:06Z

[FLINK-5330] [tests] Harden KafkaConsumer08Test to fail reliably with 
unknown host exception

Using static mocking to reliably fail the InetAddress.getByName call with 
an UnknowHostException.
Furthermore, the PR decreases the connection timeouts which speeds the test 
execution up.




> Harden KafkaConsumer08Test
> --
>
> Key: FLINK-5330
> URL: https://issues.apache.org/jira/browse/FLINK-5330
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{KafkaConsumer08Test}} assumes that some of the Kafka bootstrap server 
> hostname cannot be resolved. This can lead to failures if these names are 
> wrongly resolved by chance (e.g. if using Google's DNS server). Moreover, the 
> test cases take a long time to finish because the connection timeouts are set 
> to a high value. This can be decreased to speed these test cases up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)